1. 15 1月, 2015 9 次提交
  2. 07 1月, 2015 1 次提交
    • C
      wil6210: use 'uint64_t' instead of 'cycles_t' to avoid warnings · c20e7789
      Chen Gang 提交于
      do_div() checks the type strictly. 'cycles_t' may be 32-bit under quite
      a few architectures (parisc, arm, avr32 ...). So use 'uint64_t' instead
      of, the related warning (with allmodconfig under parisc):
      
          CC [M]  drivers/net/wireless/ath/wil6210/debugfs.o
        In file included from arch/parisc/include/generated/asm/div64.h:1:0,
                         from include/linux/kernel.h:124,
                         from include/linux/list.h:8,
                         from include/linux/module.h:9,
                         from drivers/net/wireless/ath/wil6210/debugfs.c:17:
        drivers/net/wireless/ath/wil6210/debugfs.c: In function ‘wil_vring_debugfs_show’:
        include/asm-generic/div64.h:43:28: warning: comparison of distinct pointer types lacks a cast
          (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
                                    ^
        drivers/net/wireless/ath/wil6210/debugfs.c:107:4: note: in expansion of macro ‘do_div’
            do_div(idle, total);
            ^
        In file included from include/uapi/linux/stddef.h:1:0,
                         from include/linux/stddef.h:4,
                         from ./include/uapi/linux/posix_types.h:4,
                         from include/uapi/linux/types.h:13,
                         from include/linux/types.h:5,
                         from include/linux/list.h:4,
                         from include/linux/module.h:9,
                         from drivers/net/wireless/ath/wil6210/debugfs.c:17:
        include/asm-generic/div64.h:44:18: warning: right shift count >= width of type [-Wshift-count-overflow]
          if (likely(((n) >> 32) == 0)) {   \
                          ^
        include/linux/compiler.h:159:40: note: in definition of macro ‘likely’
         # define likely(x) __builtin_expect(!!(x), 1)
                                                ^
        drivers/net/wireless/ath/wil6210/debugfs.c:107:4: note: in expansion of macro ‘do_div’
            do_div(idle, total);
            ^
        In file included from arch/parisc/include/generated/asm/div64.h:1:0,
                         from include/linux/kernel.h:124,
                         from include/linux/list.h:8,
                         from include/linux/module.h:9,
                         from drivers/net/wireless/ath/wil6210/debugfs.c:17:
        include/asm-generic/div64.h:48:22: warning: passing argument 1 of ‘__div64_32’ from incompatible pointer type [-Wincompatible-pointer-types]
           __rem = __div64_32(&(n), __base); \
                              ^
        drivers/net/wireless/ath/wil6210/debugfs.c:107:4: note: in expansion of macro ‘do_div’
            do_div(idle, total);
            ^
        include/asm-generic/div64.h:35:17: note: expected ‘uint64_t * {aka long long unsigned int *}’ but argument is of type ‘cycles_t * {aka long unsigned int *}’
         extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);
                         ^
      Signed-off-by: NChen Gang <gang.chen.5i5j@gmail.com>
      Signed-off-by: NKalle Valo <kvalo@codeaurora.org>
      c20e7789
  3. 02 12月, 2014 10 次提交
  4. 31 10月, 2014 5 次提交
  5. 20 10月, 2014 1 次提交
  6. 03 10月, 2014 2 次提交
  7. 29 9月, 2014 1 次提交
  8. 27 9月, 2014 1 次提交
  9. 16 9月, 2014 1 次提交
    • V
      fixup! wil6210: fix usage of print_hex_dump_debug · a43b5142
      Vladimir Kondratiev 提交于
      Use empty inline functions instead of empty #define. Fix for "unused variable"
      as reported below:
      
      tree:   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git master
      head:   167bf96d
      commit: 871d8c4b [45/62] wil6210: fix usage of print_hex_dump_debug
      config: i386-allyesconfig
      reproduce:
        git checkout 871d8c4b
        make ARCH=i386  allyesconfig
        make ARCH=i386
      
      All warnings:
      
         drivers/net/wireless/ath/wil6210/wmi.c: In function 'wmi_evt_rx_mgmt':
      
      >> drivers/net/wireless/ath/wil6210/wmi.c:341:10: warning: unused variable 'ie_len' [-Wunused-variable]
            size_t ie_len = d_len - offsetof(struct ieee80211_mgmt,
                   ^
      
      >> drivers/net/wireless/ath/wil6210/wmi.c:340:13: warning: unused variable 'ie_buf' [-Wunused-variable]
            const u8 *ie_buf = rx_mgmt_frame->u.beacon.variable;
                      ^
      
      vim +/ie_len +341 drivers/net/wireless/ath/wil6210/wmi.c
      
      2be7d22f Vladimir Kondratiev 2012-12-20  334
      2be7d22f Vladimir Kondratiev 2012-12-20  335    if (ieee80211_is_beacon(fc) || ieee80211_is_probe_resp(fc)) {
      2be7d22f Vladimir Kondratiev 2012-12-20  336            struct cfg80211_bss *bss;
      8eea944a Vladimir Kondratiev 2014-06-16  337            u64 tsf = le64_to_cpu(rx_mgmt_frame->u.beacon.timestamp);
      8eea944a Vladimir Kondratiev 2014-06-16  338            u16 cap = le16_to_cpu(rx_mgmt_frame->u.beacon.capab_info);
      8eea944a Vladimir Kondratiev 2014-06-16  339            u16 bi = le16_to_cpu(rx_mgmt_frame->u.beacon.beacon_int);
      8eea944a Vladimir Kondratiev 2014-06-16  340            const u8 *ie_buf = rx_mgmt_frame->u.beacon.variable;
      8eea944a Vladimir Kondratiev 2014-06-16  341            size_t ie_len = d_len - offsetof(struct ieee80211_mgmt,
      8eea944a Vladimir Kondratiev 2014-06-16  342                                             u.beacon.variable);
      8eea944a Vladimir Kondratiev 2014-06-16  343            wil_dbg_wmi(wil, "Capability info : 0x%04x\n", cap);
      8eea944a Vladimir Kondratiev 2014-06-16  344            wil_dbg_wmi(wil, "TSF : 0x%016llx\n", tsf);
      
      :::::: The code at line 341 was first introduced by commit
      :::::: 8eea944a wil6210: print more info about BSS found
      Signed-off-by: NVladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      a43b5142
  10. 12 9月, 2014 9 次提交