1. 13 6月, 2013 1 次提交
  2. 09 6月, 2013 1 次提交
  3. 25 4月, 2013 2 次提交
  4. 15 4月, 2013 2 次提交
  5. 05 4月, 2013 3 次提交
  6. 31 3月, 2013 5 次提交
  7. 22 3月, 2013 1 次提交
  8. 06 3月, 2013 1 次提交
  9. 06 2月, 2013 4 次提交
  10. 26 1月, 2013 1 次提交
  11. 06 1月, 2013 1 次提交
    • S
      [media] s5p-fimc: Prevent AB-BA deadlock during links reconfiguration · 740ad921
      Sylwester Nawrocki 提交于
      This patch patch eliminates potential AB-BA deadlock when one process calls
      open(), or VIDIOC_S/TRY_FMT ioctl  on the FIMC capture video node, while
      other thread is reconfiguring media links via media device node:
      /dev/video? open()		  /dev/media? MEDIA_IOC_SETUP_LINK ioctl
      mutex_lock(video_lock)            mutex_lock(graph_lock)
          fimc_pipeline_open()               fimc_md_link_notify()
              mutex_lock(graph_lock)	          mutex_lock(video_lock)
                ...                               ...
      The deadlock is avoided by always taking the graph mutex first in video
      node open() or an ioctl, before the video lock is acquired. Reversed
      order seems impossible, since media device driver's link_notify callback
      is called with media graph mutex already held.
      To ensure proper locking order VIDIOC_S_FMT and VIDIOC_TRY_FMT ioctls are
      not serialized in the v4l2-core and the driver takes care of it itself.
      Signed-off-by: NSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: NKyungmin Park <kyungmin.park@samsung.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      740ad921
  12. 04 1月, 2013 1 次提交
    • G
      Drivers: media: remove __dev* attributes. · 4c62e976
      Greg Kroah-Hartman 提交于
      CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
      markings need to be removed.
      
      This change removes the use of __devinit, __devexit_p, __devinitdata,
      __devinitconst, and __devexit from these drivers.
      
      Based on patches originally written by Bill Pemberton, but redone by me
      in order to handle some of the coding style issues better, by hand.
      
      Cc: Bill Pemberton <wfp5p@virginia.edu>
      Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      4c62e976
  13. 21 12月, 2012 1 次提交
  14. 27 11月, 2012 2 次提交
  15. 26 10月, 2012 1 次提交
  16. 03 10月, 2012 1 次提交
  17. 02 10月, 2012 4 次提交
  18. 16 8月, 2012 1 次提交
  19. 07 7月, 2012 3 次提交
  20. 25 6月, 2012 3 次提交
    • S
      [media] s5p-fimc: Fix compiler warning in fimc-lite.c · a1a5861b
      Sachin Kamat 提交于
      This patch is an update to changed media_entity_pipeline_start()
      signature in commit af88be38,
      "media: Add link_validate() op to check links to the sink pad"
      
      It fixes the following warning:
      
      drivers/media/video/s5p-fimc/fimc-lite.c: In function ‘fimc_lite_streamon’:
      drivers/media/video/s5p-fimc/fimc-lite.c:765:29: warning: ignoring return value
      of ‘media_entity_pipeline_start’, declared with attribute warn_unused_result [-Wunused-result]
      Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
      Signed-off-by: NSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      a1a5861b
    • S
      [media] s5p-fimc: Fix fimc-lite system wide suspend procedure · 316efab3
      Sylwester Nawrocki 提交于
      Only suspend the video pipeline devices if they were active before
      the pm.suspend() helper is called. This patch prevents following error:
      
      /# echo mem > /sys/power/state
      [   34.965000] PM: Syncing filesystems ... done.
      [   35.035000] Freezing user space processes ... (elapsed 0.01 seconds) done.
      ...
      [   35.105000] dpm_run_callback(): platform_pm_suspend+0x0/0x5c returns -22
      [   35.105000] PM: Device exynos-fimc-lite.1 failed to suspend: error -22
      [   35.105000] PM: Some devices failed to suspend
      Signed-off-by: NSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: NKyungmin Park <kyungmin.park@samsung.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      316efab3
    • S
      [media] s5p-fimc: Prevent lock-up in multiple sensor systems · e3fc82e8
      Sylwester Nawrocki 提交于
      The camera clocks managed by the driver were improperly reference counted
      and remained disabled when multiple video nodes were opened simultaneously.
      It manifested itself with following warning:
      
       [12.920000] WARNING: at drivers/media/video/s5p-fimc/fimc-mdevice.c:787 __fimc_md_set_camclk+0x1c0/0x1dc()
       [13.005000] Modules linked in:
       [13.005000] Backtrace:
       [13.040000] [<c0013084>] (dump_backtrace+0x0/0x10c) from [<c0454b70>] (dump_stack+0x18/0x1c)
       [13.070000]  r7:00000009 r6:00000313 r5:c02d576c r4:00000000
       [13.155000] [<c0454b58>] (dump_stack+0x0/0x1c) from [<c0022ec4>] (warn_slowpath_common+0x54/0x6c)
       [13.285000] [<c0022e70>] (warn_slowpath_common+0x0/0x6c) from [<c0022f00>] (warn_slowpath_null+0x24/0x2c)
       [13.360000]  r9:e1981010 r8:00000000 r7:c061d3fc r6:e1981010 r5:e1981030
       [13.430000] r4:00000000
       [13.430000] [<c0022edc>] (warn_slowpath_null+0x0/0x2c) from [<c02d576c>] (__fimc_md_set_camclk+0x1c0/0x1dc)
       [13.550000] [<c02d55ac>] (__fimc_md_set_camclk+0x0/0x1dc) from [<c02d57b0>] (fimc_md_set_camclk+0x28/0x2c)
       [13.630000] [<c02d5788>] (fimc_md_set_camclk+0x0/0x2c) from [<c02d57e8>] (__fimc_pipeline_shutdown+0x34/0x50)
       [13.705000] [<c02d57b4>] (__fimc_pipeline_shutdown+0x0/0x50) from [<c02d5844>] (fimc_pipeline_shutdown+0x40/0x58)
       [13.765000]  r5:e2391200 r4:e2357704
       [13.805000] [<c02d5804>] (fimc_pipeline_shutdown+0x0/0x58) from [<c02d4754>] (fimc_capture_close+0xcc/0xe4)
       [13.915000]  r5:e1b396c0 r4:e2357410
       [13.915000] [<c02d4688>] (fimc_capture_close+0x0/0xe4) from [<c02b2d5c>] (v4l2_release+0x5c/0x80)
       [13.970000]  r7:00000010 r6:e1d2d990 r5:e1b396c0 r4:e2394800
       [14.000000] [<c02b2d00>] (v4l2_release+0x0/0x80) from [<c00b66cc>] (fput+0xc0/0x22c)
       [14.015000]  r5:c157ef30 r4:e1b396c0
       [14.015000] [<c00b660c>] (fput+0x0/0x22c) from [<c00b2ca0>] (filp_close+0x60/0x80)
       [14.080000] [<c00b2c40>] (filp_close+0x0/0x80) from [<c00b2d78>] (sys_close+0xb8/0xf4)
       [14.125000]  r7:00000001 r6:e1b396c0 r5:c1400340 r4:c1400300
       [14.125000] [<c00b2cc0>] (sys_close+0x0/0xf4) from [<c000f300>] (ret_fast_syscall+0x0/0x30)
       [14.205000]  r7:00000006 r6:beee5b94 r5:00000003 r4:b6f64fac
      
      Fix this, as well as potential memory leaks due to not calling
      v4l2_fh_release() on some error paths.
      
      Also remove some error logs printed for events that aren't critical and
      are normal conditions for some system configurations.
      
      Also check if the device have been properly run-time enabled during
      video node open.
      Signed-off-by: NSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: NKyungmin Park <kyungmin.park@samsung.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      e3fc82e8
  21. 20 5月, 2012 1 次提交