There are a few errors at the PLL calculus, causing the device
to use wrong values.
While here, change the calculus to use 32 bits, as there's no
need for 64 bits there.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

r820t_standby() can be called before r820t_init().
If that happens, just do nothing.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

The rtl-sdr library disabled IMR callibration. While I'm not sure
yet why, it could be a good idea to add a modprobe parameter here,
to allow to also disable it. There are two rationale behind it:
- It helps to compare USB dumps between rtl-sdr and the Kernel module;
- If rtl-sdr disabled it, perhaps there's a good reason (e. g. it
  might not be actually working, or it might be causing some trouble).
For both cases, it seems useful to add a modprobe parameter to allow
testing the device with both configurations.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Add the code to set the GPIO for this tuner. This code is
currently unused, so it is kept there only for completeness.
With this patch there are just two things that got left from
the original driver:
- At standby, there's another mode, not used by rtl2832u.
  Not sure if it might be needed in the future, but I suspect
  it is not used at all;
- There is a "fast tune" mode. As nor DVB or V4L API supports
  it, it seems an overkill to implement it.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

This code seems to calibrate I/Q phase and gain during the
device initialization.
This is done only once, and it doesn't seem to be needed to
happen after resuming.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

The rtl-sdr library, from where this driver was initially
based, doesn't use half PLL clock, but this is used on
the Realtek Kernel driver. So, also do the same here.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Instead of using msleep(), use sleep_range(), as it provides
a closer sleep time.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Just cosmetic changes: all other functions are prefixed
by r820t. Do the same for r820t_read().
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

As we'll need to retrieve cached registers, make this
function explicit.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

If signal is zero, shows it as a zero, not as 0xff.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

This is part of the original driver, and adding it doesn't hurt,
so add it, to better sync the code.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

As the driver's logic uses the bit-reversed order for read,
use it as well when displaying the debug messages.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

The Realtek Kernel driver uses the second DVB-T 7MHz table instead
of the first one. Use it as well.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

On read, the bit order is inverted.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

DVBT_EN_BBIN should be set on both places where IF is set. So,
move it to a function and call it where needed.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

IF is set at r820t_set_tv_standard(). So, we can't calculate
LO frequency before calling it.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

There are some init stuff to be done for each new tuner at the
demod code. Add the code there for r820t.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Scale used at get_if_freq and LO freq calculus is Hz.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

	[ 2255.342797] r820t 3-001a: generic_set_freq: PLL locked on frequency 725476191 Hz, gain=45
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

As this tuner can be used by analog and digital parts of the
driver, be sure that all ops that access the hardware will
be be properly locked.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Now that we can get the strength from r820t, use it.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

This tuner works with 2 modes: automatic gain mode and manual
gain mode. Put it into automatic mode, as we currently don't
have any API for manual gain adjustment.
The logic to allow setting the manual mode is there, as it is
just a few extra code. This way, if/when we latter add support
for setting the gain mode, the code is already there.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

Instead of a binary signal strength measure, use the tuner gain
to obtain a better estimation of the signal strength.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

This tuner is used on some rtl2882 dongles. Add it to the driver.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

This driver was written from scratch, based on an existing driver
that it is part of rtl-sdr git tree, released under GPLv2:
	https://groups.google.com/forum/#!topic/ultra-cheap-sdr/Y3rBEOFtHug
	https://github.com/n1gp/gr-baz
	http://cgit.osmocom.org/rtl-sdr/plain/src/tuner_r820t.c
	(there are also other variants of it out there)
>From what I understood from the threads, the original driver was converted
to userspace from a Realtek tree. I couldn't find the original tree.
However, the original driver look awkward on my eyes. So, I decided to
write a new version from it from the scratch, while trying to reproduce
everything found there.
TODO:
- After locking, the original driver seems to have some routines to
  improve reception. This was not implemented here yet.
- RF Gain set/get is not implemented.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: NAntti Palosaari <crope@iki.fi>

From Fengguang Wu <fengguang.wu@intel.com>:

> drivers/media/pci/sta2x11/sta2x11_vip.c: In function 'sta2x11_vip_init_one':
> drivers/media/pci/sta2x11/sta2x11_vip.c:1314:2: error: implicit declaration of function 'i2c_get_adapter' [-Werror=implicit-function-declaration]
> drivers/media/pci/sta2x11/sta2x11_vip.c:1314:15: warning: assignment makes pointer from integer without a cast [enabled by default]
> drivers/media/pci/sta2x11/sta2x11_vip.c:1330:2: error: implicit declaration of function 'i2c_put_adapter' [-Werror=implicit-function-declaration]

And also:

> warning: (STA2X11_VIP) selects VIDEO_ADV7180 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_V4L2 && I2C)
> drivers/media/i2c/adv7180.c: In function '__adv7180_status':
> drivers/media/i2c/adv7180.c:194:2: error: implicit declaration of function 'i2c_smbus_read_byte_data' [-Werror=implicit-function-declaration]
> drivers/media/i2c/adv7180.c: In function 'adv7180_s_routing':
> drivers/media/i2c/adv7180.c:251:2: error: implicit declaration of function 'i2c_smbus_write_byte_data' [-Werror=implicit-function-declaration]
> drivers/media/i2c/adv7180.c: In function 'adv7180_probe':
> drivers/media/i2c/adv7180.c:551:2: error: implicit declaration of function 'i2c_check_functionality' [-Werror=implicit-function-declaration]
> drivers/media/i2c/adv7180.c:554:2: error: implicit declaration of function 'i2c_adapter_id' [-Werror=implicit-function-declaration]
> drivers/media/i2c/adv7180.c: At top level:
> drivers/media/i2c/adv7180.c:663:1: warning: data definition has no type or storage class [enabled by default]
> drivers/media/i2c/adv7180.c:663:1: warning: type defaults to 'int' in declaration of 'module_i2c_driver' [-Wimplicit-int]
> drivers/media/i2c/adv7180.c:663:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/media/i2c/adv7180.c:649:26: warning: 'adv7180_driver' defined but not used [-Wunused-variable]

This is due to the lack of I2C support:

...
> CONFIG_I2C is not set
...

So, Make sure that sta2x11_vip depends on I2C.
Reported-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

There are three drivers with *it913x name on it, and they all
belong to the same device:
	a tuner, at it913x.c;
	a frontend: it913x-fe.c;
	a bridge: it913x.c, renamed to dvb_usb_it913x by the
building system.

This is confusing. Even more confusing are the two .c files with
the same name under different directories, with different contents
and different functions. So, prepend the tuner one.

This also breaks the out-of-tree compilation system.
Reported-by: NFrederic Fays <frederic.fays@gmail.com>
Acked-by: NAntti Palosaari <crope@iki.fi>
Reviewed-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Fix mceusb_cmdsize() which returns incorrect datasize=0 for
sub-commands MCE_RSP_GETPORTSTATUS, MCE_RSP_GETWAKESOURCE,
MCE_RSP_EQDEVDETAILS, MCE_RSP_EQEMVER, and MCE_RSP_EQIRNUMPORTS.

While here, change mceusb_cmdsize() name to reflect that it returns
data size not cmd size.
Signed-off-by: NWilliam Steidtmann <billstei@hbci.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Don't print proc_dir_entry data in debug as we're soon to have no direct
access to the contents of the PDE.  Print what was put in there instead.
Signed-off-by: NDavid Howells <dhowells@redhat.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

VIDEO_GO7007 uses usb interfaces so it should depend on USB.
It also selects CYPRESS_FIRMWARE, which depends on USB.
Fixes build errors and a kconfig warning:
go7007-loader.c:(.text+0xcc7d0): undefined reference to `usb_get_dev'
go7007-loader.c:(.init.text+0x49f0): undefined reference to `usb_register_driver'
go7007-loader.c:(.exit.text+0x17ce): undefined reference to `usb_deregister'
warning: (DVB_USB_AZ6007 && VIDEO_GO7007) selects CYPRESS_FIRMWARE which has unmet direct dependencies (MEDIA_SUPPORT && USB)
Signed-off-by: NRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Commit cd634f1b ("[media] v4l2: put VIDIOC_DBG_G_CHIP_NAME under
ADV_DEBUG") missed the initializer of radio_ioctl_ops:
drivers/media/usb/em28xx/em28xx-video.c:1830:2: error: unknown field 'vidioc_g_chip_info' specified in initializer
drivers/media/usb/em28xx/em28xx-video.c:1830:26: error: 'vidioc_g_chip_info' undeclared here (not in a function)
Signed-off-by: NMichal Marek <mmarek@suse.cz>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

drivers/media/dvb-frontends/cxd2820r_t2.c: In function 'cxd2820r_set_frontend_t2':
drivers/media/dvb-frontends/cxd2820r_t2.c:128:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Map RC_MAP_REDDO to that device.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

It is very similar than rc-msi-digivox-iii but new keytable is needed
as there is one existing scancode mapped to different button. Also that
one has less buttons.
NEC extended protocol with address 0x61d6.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The length of mmap() can be bigger than length of vb2 buffer, so
it should be checked.
Signed-off-by: NSeung-Woo Kim <sw0312.kim@samsung.com>
Acked-by: NMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.
Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.
Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.
Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>