This function just converts from the as10x internal data into
the DVBv5 cache. Get rid of it.

No functional changes.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

This function just parses the frontend cache and converts
to the as102 internal format message. Get rid of it.

No functional changes.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Avoid having function prototypes by moving some
ancillary routines to the beginning of the file.

No functional changes.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Make the frontend .name more coherent with DVB namespace.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Fix this warning:

WARNING: quoted string split across lines
566: FILE: drivers/media/usb/as102/as102_fe.c:141:
+				"demod status: fc: 0x%08x, bad fc: 0x%08x, "
+				"bytes corrected: 0x%08x , MER: 0x%04x\n",
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Make checkpatch happier by removing FSF mail address.

No functional changes.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

This driver is stable and doesn't contain any really serious
issue. Move it out of staging.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

remove dprintk() and replace it with dev_dbg() or pr_debug()
in order to use the common kernel coding style.
Signed-off-by: NMartin Kepplinger <martink@posteo.de>
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

This patch fixes the following checkpatch.pl issues in
as102/as102_fe.c
WARNING: line over 80 characters
Signed-off-by: NMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

This patch fixes the following checkpatch.pl issues in
as102/as102_fe.c
WARNING: quoted string split across lines
Signed-off-by: NMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Too much noise, also does not cover every possible code paths.
Signed-off-by: NMauro Dreissig <mukadr@gmail.com>
Acked-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

There was a warning when ran "make versioncheck"

drivers/staging/media/as102/as102_fe.c: 20 linux/version.h not needed.
Signed-off-by: Njoseph daniel <josephdanielwalter@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The output of "make versioncheck" told us that:

drivers/staging/media/as102/as102_fe.c: 20 linux/version.h not needed.

If we take a look at the code, we can agree to remove this include.

Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-media@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org>
Signed-off-by: NMarcos Paulo de Souza <marcos.souza.org@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

linux-next:
I like to spend some time reading code, in doing so I have found some
typos in some of the comments.
Signed-off-by: NJustin P. Mattock <justinmattock@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Ryley and me tested several eLNA configuration values with both a rooftop
and a portable antenna.

Ryley fuond out that the best value for his Elgato stick is indeed the current
default value 0xC0.

Instead, my stick is not capable of tuning VHF channels with 0xC0. With 0x80,
VHF works but the tuner sensitivity with the portable antenna is poor.
Instead, the value 0xA0 works with VHF and also gives good performance with
both the rooftop and the portable antenna.

So we concluded that devices built on the reference design work best with 0xA0,
while custom designs (Elgato, PCTV) seem to require 0xC0.

I also removed the unused parameter "minor" in struct as102_dev_t.
Signed-off-by: NGianluca Gennari <gennarone@gmail.com>
Signed-off-by: NRyley Angus <rangus@student.unimelb.edu.au>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Now, ops->info.type is handled inside the dvb_frontend
core, only for DVBv3 calls, and according with the
delivery system. So, drivers should not care or use it,
otherwise, it may have issues with DVBv5 calls.

The drivers that were still using it were detected via
this small temporary hack:

--- a/include/linux/dvb/frontend.h
+++ b/include/linux/dvb/frontend.h
@@ -29,13 +29,16 @@
 #include <linux/types.h>

 typedef enum fe_type {
+#if defined(__DVB_CORE__) || !defined (__KERNEL__)
        FE_QPSK,
        FE_QAM,
        FE_OFDM,
        FE_ATSC
+#else
+FE_FOOO
+#endif
 } fe_type_t;

-
 typedef enum fe_caps {
        FE_IS_STUPID                    = 0,
        FE_CAN_INVERSION_AUTO           = 0x1,
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Instead of using dvb_frontend_parameters struct, that were
designed for a subset of the supported standards, use the DVBv5
cache information.

Also, fill the supported delivery systems at dvb_frontend_ops
struct.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Creates a DVBv5 get_frontend call, renaming the DVBv3 one to
get_frontend_legacy(), while not all frontends are converted.

After the conversion for all drivers, get_frontend_legacy()
will be removed.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Passing DVBv3 parameters to set_frontend is not fun, as the
core doesn't have any way to know if the driver is using the
v3 or v5 parameters. So, rename the callback and add a new
one to allow distinguish between a mixed v3/v5 paramenter call
from a pure v5 call.

After having all frontends to use the new way, the legacy
call can be removed.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Fixes following checkpatch.pl warning:
WARNING: externs should be avoided in .c files

Cc: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: NSylwester Nawrocki <snjw23@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Cc: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: NPiotr Chmura <chmooreck@poczta.onet.pl>
Signed-off-by: NSylwester Nawrocki <snjw23@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Remove #if's related to kernel version and the code not applicable
to 3.2+ kernels.

Cc: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: NSylwester Nawrocki <snjw23@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The driver depends on DVB_CORE so there is no need for conditional
compilation of parts of the code depending on CONFIG_DVB_CORE as
the driver is never compiled with CONFIG_DVB_CORE* disabled.

Cc: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: NSylwester Nawrocki <snjw23@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Properly handle the case where the driver can be associated with
multiple different products (as opposed to always saying the device
is named after the value in a #define).
Signed-off-by: NDevin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: NPiotr Chmura <chmooreck@poczta.onet.pl>
Signed-off-by: NSylwester Nawrocki <snjw23@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Fix Linux kernel coding style (whitespace and indentation) errors
in file as102_fe.c. No functional changes.
Signed-off-by: NDevin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: NPiotr Chmura <chmooreck@poczta.onet.pl>
Signed-off-by: NSylwester Nawrocki <snjw23@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Changes by Devin Heitmueller:

Import the original Abilis Systems as102 driver.  The source is unmodified,
with the only changes I've made so far were that I created a Kconfig and
Makefile so that the code builds in a standard v4l-dvb tree.

This driver requires firmware (which Abilis has provided with redistribution
terms which will allow it to be bundled in the Linux distributions).   The
firmware can be downloaded from here:

Thanks to Rainer Miethling from PCTV Systems for working to get the driver
released (for use with the PCTV 74e) and Pierrick Hascoet from Abilis for
authoring the driver.

Changes by Piotr Chmura:
 - moved the driver from media/dvb to staging/media
 - removed Makefile/Kconfig - compilation fails in current tree

[snjw23@gmail.com: edited changelog]
Signed-off-by: NPierrick Hascoet <pierrick.hascoet@abilis.com>
Signed-off-by: NDevin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: NPiotr Chmura <chmooreck@poczta.onet.pl>
Signed-off-by: NSylwester Nawrocki <snjw23@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>