Use devm_* variants of kstrdup and kzalloc. Get rid of kfree cleanups.
Signed-off-by: NBastian Germann <bastiangermann@fishpost.de>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Make the asus_atk0110 driver use hwmon_device_register_with_groups instead
of the deprecated hwmon_device_register.
Construct the expected attribute_group array from the sensor list which
contains all needed attributes.
Remove the manual sysfs file creation and deletion that are now taken care
of by the (un)register calls via the attribute_group array.
Signed-off-by: NBastian Germann <bastiangermann@fishpost.de>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The function get_raw_temp is local to the source and does not need to
be in global scope, so make it static.

Cleans up sparse warning:
drivers/hwmon/k10temp.c:149:14: warning: symbol 'get_raw_temp' was not
declared. Should it be static?
Signed-off-by: NColin Ian King <colin.king@canonical.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Updated version of the ltc2990 driver which supports all measurement
modes (current, voltage, temperature) available in the chip.

If devicetree is used, the mode must be specified with the property
"lltc,meas-mode". The format and possible values of the property are
described in the binding.

If devicetree is not used, the mode of the chip will not be configured.
Unless the chip is configured by another source, only the internal
temperature and supply voltage will be measured.
Signed-off-by: NTom Levens <tom.levens@cern.ch>
Tested-By: mike.looijmans@topic.nl
[groeck: Fixed compiler warning]
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Fix incorrect conversion of negative temperatures by using
sign_extend32() instead of a home-grown conversion function.

Fixes: df922703 ("hwmon: Add LTC2990 sensor driver")
Signed-off-by: NTom Levens <tom.levens@cern.ch>
[groeck: Updated subject and description]
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

hwmon_device_register_with_info() registration API requires a
non-NULL parent device when chip is non-NULL.

This commit adds a check and documents this requirement.
Signed-off-by: NLucas Magasweran <lucas.magasweran@ieee.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Signed-off-by: NWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

On some AMD CPUs, there is a different between the die temperature
(Tdie) and the reported temperature (Tctl). Tdie is the real measured
temperature, and Tctl is used for fan control. Lets report both for
affected CPUs.
Tested-by: NGabriel Craciunescu <nix.or.die@gmail.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Add support for Stoney Ridge and Bristol Ridge (Family 15h Model 0x70)
CPUs. Registers match those of Family 15h Model 0x60.

Cc: stable@vger.kernel.org # v4.16+
Tested-by: NGabriel Craciunescu <nix.or.die@gmail.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The SMN (System Management Network) on Family 17h AMD CPUs is also accessed
from other drivers, specifically EDAC. Accessing it directly is racy.
On top of that, accessing the SMN through root bridge 00:00 is wrong on
multi-die CPUs and may result in reading the temperature from the wrong
die. Use available API functions to fix the problem.

For this to work, add dependency on AMD_NB. Also change the Raven Ridge
PCI device ID to point to Data Fabric Function 3, since this ID is used
by the API functions to find the CPU node.

Cc: stable@vger.kernel.org # v4.16+
Tested-by: NGabriel Craciunescu <nix.or.die@gmail.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The HTC (Hardware Temperature Control) register has moved
for recent chips.

Cc: stable@vger.kernel.org # v4.16+
Tested-by: NGabriel Craciunescu <nix.or.die@gmail.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Enable k10temp for AMD Ryzen APUs w/ Vega Mobile Gfx.

Based on patch from René Rebe <rene@exactcode.de>. Dropped temperature
offsets since those are not supposed to apply for the affected CPUs.

Cc: stable@vger.kernel.org # v4.16+
Cc: René Rebe <rene@exactcode.de>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Ryzen 2700X has a temperature offset of 10 degrees C. If bit 19 of the
Temperature Control register is set, there is an additional offset of
49 degrees C. Take this into account as well.

Cc: stable@vger.kernel.org # v4.16+
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

On Asrock Z370M Pro4, it was observed that EC access was disabled after
initially booting the system. As a result, the driver failed to load
with
	nct6683: EC is disabled
After a suspend/resume cycle, the driver loaded correctly.
	nct6683: Found NCT6683D or compatible chip at 0x2e:0xa20
	nct6683 nct6683.2592: NCT6683D EC firmware version 1.0 build 07/18/16

Enable EC access after identifying the chip if disabled to fix the problem.
Warn the user that the data it reports may be unusable, similar to other
drivers for chips from Nuvoton.

Fixes: 41082d66 ("hwmon: Driver for NCT6683D")
Reported-by: NJonathan Sims <jonathan.625266@earthlink.net>
Tested-by: NJonathan Sims <jonathan.625266@earthlink.net>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Currently the loop checks for non-zero count of sensors for each type
of sensors which is completely wrong. It also results in aborting the
registration of sensors if one or more types of sensors are completely
not supported by the platform SCMI firmware.

This patch fixes the issue by continue to loop and skiping sensor types
that are not present.

Fixes: b23688ae ("hwmon: add support for sensors exported via ARM SCMI")
Reported-by: NJim Quinlan <james.quinlan@broadcom.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Signed-off-by: NSudeep Holla <sudeep.holla@arm.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The uid and die temperature can be read out on the ADIN7 using
input mux. Map uid and die temperature sensor to channels 16
and 17.
Signed-off-by: NAndrey Gusakov <andrey.gusakov@cogentembedded.com>
Acked-by: NGuenter Roeck <linux@roeck-us.net>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

New centaur CPUs (Familiy == 7) also support this cpu temperature sensor.
Signed-off-by: NDavid Wang <davidwang@zhaoxin.com>
[groeck: Dropped changelog, updated subject]
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

pwmX_mode is defined in the ABI as 0=DC mode, 1=pwm mode. The chip
register bit is set to 1 for DC mode. This got mixed up, and writing
1 into pwmX_mode resulted in DC mode enabled. Fix it up by using
the ABI definition throughout the driver for consistency.

Fixes: 77eb5b37 ("hwmon: (nct6775) Add support for pwm, pwm_mode, ... ")
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Since autodetection of this chip was removed, it makes sense to add prefix
max6635 so that the device can be instantiated by its actual name.
Signed-off-by: NAlvaro Gamez Machado <alvaro.gamez@hazent.com>
Reviewed-by: NJean Delvare <jdelvare@suse.de>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The chip is quite similar to other chips in the series,
but as usual it comes with its own quirks.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Maxim MAX663x family are mostly compatible with LM92, but they lack any
identification register. Weakening the detect function would make it prone
to false positives, and current one doesn't detect all chips.  Therefore,
the detect function for max6635 devices is removed in favor of explicit
device instatiation.
Signed-off-by: NAlvaro Gamez Machado <alvaro.gamez@hazent.com>
Reviewed-by: NJean Delvare <jdelvare@suse.de>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Passing NULL pointer to PTR_ERR will result in return value of 0
indicating success which is clearly not what it is intended here.

This patch returns -EINVAL instead when the sensor information is not
available.

Fixes: b23688ae ("hwmon: add support for sensors exported via ARM SCMI")
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Acked-by: NGuenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Signed-off-by: NSudeep Holla <sudeep.holla@arm.com>

Expose the gpiN_fault fields of mfr_status as individual debugfs
attributes. This provides a way for users to be easily notified of gpi
faults. Also provide the whole mfr_status register in debugfs.
Signed-off-by: NChristopher Bostic <cbostic@linux.vnet.ibm.com>
Signed-off-by: NAndrew Jeffery <andrew@aj.id.au>
Signed-off-by: NEddie James <eajames@linux.vnet.ibm.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Add a struct gpio_chip and define some methods so that this device's
I/O can be accessed via /sys/class/gpio.
Signed-off-by: NChristopher Bostic <cbostic@linux.vnet.ibm.com>
Signed-off-by: NAndrew Jeffery <andrew@aj.id.au>
Signed-off-by: NEddie James <eajames@linux.vnet.ibm.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

NCT6796D is mostly compatible to NCT6795D. It supports an additional
pwm control and fan speed channel.

While we are at it, update documentation for NCT6795D.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Initialize boolean flags in nct6775_check_fan_inputs() while
declaring them instead of several times throughout the code.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Improve fan6/pwm6 detection on NCT6795D. Add support for fan pulses
for fans 4..6 and fan min limits for fan6.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The size of some of the arrays using the number of fans is hardcoded.
Use NUM_FAN consistently throughout the driver.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Simplify code and use devm_add_action() to handle cleanup.
Signed-off-by: NPeng Hao <peng.hao2@zte.com.cn>
[groeck: Dropped unnecessary dummy function and NULL check]
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The previously used URLs are dead.

Sensirion provides permalinks for their product datasheets at
https://www.sensirion.com/en/about-us/links/.
Signed-off-by: NDanilo Bargen <mail@dbrgn.ch>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

A negative page register value means that no page needs to be
selected. This is used by status register read operations and needs
to be accepted. The failure to do so so results in missed status
and limit registers.

Fixes: da8e48ab ("hwmon: (pmbus) Always call _pmbus_read_byte in core driver")
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

A negative page register value means that no page needs to be
selected. This is used by status register evaluations and needs
to be accepted.

Fixes: da8e48ab ("hwmon: (pmbus) Always call _pmbus_read_byte in core driver")
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Create a driver to add support for SoC sensors exported by the System
Control Processor (SCP) via the System Control and Management Interface
(SCMI). The supported sensor types is one of voltage, temperature,
current, and power.

The sensor labels and values provided by the SCP are exported via the
hwmon sysfs interface.

Cc: linux-hwmon@vger.kernel.org
Acked-by: NGuenter Roeck <linux@roeck-us.net>
Signed-off-by: NSudeep Holla <sudeep.holla@arm.com>

x86_mask is a confusing name which is hard to associate with the
processor's stepping.

Additionally, correct an indent issue in lib/cpu.c.
Signed-off-by: NJia Zhang <qianyue.zj@alibaba-inc.com>
[ Updated it to more recent kernels. ]
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: bp@alien8.de
Cc: tony.luck@intel.com
Link: http://lkml.kernel.org/r/1514771530-70829-1-git-send-email-qianyue.zj@alibaba-inc.comSigned-off-by: NIngo Molnar <mingo@kernel.org>

A user reports a really bad temperature on Ryzen 1950X.

k10temp-pci-00cb
Adapter: PCI adapter
temp1: +4294948.3°C (high = +70.0°C)

This will happen if the temperature reported by the chip is lower than
the offset temperature. This has been seen in the field if "Sense MI Skew"
and/or "Sense MI Offset" BIOS parameters were set to unexpected values.
Let's report a temperature of 0 degrees C in that case.

Fixes: 1b50b776 ("hwmon: (k10temp) Add support for temperature offsets")
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Calling fan related SMM functions implemented by Dell BIOS firmware on Dell
Vostro 3360 freeze kernel for about 500ms.

Unfortunately, it is unlikely for Dell to fix this since the machine
is pretty old, so this commit just disables fan support to make the
system usable again.

Via "force" module param fan support can be enabled.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=195751
Link: http://lkml.iu.edu/hypermail/linux/kernel/1711.2/06083.htmlReviewed-by: NPali Rohár <pali.rohar@gmail.com>
Signed-off-by: NOleksandr Natalenko <oleksandr@natalenko.name>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Calling fan related SMM functions implemented by Dell BIOS firmware on Dell
Inspiron 7720 freeze kernel for about 500ms. Until Dell fixes it we need to
disable fan support for Dell Inspiron 7720 as it makes system unusable.

Via "force" module param fan support can be enabled.

Reported-by: vova7890@mail.ru
Signed-off-by: NPali Rohár <pali.rohar@gmail.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=195751
Cc: stable@vger.kernel.org # v4.0+, will need backport
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Some Dell machines are broken and some functionality is disabled. Show
warning into dmesg about this fact and allow user via "force" module param
to override brokenness and enable broken functionality.
Signed-off-by: NPali Rohár <pali.rohar@gmail.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Like the other CPUs from the same series, the 1900X has a
temperature offset of 27 degrees C.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: NLuis de Bethencourt <luisbg@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>