1. 06 10月, 2009 12 次提交
    • D
      omap: iovmm: Add missing mutex_unlock · 26548900
      Daniel Walker 提交于
      I was using Coccinelle with the mutex_unlock semantic patch, and it
      unconvered this problem. It appears to be a valid missing unlock issue.
      This change should correct it by moving the unlock below the label.
      
      This patch is against the mainline kernel.
      
      Cc: Julia Lawall <julia@diku.dk>
      Cc: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
      Signed-off-by: NDaniel Walker <dwalker@fifo99.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      26548900
    • H
      omap: iovmm: Fix incorrect spelling · ba6a1179
      Hiroshi DOYU 提交于
      Fix incorrect spelling
      Signed-off-by: NHiroshi DOYU <Hiroshi.DOYU@nokia.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      ba6a1179
    • Y
      omap: SRAM: flush the right address after memcpy in omap_sram_push · 913b143f
      ye janboe 提交于
      the original flush operation is to flush the function address which is
      copied from.
      But we do not change the function code and it is not necessary to flush it.
      Signed-off-by: Njanboe <janboe.ye@gmail.com>
      Acked-by: NPaul Walmsley <paul@pwsan.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      913b143f
    • A
      Input: fix rx51 board keymap · acf442dc
      Amit Kucheria 提交于
      The original driver was written with the KEY() macro defined as (col,
      row) instead of (row, col) as defined by the matrix keypad
      infrastructure. So the keymap was defined accordingly. Since the
      driver that was merged upstream uses the matrix keypad infrastructure,
      modify the keymap accordingly.
      
      While we are at it, fix the comments in twl4030.h and define
      PERSISTENT_KEY as (r,c) instead of (c, r)
      
      Tested on a RX51 (N900) device.
      Signed-off-by: NAmit Kucheria <amit.kucheria@verdurent.com>
      Acked-by: NTony Lindgren <tony@atomide.com>
      Signed-off-by: NDmitry Torokhov <dtor@mail.ru>
      acf442dc
    • R
      omap: Lock DPLL5 at boot · 7a66a39b
      Rajendra Nayak 提交于
      Lock DPLL5 at 120MHz at boot. The USBHOST 120MHz f-clock and
      USBTLL f-clock are the only users of this DPLL, and 120MHz is
      is the only recommended rate for these clocks.
      
      With this patch, the 60 MHz ULPI clock is generated correctly.
      
      Tested on an OMAP3430 SDP.
      Signed-off-by: NRajendra Nayak <rnayak@ti.com>
      Signed-off-by: NAnand Gadiyar <gadiyar@ti.com>
      Signed-off-by: NPaul Walmsley <paul@pwsan.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      7a66a39b
    • T
      omap: Fix incorrect 730 vs 850 detection · a9f82d10
      Tony Lindgren 提交于
      Commit cd922049 added
      support for omap850. However, the patch accidentally
      removed the wrong ifdef:
      
       #  define cpu_is_omap730()		1
       # endif
       #endif
      +#else
      +# if defined(CONFIG_ARCH_OMAP850)
      +#  undef  cpu_is_omap850
      +#  define cpu_is_omap850()		1
      +# endif
      +#endif
      
      ...
      
       void omap2_check_revision(void);
      
       #endif    /* defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3) */
      -
      -#endif
      
      Instead of removing removing the #endif at the end of the file,
      the #endif before #else should have been removed.
      
      But we cannot have multiple #else statements as pointed out by
      Alistair Buxton <a.j.buxton@gmail.com>. So the fix is to:
      
      - remove the non-multi-omap special handling, as we need to
        detect between omap730 and omap850 anyways.
      
      - add the missing #endif back to the end of the file
      Reported-by: NSanjeev Premi <premi@ti.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      a9f82d10
    • A
      OMAP3: PM: introduce a new powerdomain walk helper · ee894b18
      Artem Bityutskiy 提交于
      The 'pwrdm_for_each()' function walks powerdomains with a spinlock
      locked, so the the callbacks cannot do anything which may sleep.
      This patch introduces a 'pwrdm_for_each_nolock()' helper which does
      the same, but without the spinlock locked. This fixes the following
      lockdep warning:
      
      [    0.000000] WARNING: at kernel/lockdep.c:2460 lockdep_trace_alloc+0xac/0xec()
      [    0.000000] Modules linked in:
      (unwind_backtrace+0x0/0xdc) from [<c0045464>] (warn_slowpath_common+0x48/0x60)
      (warn_slowpath_common+0x48/0x60) from [<c0067dd4>] (lockdep_trace_alloc+0xac/0xec)
      (lockdep_trace_alloc+0xac/0xec) from [<c009da14>] (kmem_cache_alloc+0x1c/0xd0)
      (kmem_cache_alloc+0x1c/0xd0) from [<c00b21d8>] (d_alloc+0x1c/0x1a4)
      (d_alloc+0x1c/0x1a4) from [<c00a887c>] (__lookup_hash+0xd8/0x118)
      (__lookup_hash+0xd8/0x118) from [<c00a9f20>] (lookup_one_len+0x84/0x94)
      (lookup_one_len+0x84/0x94) from [<c010d12c>] (debugfs_create_file+0x8c/0x20c)
      (debugfs_create_file+0x8c/0x20c) from [<c010d320>] (debugfs_create_dir+0x1c/0x20)
      (debugfs_create_dir+0x1c/0x20) from [<c000e8cc>] (pwrdms_setup+0x60/0x90)
      (pwrdms_setup+0x60/0x90) from [<c002e010>] (pwrdm_for_each+0x30/0x80)
      (pwrdm_for_each+0x30/0x80) from [<c000e79c>] (pm_dbg_init+0x7c/0x14c)
      (pm_dbg_init+0x7c/0x14c) from [<c00232b4>] (do_one_initcall+0x5c/0x1b8)
      (do_one_initcall+0x5c/0x1b8) from [<c00083f8>] (kernel_init+0x90/0x10c)
      (kernel_init+0x90/0x10c) from [<c00242c4>] (kernel_thread_exit+0x0/0x8)
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      ee894b18
    • K
      OMAP3: PM: Enable GPIO module-level wakeups · eb350f74
      Kevin Hilman 提交于
      Currently, only GPIOs in the wakeup domain (GPIOs in bank 0) are
      enabled as wakups.  This patch also enables GPIOs in the PER
      powerdomain (banks 2-6) to be used as possible wakeup sources.
      
      In addition, this patch ensures that all GPIO wakeups can wakeup
      the MPU using the PM_MPUGRPSEL_<pwrdm> registers.
      
      NOTE: this doesn't enable the individual GPIOs as wakeups, this simply
      enables the per-bank wakeups at the powerdomain level.
      
      This problem was discovered by Mike Chan when preventing the CORE
      powerdomain from going into retention/off.  When CORE was allowed to
      hit retention, GPIO wakeups via IO pad were working fine, but when
      CORE remained on, GPIO module-level wakeups were not working properly.
      
      To test, prevent CORE from going inactive/retention/off, thus
      preventing the IO chain from being armed:
      
        # echo 3 > /debug/pm_debug/core_pwrdm/suspend
      
      This ensures that GPIO wakeups happen via module-level wakeups and
      not via IO pad.
      
      Tested on 3430SDP using the touchscreen GPIO (gpio 2, in WKUP)
      Tested on Zoom2 using the QUART interrup GPIO  (gpio 102, in PER)
      
      Also, c.f. OMAP PM wiki for troubleshooting GPIO wakeup issues:
      http://elinux.org/OMAP_Power_ManagementReported-by: NMike Chan <mikechan@google.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      eb350f74
    • V
      OMAP3: PM: USBHOST: clear wakeup events on both hosts · 71a80775
      Vikram Pandita 提交于
      USBHOST module has 2 fclocks (for HOST1 and HOST2), only one iclock
      and only a single bit in the WKST register to indicate a wakeup event.
      
      Because of the single WKST bit, we cannot know whether a wakeup event
      was on HOST1 or HOST2, so enable both fclocks before clearing the
      wakeup event to ensure both hosts can properly clear the event.
      Signed-off-by: NVikram Pandita <vikram.pandita@ti.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      71a80775
    • P
      OMAP3: PM: PRCM interrupt: only handle selected PRCM interrupts · 8cb0ac99
      Paul Walmsley 提交于
      Clearing wakeup sources is now only done when the PRM indicates a
      wakeup source interrupt.  Since we don't handle any other types of
      PRCM interrupts right now, warn if we get any other type of PRCM
      interrupt.  Either code needs to be added to the PRCM interrupt
      handler to react to these, or these other interrupts should be masked
      off at init.
      
      Updated after Jon Hunter's PRCM IRQ rework by Kevin Hilman.
      Signed-off-by: NPaul Walmsley <paul@pwsan.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      8cb0ac99
    • P
      OMAP3: PM: PRCM interrupt: check MPUGRPSEL register · 5d805978
      Paul Walmsley 提交于
      PM_WKST register contents should be ANDed with the contents of the
      MPUGRPSEL registers.  Otherwise the MPU PRCM interrupt handler could
      wind up clearing wakeup events meant for the IVA PRCM interrupt
      handler. A future revision to this code should be to read a cached
      version of MPUGRPSEL from the powerdomain code, since PRM reads are
      relatively slow.
      
      Updated after Jon Hunter's PRCM IRQ change by Kevin Hilman
      Signed-off-by: NPaul Walmsley <paul@pwsan.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      5d805978
    • J
      OMAP3: PM: Prevent hang in prcm_interrupt_handler · 77da2d91
      Jon Hunter 提交于
      There are two scenarios where a race condition could result in a hang
      in the prcm_interrupt handler. These are:
      
      1). Waiting for PRM_IRQSTATUS_MPU register to clear.
      Bit 0 of the PRM_IRQSTATUS_MPU register indicates that a wake-up event
      is pending for the MPU. This bit can only be cleared if the all the
      wake-up events latched in the various PM_WKST_x registers have been
      cleared. If a wake-up event occurred during the processing of the prcm
      interrupt handler, after the corresponding PM_WKST_x register was
      checked but before the PRM_IRQSTATUS_MPU was cleared, then the CPU
      would be stuck forever waiting for bit 0 in PRM_IRQSTATUS_MPU to be
      cleared.
      
      2). Waiting for the PM_WKST_x register to clear.
      Some power domains have more than one wake-up source. The PM_WKST_x
      registers indicate the source of a wake-up event and need to be cleared
      after a wake-up event occurs. When the PM_WKST_x registers are read and
      before they are cleared, it is possible that another wake-up event
      could occur causing another bit to be set in one of the PM_WKST_x
      registers. If this did occur after reading a PM_WKST_x register then
      the CPU would miss this event and get stuck forever in a loop waiting
      for that PM_WKST_x register to clear.
      
      This patch address the above race conditions that would result in a
      hang.
      Signed-off-by: NJon Hunter <jon-hunter@ti.com>
      Reviewed-by: NPaul Walmsley <paul@pwsan.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      77da2d91
  2. 03 10月, 2009 5 次提交
  3. 02 10月, 2009 3 次提交
  4. 01 10月, 2009 4 次提交
  5. 29 9月, 2009 10 次提交
    • R
      ARM: Ensure do_cache_op takes mmap_sem · aa45ee8f
      Russell King 提交于
      do_cache_op() uses find_vma() to validate its arguments without holding
      any locking.  This means that the VMA could vanish beneath us.  Fix
      this by taking a read lock on mmap_sem.
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      aa45ee8f
    • R
      ARM: Fix __cpuexit section mismatch warnings · 90140c30
      Russell King 提交于
      Fix:
      
      WARNING: vmlinux.o(.text+0x247c): Section mismatch in reference from the function cpu_idle() to the function .cpuexit.text:cpu_die()
      The function cpu_idle() references a function in an exit section.
      Often the function cpu_die() has valid usage outside the exit section
      and the fix is to remove the __cpuexit annotation of cpu_die.
      
      WARNING: vmlinux.o(.cpuexit.text+0x3c): Section mismatch in reference from the function cpu_die() to the function .cpuinit.text:secondary_start_kernel()
      The function __cpuexit cpu_die() references
      a function __cpuinit secondary_start_kernel().
      This is often seen when error handling in the exit function
      uses functionality in the init path.
      The fix is often to remove the __cpuinit annotation of
      secondary_start_kernel() so it may be used outside an init section.
      
      Sam says:
      > The annotation of cpu_die() is wrong.
      > To be annotated __cpuexit the function shall:
      > - be used in exit context and only in exit context with HOTPLUG_CPU=n
      > - be used outside exit context with HOTPLUG_CPU=y
      
      So, this also means __cpu_disable(), __cpu_die() and twd_timer_stop() are
      also wrong.  However, removing __cpuexit from cpu_die() creates:
      
      WARNING: vmlinux.o(.text+0x6834): Section mismatch in reference from the function cpu_die() to the function .cpuinit.text:secondary_start_kernel()
      The function cpu_die() references
      the function __cpuinit secondary_start_kernel().
      This is often because cpu_die lacks a __cpuinit
      annotation or the annotation of secondary_start_kernel is wrong.
      
      so fix this using __ref.
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      Acked-by: NSam Ravnborg <sam@ravnborg.org>
      90140c30
    • R
      ARM: Don't allow highmem on SMP platforms without h/w TLB ops broadcast · e616c591
      Russell King 提交于
      We suffer an unfortunate combination of "features" which makes highmem
      support on platforms without hardware TLB maintainence broadcast difficult:
      
      - we need kmap_high_get() support for DMA cache coherence
      - this requires kmap_high() to take a spinlock with IRQs disabled
      - kmap_high() occasionally calls flush_all_zero_pkmaps() to clear
        out old mappings
      - flush_all_zero_pkmaps() calls flush_tlb_kernel_range(), which
        on s/w IPI'd systems eventually calls smp_call_function_many()
      - smp_call_function_many() must not be called with IRQs disabled:
      
      WARNING: at kernel/smp.c:380 smp_call_function_many+0xc4/0x240()
      Modules linked in:
      Backtrace:
      [<c00306f0>] (dump_backtrace+0x0/0x108) from [<c0286e6c>] (dump_stack+0x18/0x1c)
       r6:c007cd18 r5:c02ff228 r4:0000017c
      [<c0286e54>] (dump_stack+0x0/0x1c) from [<c0053e08>] (warn_slowpath_common+0x50/0x80)
      [<c0053db8>] (warn_slowpath_common+0x0/0x80) from [<c0053e50>] (warn_slowpath_null+0x18/0x1c)
       r7:00000003 r6:00000001 r5:c1ff4000 r4:c035fa34
      [<c0053e38>] (warn_slowpath_null+0x0/0x1c) from [<c007cd18>] (smp_call_function_many+0xc4/0x240)
      [<c007cc54>] (smp_call_function_many+0x0/0x240) from [<c007cec0>] (smp_call_function+0x2c/0x38)
      [<c007ce94>] (smp_call_function+0x0/0x38) from [<c005980c>] (on_each_cpu+0x1c/0x38)
      [<c00597f0>] (on_each_cpu+0x0/0x38) from [<c0031788>] (flush_tlb_kernel_range+0x50/0x58)
       r6:00000001 r5:00000800 r4:c05f3590
      [<c0031738>] (flush_tlb_kernel_range+0x0/0x58) from [<c009c600>] (flush_all_zero_pkmaps+0xc0/0xe8)
      [<c009c540>] (flush_all_zero_pkmaps+0x0/0xe8) from [<c009c6b4>] (kmap_high+0x8c/0x1e0)
      [<c009c628>] (kmap_high+0x0/0x1e0) from [<c00364a8>] (kmap+0x44/0x5c)
      [<c0036464>] (kmap+0x0/0x5c) from [<c0109dfc>] (cramfs_readpage+0x3c/0x194)
      [<c0109dc0>] (cramfs_readpage+0x0/0x194) from [<c0090c14>] (__do_page_cache_readahead+0x1f0/0x290)
      [<c0090a24>] (__do_page_cache_readahead+0x0/0x290) from [<c0090ce4>] (ra_submit+0x30/0x38)
      [<c0090cb4>] (ra_submit+0x0/0x38) from [<c0089384>] (filemap_fault+0x3dc/0x438)
       r4:c1819988
      [<c0088fa8>] (filemap_fault+0x0/0x438) from [<c009d21c>] (__do_fault+0x58/0x43c)
      [<c009d1c4>] (__do_fault+0x0/0x43c) from [<c009e8cc>] (handle_mm_fault+0x104/0x318)
      [<c009e7c8>] (handle_mm_fault+0x0/0x318) from [<c0033c98>] (do_page_fault+0x188/0x1e4)
      [<c0033b10>] (do_page_fault+0x0/0x1e4) from [<c0033ddc>] (do_translation_fault+0x7c/0x84)
      [<c0033d60>] (do_translation_fault+0x0/0x84) from [<c002b474>] (do_DataAbort+0x40/0xa4)
       r8:c1ff5e20 r7:c0340120 r6:00000805 r5:c1ff5e54 r4:c03400d0
      [<c002b434>] (do_DataAbort+0x0/0xa4) from [<c002bcac>] (__dabt_svc+0x4c/0x60)
      ...
      
      So we disable highmem support on these systems.
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      e616c591
    • J
      ARM: includecheck fix: mach-davinci, board-dm365-evm.c · 9a0f6b46
      Jaswinder Singh Rajput 提交于
      fix the following 'make includecheck' warning:
      
        arch/arm/mach-davinci/board-dm365-evm.c: mach/common.h is included more than once.
      Signed-off-by: NJaswinder Singh Rajput <jaswinderrajput@gmail.com>
      Acked-by: NKevin Hilman <khilman@deeprootsystems.com>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      9a0f6b46
    • J
      ARM: Remove unused CONFIG SA1100_H3XXX · d5fc79cc
      Jaswinder Singh Rajput 提交于
      Removed unused CONFIG SA1100_H3XXX from Kconfig and defconfig
      Reported-by: NRobert P. J. Day <rpjday@crashcourse.ca>
      Signed-off-by: NJaswinder Singh Rajput <jaswinderrajput@gmail.com>
      Acked-by: NDmitry Artamonow <mad_soft@inbox.ru>
      Cc: Philipp Zabel <philipp.zabel@gmail.com>
      Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      d5fc79cc
    • R
      041d785f
    • R
      ARM: Fix warning: #warning syscall migrate_pages not implemented · d80ade7b
      Russell King 提交于
      We're not implementing this syscall (we're not NUMA) so we might as
      well silence this warning.
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      d80ade7b
    • R
      ARM: Fix SA11x0 clocksource warning · fac28e6d
      Russell King 提交于
      8e19608e missed updating SA11x0, and thus:
      
      arch/arm/mach-sa1100/time.c:88: warning: initialization from incompatible pointer type
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      fac28e6d
    • R
      ARM: Fix section mismatch warning in Integrator pci_v3 · 7f8b7170
      Russell King 提交于
      WARNING: vmlinux.o(.text+0xc9d4): Section mismatch in reference from the function pci_v3_scan_bus() to the function .devinit.text:pci_scan_bus_parented()
      The function pci_v3_scan_bus() references
      the function __devinit pci_scan_bus_parented().
      This is often because pci_v3_scan_bus lacks a __devinit
      annotation or the annotation of pci_scan_bus_parented is wrong.
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      Acked-by: NSam Ravnborg <sam@ravnborg.org>
      7f8b7170
    • H
      omap: Fix wrong condition check in while loop for mailbox and iommu2 · 055c49d2
      Hiroshi DOYU 提交于
      It's worked fine so far since reset is done for the first time.
      Reported-by: NJuha Leppanen <juha_motorsportcom@luukku.com>
      Signed-off-by: NHiroshi DOYU <Hiroshi.DOYU@nokia.com>
      Signed-off-by: NJuha Leppanen <juha_motorsportcom@luukku.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      055c49d2
  6. 27 9月, 2009 1 次提交
  7. 25 9月, 2009 5 次提交