Use NULL instead of 0 for the last entry of dmt_modes struct.
Supresses "sparse: Using plain integer as NULL pointer" warning.
Signed-off-by: NDavid Ung <davidu@nvidia.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

fbmon may generate mode timings that are out of spec of the monitor.
eg DELL U2410 has a max clock 170mhz but advertises a resolutions of
1920x1200@60 in its Standard Timings using 2byte code of D1 00.
When this is looked up in the DMT table it gives it a 193mhz clock.
Although the DELL monitor supports 1920x1200@60, it can only run with
reduced timings at 154mhz or DMT id 0x44 which has no STD 2byte code.
This patch checks to see if the mode can be supported by the monitor
by comparing against monspecs.dclkmax.
Signed-off-by: NDavid Ung <davidu@nvidia.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

Add the VESA Display Monitor Timing (DMT) table.
During parsing of Standard Timings, it compare the 2 byte STD code
with DMT to see what the VESA mode should be.  If there is no entry
in the vesa_modes table or no match found, it fallsback to the
GTF timings.
Signed-off-by: NDavid Ung <davidu@nvidia.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

Add high resolution modes to vesa_modes struct.
Signed-off-by: NDavid Ung <davidu@nvidia.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

this patch sets the default height if its not found in DT.
Signed-off-by: NLad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: NMaxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

this patch drops the unused function ssd1307fb_write_data().
Signed-off-by: NLad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: NMaxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

commit 765d5b9c ("fbdev: fbcon: select
VT_HW_CONSOLE_BINDING") made FRAMEBUFFER_CONSOLE always select
VT_HW_CONSOLE_BINDING, but forgot to remove

	select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE

from the individual drivers' sections that already did this before.
Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

continue is not needed at the end of a for loop, also removed the
braces which were no longer required.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

vga_in8() was storing the return value in tmp, but that return value
was never used again. so it should be safe to remove those variables.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

the check for info is not required as we are checking it immediately
after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM
if it is NULL.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

When allocate framebuffer memory using dma_alloc_coherent(),
we'd better use dma_addr_t instead of phys_addr_t. Because the
address we got in fact is DMA or bus address for the platform.

This patch also fixes below build warning:
drivers/video/fbdev/ocfb.c:335:2:
	warning: passing argument 3 of ‘dma_alloc_attrs’
	from incompatible pointer type [enabled by default]
Signed-off-by: NQiang Chen <qiang2.chen@sonymobile.com>
Acked-by: NStefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

the check for info is not required as we are checking it immediately
after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

We can mark the DMI system id table as __initconst by using a helper
variable that'll tell us if we need to unregister the reboot notifier in
atyfb_exit() instead of matching the DMI system id again.

This frees up ~680 bytes of runtime memory, the DMI table occupies.
Signed-off-by: NMathias Krause <minipli@googlemail.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

After the commit ef691ff4 (OMAPDSS: DT: Get source endpoint by
matching reg-id) we look for the SDI output using the port number.
However, the SDI driver doesn't set the port number, which causes the
SDI display to not initialize.

Fix this by setting the SDI port number to 1. We use a hardcoded value,
as SDI was used only on OMAP3 and it's always port number 1 there.
Reported-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Reported-by: NPavel Machek <pavel@ucw.cz>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

fb_deferred_io_fsync() returns the value of schedule_delayed_work() as
an error code, but schedule_delayed_work() does not return an error. It
returns true/false depending on whether the work was already queued.

Fix this by ignoring the return value of schedule_delayed_work().
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>
Cc: stable@vger.kernel.org

The regulator_disable() doesn't accept NULL pointers.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

HDMI hardware parameters structs for OMAP4 and OMAP5 contained two
initializers for 'clkdco_max'. The first one was a remnant with wrong
value.

Remove the extra initializer entries.
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

After commit b2b49ccb (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is
selected) PM_RUNTIME is always set if PM is set, so #ifdef blocks
depending on CONFIG_PM_RUNTIME may now be changed to depend on
CONFIG_PM.

The alternative of CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME may be
replaced with CONFIG_PM too.

Make these changes in 2 files under drivers/video/.
Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: NTomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: NJingoo Han <jg1.han@samsung.com>

Use per-device clock (instead of calling cpufreq_get(0), which can
return 0 if no cpu frequency driver is selected) to program timings.
Signed-off-by: NDmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Acked-by: NTomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>

The platform_device_put() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

The framebuffer_release() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

The mmp_unregister_path() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

video: mx3fb: Deletion of an unnecessary check before the function call "backlight_device_unregister"

The backlight_device_unregister() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

The i2c_put_adapter() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

The pci_dev_put() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

The uvesafb_free() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

The vfree() function performs also input parameter validation.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

this patch fixes following build warning:

drivers/video/fbdev/arkfb.c: In function ‘ark_pci_probe’:
drivers/video/fbdev/arkfb.c:1019:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  par->state.vgabase = (void __iomem *) vga_res.start;
                       ^
Signed-off-by: NLad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

this patch fixes following build warning:
drivers/video/fbdev/s3fb.c: In function ‘s3_pci_probe’:
drivers/video/fbdev/s3fb.c:1185:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  par->state.vgabase = (void __iomem *) vga_res.start;
                       ^
Signed-off-by: NLad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

this patch fixes following build warning:
drivers/video/fbdev/vt8623fb.c: In function ‘vt8623_pci_probe’:
drivers/video/fbdev/vt8623fb.c:734:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  par->state.vgabase = (void __iomem *) vga_res.start;
                       ^
Signed-off-by: NLad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

The bit field for IEC958_AES2_CON_SOURCE is bits 3-0 in
HDMI_CORE_FC_AUDSCHNLS2, not imaginary bits 3-4 (reverse order).
Signed-off-by: NJyri Sarha <jsarha@ti.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

Remove __exit qualifier from hdmi_uninit_output() because it is used
also in omapdss_hdmihw_probe().
Signed-off-by: NJyri Sarha <jsarha@ti.com>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

Enabling idle mode during audio playback causes the glitches on OMAP5
HDMI. The TRM also suggests to use no-idle for HDMI audio playback.

This patch sets HDMI idle mode to no-idle for the duration of the
playback, and restores it back to original value afterwards.
Signed-off-by: NJyri Sarha <jsarha@ti.com>
Reviewed-by: NMark Brown <broonie@kernel.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

In new model these callbacks are obsolete since the ASoC component
drivers are integrated into the HDMI drivers and no callbacks are
needed anymore.
Signed-off-by: NJyri Sarha <jsarha@ti.com>
Reviewed-by: NMark Brown <broonie@kernel.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

Implements callbacks for OMAP HDMI audio platform driver and registers
it in probe function. Unregistering is done in remove function.
Signed-off-by: NJyri Sarha <jsarha@ti.com>
Reviewed-by: NMark Brown <broonie@kernel.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

Removes the OMAP5 HDMI audio callbacks for the old external DAI driver.
Signed-off-by: NJyri Sarha <jsarha@ti.com>
Reviewed-by: NMark Brown <broonie@kernel.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

Implements callbacks for OMAP HDMI audio platform driver and registers
it in probe function. Unregistering is done in remove function.
Signed-off-by: NJyri Sarha <jsarha@ti.com>
Reviewed-by: NMark Brown <broonie@kernel.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>

Removes the OMAP4 HDMI audio callbacks for the old external DAI driver.
Signed-off-by: NJyri Sarha <jsarha@ti.com>
Reviewed-by: NMark Brown <broonie@kernel.org>
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@ti.com>