1. 04 11月, 2013 3 次提交
  2. 01 11月, 2013 3 次提交
    • A
      perf test: Update command line callchain attribute tests · 46d525ea
      Arnaldo Carvalho de Melo 提交于
      The "struct perf_event_attr setup" entry in 'perf test' is in fact a
      series of tests that will exec the tools, passing different sets of
      command line arguments to then intercept the sys_perf_event_open
      syscall, in user space, to check that the perf_event_attr->sample_type
      and other feature request bits are setup as expected.
      
      We recently restored the callchain requesting command line argument, -g,
      to not require a parameter ("dwarf" or "fp"), instead using a default
      ("fp" for now) and making the long option variant, --call-chain, be the
      one to be used when a different callchain collection method is
      preferred.
      
      The "struct perf_event_attr setup" test failed because we forgot to
      update the tests involving callchains, not switching from, '-g dwarf' to
      '--call-chain dwarf', making 'perf test' detect it:
      
        [root@sandy ~]# perf test -v 13
        13: struct perf_event_attr setup                           :
        --- start ---
        running '/home/acme/libexec/perf-core/tests/attr/test-record-basic'
        running '/home/acme/libexec/perf-core/tests/attr/test-record-branch-any'
        <SNIP>
        running '/home/acme/libexec/perf-core/tests/attr/test-record-graph-default'
        running '/home/acme/libexec/perf-core/tests/attr/test-record-graph-dwarf'
        expected sample_type=12583, got 295
        expected exclude_callchain_user=1, got 0
        expected sample_stack_user=8192, got 0
        FAILED '/home/acme/libexec/perf-core/tests/attr/test-record-graph-dwarf' - match failure
        ---- end ----
        struct perf_event_attr setup: FAILED!
        [root@sandy ~]#
      
      Fix all of them now to use --call-chain when explicitely specifying a
      method.
      
      There is still work to do, as '-g fp', for instance, passed without
      problems.
      
      In that case 'perf test' saw no problems as the intercepted syscall got
      the bits as expected, i.e. the default is 'fp', but the fact that 'fp'
      may be an existing program and the specified workload would then be
      passed as a parameter to it is an usability problem that needs fixing.
      
      Next merge window tho.
      Acked-by: NJiri Olsa <jolsa@redhat.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-jr3oq1k5iywnp7vvqlslzydm@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      46d525ea
    • W
      perf bench: Fix two warnings · 32bf5bd1
      Wei Yang 提交于
      There are two warnings in bench/numa, when building this on 32-bit
      machine.
      
      The warning output is attached:
      
      bench/numa.c:1113:20: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
      bench/numa.c:1161:6: error: format ‘%lx’ expects argument of t'long unsigned int’, but argument 5 has type ‘u64’ [-Werror=format]
      
      This patch fixes these two warnings.
      Signed-off-by: NWei Yang <weiyang@linux.vnet.ibm.com>
      Acked-by: NIngo Molnar <mingo@kernel.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Link: http://lkml.kernel.org/r/1379839764-9245-1-git-send-email-weiyang@linux.vnet.ibm.comSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      32bf5bd1
    • M
      perf tools: Remove cast of non-variadic function to variadic · 53805eca
      Michael Hudson-Doyle 提交于
      The 4fb71074 (perf ui/hist: Consolidate hpp helpers) cset introduced
      a cast of percent_color_snprintf to a function pointer type with
      varargs.  Change percent_color_snprintf to be variadic and remove the
      cast.
      
      The symptom of this was all percentages being reported as 0.00% in perf
      report --stdio output on the armhf arch.
      Signed-off-by: NMichael Hudson-Doyle <michael.hudson@linaro.org>
      Acked-by: NNamhyung Kim <namhyung@kernel.org>
      Acked-by: NWill Deacon <will.deacon@arm.com>
      Cc: Jean Pihet <jean.pihet@linaro.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Will Deacon <will.deacon@arm.com>
      Cc: stable@vger.kernel.org
      Link: http://lkml.kernel.org/r/87zjppvw7y.fsf@canonical.comSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      53805eca
  3. 29 10月, 2013 4 次提交
  4. 28 10月, 2013 1 次提交
  5. 24 10月, 2013 4 次提交
  6. 23 10月, 2013 13 次提交
  7. 22 10月, 2013 9 次提交
  8. 21 10月, 2013 3 次提交