Put all the per-channel state together in one data struct.
Signed-off-by: NStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Fixes set but never used warnings
Signed-off-by: NStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

The netvsc select queue function was missing many of the flow caching
features that exist in default tx queue selection. Add the same
logic to remember queue based on socket and implement two level
mapping (like RSS).
Signed-off-by: NStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Allow setting receive indirection table. Also uses the system standard
for initialization.
Signed-off-by: NStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

This allows for number of channels to be managed in a manner similar
to existing hardware drivers. It also removes the restriction of
maximum 8 channels and allows as many as the host will allow.
Signed-off-by: NStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

For some cases it is useful to be able to change RSS key value.
For example, replacing RSS key with a symmetric hash.
Signed-off-by: NStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Report current components used in RSS hash.
Signed-off-by: NStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Report actual number of receive queues to ethtool.
Signed-off-by: NStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Redo how Hyper-V network driver negotiates offload features. Query the
host to determine offload settings, and use the result.

Also:
  * disable IPv4 header checksum offload (not used by Linux)
  * enable TSO only if host supports
  * enable UDP checksum offload if supported
  * don't advertise support for checksumming of non-IP protocols
  * adjust GSO maximum segment size
  * enable HIGHDMA
Signed-off-by: NStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

The ring buffer mapping now handles the wraparound case
inside get_next_pkt_raw. Therefore it is not necessary to have an
additional special receive staging buffer.

See commit 1562edaed8c164ca5199 ("Drivers: hv: ring_buffer: count on
wrap around mappings")
Signed-off-by: NStephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Andrew Lunn says:

====================
External MDIO support for mv88e6xxx

The mv88e6390 family of switches has two MDIO busses, one internal to
the switch and a second one for external usage. Older generations of switches
have a single MDIO bus, which is used both internally and externally.

Refactor the existing MDIO driver code to allow for multiple MDIO
busses, and implement the second MDIO bus on mv88e6390.

This is a rewrite of a patch previously submitted as part of "Batch
3". It has been broken up into 5 smaller patches. A compatible string
is now used in the device tree to indicate the external MDIO bus.
====================
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

With all the infrastructure in place, implement access to the external
MDIO bus on the 6390 family.
Signed-off-by: NAndrew Lunn <andrew@lunn.ch>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

The mv88e6390 has multiple MDIO busses. Generalize the parsing of the
device tree to support multiple mdio nodes. The external mdio bus has
a compatible strings to indicate it is external.

Keep a linked list of busses, placing the external mdio bus at the
tail of the list. When within the driver an mdio bus is needed,
e.g. for EEE or SERDES, use the head of the list which should be the
internal bus.
Signed-off-by: NAndrew Lunn <andrew@lunn.ch>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Have the MDIO bus driver code allocate a private structure and make
the chip a member of it. This will allow us to add further members in
the future.
Signed-off-by: NAndrew Lunn <andrew@lunn.ch>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

In preparation for supporting multiple MDIO busses, pass the mii_bus
structure to all PHY operations. It will in future then be clear on
which MDIO bus the operation should be performed.

For reads/write from phylib, the mii_bus is readily available. However
some internal code also access the PHY, e.g. for EEE and SERDES. Make
this code use the one and only currently available MDIO bus.
Signed-off-by: NAndrew Lunn <andrew@lunn.ch>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

The mv88e6165 family has the internal PHYs mapped directly onto the
SMI register space as the switch. So the registers can be read
directly. Put a wrapper around this, in preparation for changing the
signature in order to support the external MDIO bus of the 6390.
Signed-off-by: NAndrew Lunn <andrew@lunn.ch>
Reviewed-by: NVivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Table sctp_timer_tbl is missing a TIMEOUT_RECONF string so
add this in. Also compare timeout with the size of the array
sctp_timer_tbl rather than SCTP_EVENT_TIMEOUT_MAX.  Also add
a build time check that SCTP_EVENT_TIMEOUT_MAX is correct
so we don't ever get this kind of mismatch between the table
and SCTP_EVENT_TIMEOUT_MAX in the future.

Kudos to Marcelo Ricardo Leitner for spotting the missing string
and suggesting the build time sanity check.

Fixes CoverityScan CID#1397639 ("Out-of-bounds read")

Fixes: 7b9438de ("sctp: add stream reconf timer")
Signed-off-by: NColin Ian King <colin.king@canonical.com>
Acked-by: NNeil Horman <nhorman@tuxdriver.com>
Reviewed-by: NXin Long <lucien.xin@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

David VomLehn says:

====================
net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

This series introduces the AQtion NIC driver for the aQuantia
AQC107/AQC108 network devices.

v1: Initial version
v2: o Make necessary drivers/net/ethernet changes to integrate software
    o Drop intermediate atlantic directory
    o Remove Makefile things only appropriate to out of tree module
      building
v3: o Move changes to drivers/net/ethernet/{Kconfig,Makefile} to the last
      patch to ensure clean bisection.
    o Removed inline attribute aq_hw_write_req() as it was defined in
      only one .c file.
    o #included pci.h in aq_common.h to get struct pci definition.
    o Modified code to unlock based execution flow rather than using a
      flag.
    o Made a number of functions that were only used in a single file
      static.
    o Cleaned up error and return code handling in various places.
    o Remove AQ_CFG_IP_ALIGN definition.
    o Other minor code clean up.
v4: o Using do_div for 64 bit division.
    o Modified NIC statistics code.
    o Using build_skb instead netdev_alloc_skb for single fragment packets.
    o Removed extra aq_nic.o from Makefile
v5: o Removed extra newline at the end of the files.
v6: o Removed unnecessary cast from void*.
    o Reworked strings array for ethtool statistics.
    o Added stringset == ETH_SS_STATS checking.
    o AQ_OBJ_HEADER replaced to aq_obj_header_s struct.
    o AQ_OBJ_SET/TST/CLR macroses replaced to inline functions.
    o Driver sources placed in to atlantic directory.
    o Fixed compilation warnings (Make W=1)
    o Added firmware version checking.
    o Code cleaning.
v7  o Removed unnecessary cast from memory allocation function (aq_ring.c).
v8  o Switched to using kcalloc instead kzalloc.
    o Now provide bus_info for ethtool
    o Used div() to avoid __bad_udelay build error.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
====================
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Modify the drivers/net/ethernet/{Makefile,Kconfig} file to make them a
part of the network drivers build.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add definitions that support receive side scaling.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add the driver interfaces required for support by the ethtool utility.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add functions to interface with the hardware and some utility functions.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add common functions for Atlantic hardware abstraction layer.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add functions that handle the PCI bus interface.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add functions to manululate the vector of receive and transmit rings.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel.Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add Atlantic A0 and B0 specific functions.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add support for code specific to the Atlantic NIC.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add definitions of functions that interface directly with the hardware.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel.Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add code to support the transmit and receive ring buffers.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add files containing the functions and definitions used in common in
different functional areas.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Patches to create the make and configuration files.
Signed-off-by: NAlexander Loktionov <Alexander.Loktionov@aquantia.com>
Signed-off-by: NDmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>
Signed-off-by: NPavel Belous <Pavel.Belous@aquantia.com>
Signed-off-by: NDmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Signed-off-by: NDavid M. VomLehn <vomlehn@texas.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

We may be able to see invalid Broadcom tags when the hardware and drivers are
misconfigured, or just while exercising the error path. Instead of flooding
the console with messages, flat out drop the packet.
Signed-off-by: NFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

After commit 51b7b1c3 (KSZ8851-SNL: Add ethtool support for
EEPROM via eeprom_93cx6, 2011-11-21) this structure member is
unused. Delete it.
Signed-off-by: NStephen Boyd <stephen.boyd@linaro.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Daniel Borkmann says:

====================
Misc BPF improvements

This series adds various misc improvements to BPF, f.e. allowing
skb_load_bytes() helper to be used with filter/reuseport programs
to facilitate programming, test cases for program tag, etc. For
details, please see individual patches.
====================
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

William reported couple of issues in relation to direct packet
access. Typical scheme is to check for data + [off] <= data_end,
where [off] can be either immediate or coming from a tracked
register that contains an immediate, depending on the branch, we
can then access the data. However, in case of calculating [off]
for either the mentioned test itself or for access after the test
in a more "complex" way, then the verifier will stop tracking the
CONST_IMM marked register and will mark it as UNKNOWN_VALUE one.

Adding that UNKNOWN_VALUE typed register to a pkt() marked
register, the verifier then bails out in check_packet_ptr_add()
as it finds the registers imm value below 48. In the first below
example, that is due to evaluate_reg_imm_alu() not handling right
shifts and thus marking the register as UNKNOWN_VALUE via helper
__mark_reg_unknown_value() that resets imm to 0.

In the second case the same happens at the time when r4 is set
to r4 &= r5, where it transitions to UNKNOWN_VALUE from
evaluate_reg_imm_alu(). Later on r4 we shift right by 3 inside
evaluate_reg_alu(), where the register's imm turns into 3. That
is, for registers with type UNKNOWN_VALUE, imm of 0 means that
we don't know what value the register has, and for imm > 0 it
means that the value has [imm] upper zero bits. F.e. when shifting
an UNKNOWN_VALUE register by 3 to the right, no matter what value
it had, we know that the 3 upper most bits must be zero now.
This is to make sure that ALU operations with unknown registers
don't overflow. Meaning, once we know that we have more than 48
upper zero bits, or, in other words cannot go beyond 0xffff offset
with ALU ops, such an addition will track the target register
as a new pkt() register with a new id, but 0 offset and 0 range,
so for that a new data/data_end test will be required. Is the source
register a CONST_IMM one that is to be added to the pkt() register,
or the source instruction is an add instruction with immediate
value, then it will get added if it stays within max 0xffff bounds.
>From there, pkt() type, can be accessed should reg->off + imm be
within the access range of pkt().

  [...]
  from 28 to 30: R0=imm1,min_value=1,max_value=1
    R1=pkt(id=0,off=0,r=22) R2=pkt_end
    R3=imm144,min_value=144,max_value=144
    R4=imm0,min_value=0,max_value=0
    R5=inv48,min_value=2054,max_value=2054 R10=fp
  30: (bf) r5 = r3
  31: (07) r5 += 23
  32: (77) r5 >>= 3
  33: (bf) r6 = r1
  34: (0f) r6 += r5
  cannot add integer value with 0 upper zero bits to ptr_to_packet

  [...]
  from 52 to 80: R0=imm1,min_value=1,max_value=1
    R1=pkt(id=0,off=0,r=34) R2=pkt_end R3=inv
    R4=imm272 R5=inv56,min_value=17,max_value=17
    R6=pkt(id=0,off=26,r=34) R10=fp
  80: (07) r4 += 71
  81: (18) r5 = 0xfffffff8
  83: (5f) r4 &= r5
  84: (77) r4 >>= 3
  85: (0f) r1 += r4
  cannot add integer value with 3 upper zero bits to ptr_to_packet

Thus to get above use-cases working, evaluate_reg_imm_alu() has
been extended for further ALU ops. This is fine, because we only
operate strictly within realm of CONST_IMM types, so here we don't
care about overflows as they will happen in the simulated but also
real execution and interaction with pkt() in check_packet_ptr_add()
will check actual imm value once added to pkt(), but it's irrelevant
before.

With regards to 06c1c049 ("bpf: allow helpers access to variable
memory") that works on UNKNOWN_VALUE registers, the verifier becomes
now a bit smarter as it can better resolve ALU ops, so we need to
adapt two test cases there, as min/max bound tracking only becomes
necessary when registers were spilled to stack. So while mask was
set before to track upper bound for UNKNOWN_VALUE case, it's now
resolved directly as CONST_IMM, and such contructs are only necessary
when f.e. registers are spilled.

For commit 6b173873 ("bpf: recognize 64bit immediate loads as
consts") that initially enabled dw load tracking only for nfp jit/
analyzer, I did couple of tests on large, complex programs and we
don't increase complexity badly (my tests were in ~3% range on avg).
I've added a couple of tests similar to affected code above, and
it works fine with verifier now.
Reported-by: NWilliam Tu <u9012063@gmail.com>
Signed-off-by: NDaniel Borkmann <daniel@iogearbox.net>
Cc: Gianluca Borello <g.borello@gmail.com>
Cc: William Tu <u9012063@gmail.com>
Acked-by: NAlexei Starovoitov <ast@kernel.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Add the test case used to compare the results from fdinfo with
af_alg's output on the tag. Tests are from min to max sized
programs, with and without maps included.

  # ./test_tag
  test_tag: OK (40945 tests)

Tested on x86_64 and s390x.
Signed-off-by: NDaniel Borkmann <daniel@iogearbox.net>
Acked-by: NAlexei Starovoitov <ast@kernel.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

When programs need to calculate the csum from scratch for small UDP
packets and use bpf_l4_csum_replace() to feed the result from helpers
like bpf_csum_diff(), then we need a flag besides BPF_F_MARK_MANGLED_0
that would ignore the case of current csum being 0, and which would
still allow for the helper to set the csum and transform when needed
to CSUM_MANGLED_0.
Signed-off-by: NDaniel Borkmann <daniel@iogearbox.net>
Acked-by: NAlexei Starovoitov <ast@kernel.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

BPF_PROG_TYPE_SOCKET_FILTER are used in various facilities such as
for SO_REUSEPORT and packet fanout demuxing, packet filtering, kcm,
etc, and yet the only facility they can use is BPF_LD with {BPF_ABS,
BPF_IND} for single byte/half/word access.

Direct packet access is only restricted to tc programs right now,
but we can still facilitate usage by allowing skb_load_bytes() helper
added back then in 05c74e5e ("bpf: add bpf_skb_load_bytes helper")
that calls skb_header_pointer() similarly to bpf_load_pointer(), but
for stack buffers with larger access size.

Name the previous sk_filter_func_proto() as bpf_base_func_proto()
since this is used everywhere else as well, similarly for the ctx
converter, that is, bpf_convert_ctx_access().
Signed-off-by: NDaniel Borkmann <daniel@iogearbox.net>
Acked-by: NAlexei Starovoitov <ast@kernel.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

The __is_valid_access() test for cb[] from 62c7989b ("bpf: allow
b/h/w/dw access for bpf's cb in ctx") was done unnecessarily complex,
we can just simplify it the same way as recent fix from 2d071c64
("bpf, trace: make ctx access checks more robust") did. Overflow can
never happen as size is 1/2/4/8 depending on access.
Signed-off-by: NDaniel Borkmann <daniel@iogearbox.net>
Acked-by: NAlexei Starovoitov <ast@kernel.org>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

One line was apparently pasted incorrectly during a new feature patch:

drivers/net/phy/marvell.c:2090:15: error: initialized field overwritten [-Werror=override-init]
   .features = PHY_GBIT_FEATURES,

I'm removing the extraneous line here to avoid the W=1 warning and restore
the previous flags value, and I'm slightly reordering the lines for consistency
to make it less likely to happen again in the future. The ordering in the
array is still not the same as in the structure definition, instead I picked
the order that is most common in this file and that seems to make more sense
here.

Fixes: 0b04680f ("phy: marvell: Add support for temperature sensor")
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Reviewed-by: NAndrew Lunn <andrew@lunn.ch>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>