1. 09 10月, 2010 1 次提交
    • D
      isdn: strcpy() => strlcpy() · b530fb69
      Dan Carpenter 提交于
      setup.phone and setup.eazmsn are 32 character buffers.
      rcvmsg.msg_data.byte_array is a 48 character buffer.
      sc_adapter[card]->channel[rcvmsg.phy_link_no - 1].dn is 50 chars.
      
      The rcvmsg struct comes from the memcpy_fromio() in receivemessage().
      I guess that means it's data off the wire.  I'm not very familiar with
      this code but I don't see any reason to assume these strings are NULL
      terminated.
      
      Also it's weird that "dn" in a 50 character buffer but we only seem to
      use 32 characters.  In drivers/isdn/sc/scioc.h, "dn" is only a 49
      character buffer.  So potentially there is still an issue there.
      
      The important thing for now is to prevent the memory corruption.
      Signed-off-by: NDan Carpenter <error27@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b530fb69
  2. 07 10月, 2010 7 次提交
  3. 06 10月, 2010 12 次提交
  4. 05 10月, 2010 20 次提交