1. 20 7月, 2018 1 次提交
  2. 19 7月, 2018 32 次提交
  3. 18 7月, 2018 7 次提交
    • D
      dsa: rtl8366: Remove unused variable. · db53770a
      David S. Miller 提交于
      drivers/net/dsa/rtl8366.c: In function ‘rtl8366_reset_vlan’:
      drivers/net/dsa/rtl8366.c:234:25: warning: unused variable ‘vlan4k’ [-Wunused-variable]
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      db53770a
    • N
      ravb: fix byte order for TX descriptor tag field lower bits · e49b42fa
      Niklas Söderlund 提交于
      The wrong helper is used to swap the bytes when adding the lower bits of
      the TX descriptors tag field in the shared ds_tagl variable. The
      variable contains the DS[11:0] field and then the TAG[3:0] bits.
      
      The mistake was highlighted by the sparse warning:
      
      ravb_main.c:1622:31:    left side has type restricted __le16
      ravb_main.c:1622:31:    right side has type unsigned short
      ravb_main.c:1622:31: warning: invalid assignment: |=
      ravb_main.c:1622:34: warning: cast to restricted __le16
      Signed-off-by: NNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
      Reviewed-by: NGeert Uytterhoeven <geert+renesas@glider.be>
      Acked-by: NSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      e49b42fa
    • N
      ravb: fix warning about memcpy length · 49f3303a
      Niklas Söderlund 提交于
      This fixes sparse warning:
      
      ravb_main.c:1257 ravb_get_strings() error: memcpy() '*ravb_gstrings_stats' too small (32 vs 960)
      Signed-off-by: NNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
      Reviewed-by: NGeert Uytterhoeven <geert+renesas@glider.be>
      Acked-by: NSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      49f3303a
    • N
      ravb: fix shadowing of symbol 'stats' in ravb_get_ethtool_stats() · c94f2fc4
      Niklas Söderlund 提交于
      Inside a loop in ravb_get_ethtool_stats() a variable 'stats' is declared
      resulting in the argument also named 'stats' to be shadowed. Fix this
      warning by renaming the unused argument 'stats' to 'estats'.
      
      This fixes the sparse warning:
      
      ravb_main.c:1225:36: originally declared here
      ravb_main.c:1233:41: warning: symbol 'stats' shadows an earlier one
      Signed-off-by: NNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
      Reviewed-by: NGeert Uytterhoeven <geert+renesas@glider.be>
      Acked-by: NSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c94f2fc4
    • L
      net: dsa: realtek-smi: Add Realtek SMI driver · d8652956
      Linus Walleij 提交于
      This adds a driver core for the Realtek SMI chips and a
      subdriver for the RTL8366RB. I just added this chip simply
      because it is all I can test.
      
      The code is a massaged variant of the code that has been
      sitting out-of-tree in OpenWRT for years in the absence of
      a proper switch subsystem. This creates a DSA driver for it.
      I have tried to credit the original authors wherever
      possible.
      
      The main changes I've done from the OpenWRT code:
      
      - Added an IRQ chip inside the RTL8366RB switch to demux and
        handle the line state IRQs.
      
      - Distributed the phy handling out to the PHY driver.
      
      - Added some RTL8366RB code that was missing in the driver at
        the time, such as setting up "green ethernet" with a funny
        jam table and forcing MAC5 (the CPU port) into 1 GBit.
      
      - Select jam table and add the default jam table from the
        vendor driver, also for ASIC "version 0" if need be.
      
      - Do not store jam tables in the device tree, store them
        in the driver.
      
      - Pick in the "initvals" jam tables from OpenWRT's driver
        and make those get selected per compatible for the
        whole system. It's apparently about electrical settings
        for this system and whatnot, not really configuration
        from device tree.
      
      - Implemented LED control: beware of bugs because there are
        no LEDs on the device I am using!
      
      We do not implement custom DSA tags. This is explained in
      a comment in the driver as well: this "tagging protocol" is
      not simply a few extra bytes tagged on to the ethernet
      frame as DSA is used to. Instead, enabling the CPU tags
      will make the switch start talking Realtek RRCP internally.
      For example a simple ping will make this kind of packets
      appear inside the switch:
      
      0000   ff ff ff ff ff ff bc ae c5 6b a8 3d 88 99 a2 00
      0010   08 06 00 01 08 00 06 04 00 01 bc ae c5 6b a8 3d
      0020   a9 fe 01 01 00 00 00 00 00 00 a9 fe 01 02 00 00
      0030   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
      
      As you can see a custom "8899" tagged packet using the
      protocol 0xa2. Norm RRCP appears to always have this
      protocol set to 0x01 according to OpenRRCP. You can also
      see that this is not a ping packet at all, instead the
      switch is starting to talk network management issues
      with the CPU port.
      
      So for now custom "tagging" is disabled.
      
      This was tested on the D-Link DIR-685 with initramfs and
      OpenWRT userspaces and works fine on all the LAN ports
      (lan0 .. lan3). The WAN port is yet not working.
      
      Cc: Antti Seppälä <a.seppala@gmail.com>
      Cc: Roman Yeryomin <roman@advem.lv>
      Cc: Colin Leitner <colin.leitner@googlemail.com>
      Cc: Gabor Juhos <juhosg@openwrt.org>
      Cc: Florian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d8652956
    • L
      net: phy: realtek: Support RTL8366RB variant · d8545825
      Linus Walleij 提交于
      The RTL8366RB is an ASIC with five internal PHYs for
      LAN0..LAN3 and WAN. The PHYs are spawn off the main
      device so they can be handled in a distributed manner
      by the Realtek PHY driver. All that is really needed
      is the power save feature enablement and letting the
      PHY driver core pick up the IRQ from the switch chip.
      
      Cc: Antti Seppälä <a.seppala@gmail.com>
      Cc: Roman Yeryomin <roman@advem.lv>
      Cc: Colin Leitner <colin.leitner@googlemail.com>
      Cc: Gabor Juhos <juhosg@openwrt.org>
      Cc: Florian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d8545825
    • H
      r8169: power down chip in probe · 07df5bd8
      Heiner Kallweit 提交于
      The removed code would be called in two situations:
      1. interface is brought up never or >10s after driver load
      2. after close()
      
      Case 1 we can handle cleaner by ensuring chip is powered down when
      leaving probe(). open() callback will power up the chip.
      
      In case 2 we call rtl_pll_power_down() twice currently, from the
      close() callback and 10s later when entering runtime-suspend.
      This is avoided by this patch.
      Signed-off-by: NHeiner Kallweit <hkallweit1@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      07df5bd8