Delete macros, structure members and declarations etc. that are not
referenced anywhere in code.
Signed-off-by: NMateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Delete unused enums, structures and macros.
Signed-off-by: NMateusz Kulikowski <mateusz.kulikowski@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Added le16_to_cpu() conversion fixing the following warning in assignment detected by sparse:

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30: warning: invalid assignment: +=
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30:    left side has type unsigned long
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:2157:30:    right side has type restricted __le16
Signed-off-by: NGaston Gonzalez <gascoar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Modified return statement and removed local declaration no longer
needed. No Compiler warnings.
Signed-off-by: NPrasanna Karthik <mkarthi3@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes lines starting with spaces.
Signed-off-by: NMaxime Lorrillere <maxime.lorrillere@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch uses memdup_user rather than duplicating its implementation
Signed-off-by: NAbdul Hussain <habdul@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch uses memdup_user rather than duplicating its implementation
Signed-off-by: NAbdul Hussain <habdul@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch renames the very generic variable name 'todo' to
nsamples.
Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com>
Reviewed-by: NIan Abbott <abbotti@mev.co.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch silences the Checkpatch.pl warning 'Prefer using the
BIT macro'
Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com>
Reviewed-by: NIan Abbott <abbotti@mev.co.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Sparse checking warning:
"drivers/staging/nvec/nvec_ps2.c:172:14: warning: duplicate const".
Remove the duplicated const to fix the warning.
Signed-off-by: NPeng Fan <van.freenix@gmail.com>
Acked-by: NMarc Dietrich <marvin24@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes a couple of ununsed MACRO's in this header file
Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove  vt6655_init_module and vt6655_cleanup_module and replace
module_pci_driver
Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The only thing this does is vt6655_suspend which is already been called
upon suspend.

Remove function device_notify_reboot and structure device_notifier.
Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch remove true and false from boolean tests.
Signed-off-by: NAbdul Hussain <habdul@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Modified return statement and removed local declaration no longer
needed. No Compiler warnings.
Signed-off-by: NPrasanna Karthik <mkarthi3@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch makes fields in struct rt_8723a_firmware_hdr use
endianness-aware types (__leXX), thus fixing the following sparse warnings:

CHECK   drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:263:37: warning: cast to
restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:39: warning: cast to
restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:277:13: warning: cast to
restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:277:13: warning: cast to
restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:277:13: warning: cast to
restricted __le16
Signed-off-by: NDaniele Alessandrelli <daniele.alessandrelli@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The size of field Rsvd1 in struct rt_8723a_firmware_hdr should be u8
otherwise we exceeds the boundaries of "LONG WORD 0". This patch fixes
the issue.
Signed-off-by: NDaniele Alessandrelli <daniele.alessandrelli@gmail.com>
Acked-by: NJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

In rtw_mlme_ext.c, nested #ifdef blocks form the following
structure inside the file:

 #ifdef CONFIG_8723AU_AP_MODE           (line 1323)
 [...]
 #ifdef CONFIG_8723AU_AP_MODE           (line 1720)
 [...]
 #endif
 (2 more ifdef blocks with CONFIG_8723AU_AP_MODE follow)
 [...]
 #endif /* CONFIG_8723AU_AP_MODE */     (line 1763)

The inner #ifdefs are unnecessary as they depend on the
same condition as the outer #ifdef and can thus be removed.
Signed-off-by: NAndreas Ruprecht <andreas.ruprecht@fau.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use a helper function to manage delink states
Signed-off-by: NFabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use a helper function to manage lun modes when SUPPORT_OCP is defined
Signed-off-by: NFabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use a helper function to manage idle state
Signed-off-by: NFabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use a helper function to manage aspm mode
Signed-off-by: NFabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use a helper function to manage ss_counter
Signed-off-by: NFabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use a helper function to check if power off is needed.
Signed-off-by: NFabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use a helper function to manage SD erase status when SUPPORT_SD_LOCK is
defined
Signed-off-by: NFabio Falzoi <fabio.falzoi84@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This adds a blank line after struct declaration, WILC_WFI_mon_priv.
Signed-off-by: NSunghoon Cho <ywhsbliss@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes blank line which is not necesssary after an open
brace.
Signed-off-by: NSunghoon Cho <ywhsbliss@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes the warnings reported by checkpatch.pl regarding on
the multiple blank line uses.
Signed-off-by: NSunghoon Cho <ywhsbliss@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes casting the values returned by memory allocation functions.
Signed-off-by: NAbdul Hussain <habdul@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch error about initialize globals to 0.
Signed-off-by: NPeter Karlsson <peter.p.karlsson@svt.se>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch warning about unnecessary parenthes.
Signed-off-by: NPeter Karlsson <peter.p.karlsson@svt.se>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch.pl warnings about lines longer than 80 characters.
Signed-off-by: NMichał Kępień <kernel@kempniu.pl>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes SIOCDEVPRIVATE + 1 ioctl.  It currently is just a
stub which does some useless printks and returns.  In the original code,
if the user passes priv_cmd.total_len == 0 then it will Oops.  Also it
leaks memory every time it's called.  In the future, we will implement
this functionality using generic API functions
Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes unwanted true and false from boolean tests.
Signed-off-by: NAbdul Hussain <habdul@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch assign proper boolean value to boolean variable.
Signed-off-by: NAbdul Hussain <habdul@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Align some defines in linux_wlan_common.h
Signed-off-by: NChaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

rework line '#include "wilc_oswrapper.h"'
it does not used anywhere after change own data type to common data type.
Signed-off-by: NDean Lee <dean.lee@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This fixes the memory corruption case, if nbytes is less than offset
and sizeof(struct channel_header)
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This driver creates a network device when s-Par sends a device
create message to create network adapter on the visorbus. When
the message is received by visorbus, the visornic_probe function
is called and the netdev device is created and managed by the
visornic driver.
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

During testing with visornic the offset of num_rcv_bufs
was being reported at 188 instead of 186. The vnic structure
starts at 180 and the macaddr is only 6 bytes long.

When I defined and packed the structures outside of the struct
and then referenced them in the struct the correct offset
was generated.
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>