In commit 4cab259f, the emc1403 driver was converted to use regmap but the
necessary Kconfig option was not added.
Signed-off-by: NJosef Gajdusek <atx@atx.name>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Murata Manufacturing Co., Ltd is the vendor for
NTC (Negative Temperature coefficient) based Thermistors.
But, the driver extensively uses "NTC" as the vendor name.

This patch corrects the vendor name also updates the
compatibility strings according to the vendor-prefix.txt

Note: Drivers continue to support the previous compatible strings
but further addition of these compatible strings in device tree
is deprecated.
Signed-off-by: NNaveen Krishna Chatradhi <ch.naveen@samsung.com>
Reviewed-by: NJavier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Current code is buggy, it shows the current fan speed as minimum fan speed.
Fix up show_fan_reg macro to correctly report fan and fan_min speed.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Acked-by: NKevin Lo <kevlo@kevlo.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Use devm_hwmon_device_register_with_groups instead of
the old-style manual attributes and hwmon device registration.

Also, unroll the attribute group macros for better code
readability.
Signed-off-by: NPawel Moll <pawel.moll@arm.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Move atxp1_id and atxp1_driver to proper place to avoid forward declaration.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Add support for Sensirion SHTC1 and compatible temperature and humidity
sensors.
Signed-off-by: NTomas Pop <tomas.pop@sensirion.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Use ATTRIBUTE_GROUPS macro and devm_hwmon_device_register_with_groups to
simplify the code a bit.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Tested-by: NPer Dalén <per.dalen@appeartv.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Generic detection leads to too many false positives, so drop it. FWIW
sensors-detect does not have such generic detection. If the user wants
to force the driver to bind to a not yet supported chip, he/she can
still do so using sysfs attribute new_device.
Signed-off-by: NJean Delvare <jdelvare@suse.de>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

All devices supported by ina2xx are bidirectional and report the
measured shunt voltage and power values as a signed 16 bit, but the
current driver implementation caches all registers as u16, leading
to an incorrect sign extension when reporting to userspace in
ina2xx_get_value().

This patch fixes the problem by casting the signed registers to s16.
Tested on an INA219.
Signed-off-by: NFabio Baltieri <fabio.baltieri@gmail.com>
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The mapping from OF device IDs to platform device IDs is wrong.
TYPE_NCPXXWB473 is 0, TYPE_NCPXXWL333 is 1, so
ntc_thermistor_id[TYPE_NCPXXWB473] is { "ncp15wb473", TYPE_NCPXXWB473 }
while
ntc_thermistor_id[TYPE_NCPXXWL333] is { "ncp18wb473", TYPE_NCPXXWB473 }.

So the name is wrong for all but the "ntc,ncp15wb473" entry, and the
type is wrong for the "ntc,ncp15wl333" entry.

So map the entries by index, it is neither elegant nor robust but at
least it is correct.
Signed-off-by: NJean Delvare <jdelvare@suse.de>
Fixes: 9e8269de hwmon: (ntc_thermistor) Add DT with IIO support to NTC thermistor driver
Reviewed-by: NGuenter Roeck <linux@roeck-us.net>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Doug Anderson <dianders@chromium.org>

In commit 9e8269de, support was added for ntc_thermistor devices being
declared in the device tree and implemented on top of IIO. With that
change, a dependency was added to the ntc_thermistor driver:

	depends on (!OF && !IIO) || (OF && IIO)

This construct has the drawback that the driver can no longer be
selected when OF is set and IIO isn't, nor when IIO is set and OF is
not. This is a regression for the original users of the driver.

As the new code depends on IIO and is useless without OF, include it
only if both are enabled, and set the dependencies accordingly. This
is clearer, more simple and more correct.
Signed-off-by: NJean Delvare <jdelvare@suse.de>
Fixes: 9e8269de hwmon: (ntc_thermistor) Add DT with IIO support to NTC thermistor driver
Reviewed-by: NGuenter Roeck <linux@roeck-us.net>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Doug Anderson <dianders@chromium.org>

Call platform_device_unregister() rather than platform_device_put() to
unregister successfully registered platform devices.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Call platform_device_unregister() rather than platform_device_put() to
unregister successfully registered platform devices.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

This patch moves data allocated using kzalloc to managed data allocated
using devm_kzalloc and cleans now unnecessary kfrees in probe and remove
functions. Also, the unnecessary label out_free is removed.

The following Coccinelle semantic patch was used for making the change:

@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
  .probe = probefn,
  .remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e, e1, e2;
@@
probefn(struct platform_device *pdev, ...) {
  <+...
- e = kzalloc(e1, e2)
+ e = devm_kzalloc(&pdev->dev, e1, e2)
  ...
?-kfree(e);
  ...+>
}

@rem depends on prb@
identifier platform.removefn;
expression e;
@@
removefn(...) {
  <...
- kfree(e);
  ...>
}
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Nuvoton NCT6683D is an eSIO with hardware monitoring capabilities.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Avoid need for forward declarations by rearranging code.

No functional change.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Convert fan display function macros into functions to reduce
code size and improve code readability.

Code size reduction is about 200 bytes on x86_64.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Convert voltage display function macros into functions to reduce
code size and improve code readability.

Code size reduction is about 600 bytes on x86_64.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Convert temperature display function macros into functions to reduce
code size and improve code readability.

Code size reduction is about 2k on x86_64.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Normalize all stored temperature values to 16 bit to simplify
temperature calculations.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

TEMP_FROM_REG gets 12 bits of temperature data in the upper 12 bit
of a signed 16 bit parameter, with the integer part (including sign)
in the upper 8 bit and the remainder in bit 4..7. The lower 4 bit of
the 16 bit data is always 0. We can use that information to convert
the temperature directly into display data (1/1000th of degree C).

Note that the stored temperature data is not shifted right as the
comment claimed, so remove that misleading comment.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Use devm_hwmon_device_register_with_groups API to attach attributes
to hwmon device, simplify code, and reduce code size.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Avoid forward declarations by rearranging code.
No functional change.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The FSF address changes over time, so drop it.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Use devm_hwmon_device_register_with_groups API to attach attributes
to hwmon device, simplify code, and reduce code size.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Function macros make the code larger and difficult ro read.
Drop them and reduce code size (on x86_64) by ~1800 bytes.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Forward declarations are unnecessary and easy to avoid, so rearrange
code and drop them.

No functional change.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The FSF address may chance over time, so drop it.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The overtemperature status bit, which is used to display critical alarm status,
matches the output of the OVERT signal 1:1. If that signal is active-low, the
bit will read 1 if there is no alarm. It is therefore necessary to reverse
the bit in this case.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Also fix links to datasheets for other supported sensors from
ST Microelectronics, and add links to several Atmel datasheets.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Convert function macros into functions to make the code
easier to read and reduce code size.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

EMC1412, EMC1413, and EMC1414 are fully compatible to EMC1402, EMC1403,
and EMC1404, and even report the same chip ID. Add to device ID table
to enable instantiation with correct chip names.
Reviewed-by: NJean Delvare <jdelvare@suse.de>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The hysteresis value applies to all limits, so add support for
tempX_min_hyst.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The hysteresis value applies to all limits, so add support for
tempX_max_hyst.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Writing the hysteresis limit returned -ERANGE if the written hysteresis
was too high or too low. Relax error check and adjust the hysteresis
value to its valid range.
Reviewed-by: NJean Delvare <jdelvare@suse.de>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

All chips in this chip series only support a single hysteresis value. Having
multiple writable hysteresis attributes is therefore confusing, since a single
write affects all hysteresis temperatures. Make all but one (temp1_crit_hyst)
read-only.
Reviewed-by: NJean Delvare <jdelvare@suse.de>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Alarm and fault status register on EMC1402, EMC1412, and EMC1422 is reported
in a different register than with other chips. Add support for it.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Convert to regmap to be able to use its register caching mechanism.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>