1. 06 4月, 2017 5 次提交
  2. 16 3月, 2017 3 次提交
  3. 15 3月, 2017 2 次提交
  4. 14 3月, 2017 2 次提交
    • J
      drm/tilcdc: Set framebuffer DMA address to HW only if CRTC is enabled · 11abbc9f
      Jyri Sarha 提交于
      Touching HW while clocks are off is a serious error and for instance
      breaks suspend functionality. After this patch tilcdc_crtc_update_fb()
      always updates the primary plane's framebuffer pointer, increases fb's
      reference count and stores vblank event. tilcdc_crtc_update_fb() only
      writes the fb's DMA address to HW if the crtc is enabled, as
      tilcdc_crtc_enable() takes care of writing the address on enable.
      
      This patch also refactors the tilcdc_crtc_update_fb() a bit. Number of
      subsequent small changes had made it almost unreadable. There should
      be no other functional changes but checking the CRTC's enable
      state. However, the locking goes a bit differently and some of the
      redundant checks have been removed in this new version.
      
      The enable_lock should be enough to protect the access to
      tilcdc_crtc->enabled. The irq_lock protects the access to last_vblank
      and next_fb. The check for vrefresh and last_vblank being valid is
      redundant, as the vrefresh should be always valid if the CRTC is
      enabled and now last_vblank should be too, because it is initialized
      to current time when CRTC raster is enabled. If for some reason the
      values are not correctly initialized the division by zero warning is
      quite appropriate.
      Signed-off-by: NJyri Sarha <jsarha@ti.com>
      Reviewed-by: NTomi Valkeinen <tomi.valkeinen@ti.com>
      11abbc9f
    • J
      drm/tilcdc: Fix hardcoded fail-return value in tilcdc_crtc_create() · abf8315f
      Jyri Sarha 提交于
      Fix badly hardcoded return return value under fail-label. All goto
      branches to the label set the "ret"-variable accordingly.
      Signed-off-by: NJyri Sarha <jsarha@ti.com>
      Reviewed-by: NGabriel Krisman Bertazi <krisman@collabora.co.uk>
      abf8315f
  5. 13 3月, 2017 4 次提交
  6. 11 3月, 2017 2 次提交
  7. 10 3月, 2017 10 次提交
  8. 09 3月, 2017 12 次提交