1. 09 1月, 2010 3 次提交
    • R
      omap: &&/|| confusion in iommu_put() · acf9d467
      Roel Kluin 提交于
      obj can't be both NULL and be an error pointer.
      Signed-off-by: NRoel Kluin <roel.kluin@gmail.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      acf9d467
    • C
      omap: gpio: Simultaneously requested rising and falling edge · 4318f36b
      Cory Maccarrone 提交于
      Some chips, namely any OMAP1 chips using METHOD_MPUIO,
      OMAP15xx and OMAP7xx, cannot be setup to respond to on-chip GPIO
      interrupts in both rising and falling edge directions -- they can
      only respond to one direction or the other, depending on how the
      ICR is configured.
      
      Additionally, current code forces rising edge detection if both
      flags are specified:
      
              if (trigger & IRQ_TYPE_EDGE_RISING)
                      l |= 1 << gpio;
              else if (trigger & IRQ_TYPE_EDGE_FALLING)
                      l &= ~(1 << gpio);
              else
                      goto bad;
      
      This change implements a toggle function that will modify the ICR
      to flip the direction of interrupt for IRQs that are requested with
      both rising and falling flags.  The toggle function is not called
      for chips and GPIOs it does not apply to through the use of a flip_mask
      that's added on a per-bank basis.  The mask is only set for those
      GPIOs where a toggle is necessary.  Edge detection starts out the
      same as above with FALLING mode first.
      
      The toggle happens on EACH interrupt; without it, we have the
      following sequence of actions on GPIO transition:
      
        ICR    GPIO               Result
        0x1    0 -> 1 (rising)    Interrupt
        0x1    1 -> 0 (falling)   No interrupt
      
        (set ICR to 0x0 manually)
        0x0    0 -> 1 (rising)    No interrupt
        0x0    1 -> 0 (falling)   Interrupt
      
      That is, with the ICR set to 1 for a gpio, only rising edge interrupts
      are caught, and with it set to 0, only falling edge interrupts are
      caught.  If we add in the toggle, we get this:
      
        ICR    GPIO               Result
        0x1    0 -> 1 (rising)    Interrupt (ICR set to 0x0)
        0x0    1 -> 0 (falling)   Interrupt (ICR set to 0x1)
        0x1    0 -> 1 ...
      
      so, both rising and falling are caught, per the request for both
      (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING).
      Signed-off-by: NCory Maccarrone <darkstar6262@gmail.com>
      Acked-by: NKevin Hilman <khilman@deeprootsystems.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      4318f36b
    • J
      omap: McBSP: Fix possible port lockout · 1866b545
      Janusz Krzysztofik 提交于
      In its current form, the omap_mcbsp_request() function can return after
      irq_request() failure without any cleanups, effectively locking out the port
      forever with clocks left running. Fix it.
      Signed-off-by: NJanusz Krzysztofik <jkrzyszt@tis.icnet.pl>
      Acked-by: NJarkko Nikula <jhnikula@gmail.com>
      Acked-by: NPeter Ujfalusi <peter.ujfalusi@nokia.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      1866b545
  2. 06 1月, 2010 5 次提交
  3. 05 1月, 2010 16 次提交
  4. 04 1月, 2010 12 次提交
  5. 03 1月, 2010 4 次提交