- 01 12月, 2016 2 次提交
-
-
由 Guy Shapiro 提交于
The code uses of_property_read_u32 and expects positive values. However, the values are stored in signed int variables. Additionally, the registers values are also stored in signed variables without a good reason (readl/writel expect u32). The only time this caused a real bug was in the new average-samples property, in which the property is numerically compared and implicitly expected to be positive. I believe it's better to change all the properties and registers to u32, for consistency and warnings reduction. Signed-off-by: NGuy Shapiro <guy.shapiro@mobi-wize.com> Reported-by: NBjørn Forsman <bjorn.forsman@gmail.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
由 Haibo Chen 提交于
Add mask of each function bits of REG_ADC_CFG, and clear these function bits first, otherwise use '|=' operation may get the wrong setting which depends on the original value of REG_ADC_CFG. Signed-off-by: NHaibo Chen <haibo.chen@nxp.com> Reviewed-by: NGuy Shapiro <guy.shapiro@mobi-wize.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
- 28 11月, 2016 1 次提交
-
-
由 Guy Shapiro 提交于
The i.MX6UL internal touchscreen controller contains an option to average upon samples. This feature reduces noise from the produced touch locations. This patch adds sample averaging support to the imx6ul_tsc device driver. Signed-off-by: NGuy Shapiro <guy.shapiro@mobi-wize.com> Reviewed-by: NFabio Estevam <fabio.estevam@nxp.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
- 20 9月, 2015 4 次提交
-
-
由 Fabio Estevam 提交于
We should better write "Touchscreen". Signed-off-by: NFabio Estevam <fabio.estevam@freescale.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
由 Fabio Estevam 提交于
According to Documentation/CodingStyle: "The preferred form for passing a size of a struct is the following: p = kmalloc(sizeof(*p), ...);" so do as suggested. Signed-off-by: NFabio Estevam <fabio.estevam@freescale.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
由 Fabio Estevam 提交于
We should check for negative values returned by platform_get_irq(). Signed-off-by: NFabio Estevam <fabio.estevam@freescale.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
由 Fabio Estevam 提交于
imx6ul_adc_init() may fail in two cases, so we should better propagate the errors and make sure that the callers of this function also check and propagate the errors accordingly. Signed-off-by: NFabio Estevam <fabio.estevam@freescale.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-
- 06 9月, 2015 1 次提交
-
-
由 Haibo Chen 提交于
Freescale i.MX6UL contains a internal touchscreen controller, this patch add a driver to support this controller. Signed-off-by: NHaibo Chen <haibo.chen@freescale.com> Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
-