1. 19 5月, 2014 17 次提交
    • S
      sparc64: fix sparse "Should it be static?" warnings in signal32.c · abaff455
      Sam Ravnborg 提交于
      Fix following warnings:
      signal32.c:140:6: warning: symbol 'do_sigreturn32' was not declared. Should it be static?
      signal32.c:230:17: warning: symbol 'do_rt_sigreturn32' was not declared. Should it be static?
      signal32.c:729:6: warning: symbol 'do_signal32' was not declared. Should it be static?
      signal32.c:773:16: warning: symbol 'do_sys32_sigstack' was not declared. Should it be static?
      
      Add proper prototypes and drop local prototype
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      abaff455
    • S
      sparc64: fix sparse warnings in sys_sparc32.c · ed8eb755
      Sam Ravnborg 提交于
      Fix following warnings:
      sys_sparc32.c:52:17: warning: symbol 'sys32_truncate64' was not declared. Should it be static?
      sys_sparc32.c:60:17: warning: symbol 'sys32_ftruncate64' was not declared. Should it be static?
      sys_sparc32.c:98:17: warning: symbol 'compat_sys_stat64' was not declared. Should it be static?
      sys_sparc32.c:109:17: warning: symbol 'compat_sys_lstat64' was not declared. Should it be static?
      sys_sparc32.c:120:17: warning: symbol 'compat_sys_fstat64' was not declared. Should it be static?
      sys_sparc32.c:131:17: warning: symbol 'compat_sys_fstatat64' was not declared. Should it be static?
      sys_sparc32.c:196:27: warning: symbol 'sys32_pread64' was not declared. Should it be static?
      sys_sparc32.c:205:27: warning: symbol 'sys32_pwrite64' was not declared. Should it be static?
      sys_sparc32.c:214:17: warning: symbol 'compat_sys_readahead' was not declared. Should it be static?
      sys_sparc32.c:222:6: warning: symbol 'compat_sys_fadvise64' was not declared. Should it be static?
      sys_sparc32.c:230:6: warning: symbol 'compat_sys_fadvise64_64' was not declared. Should it be static?
      sys_sparc32.c:241:6: warning: symbol 'sys32_sync_file_range' was not declared. Should it be static?
      sys_sparc32.c:249:17: warning: symbol 'compat_sys_fallocate' was not declared. Should it be static?
      
      Add proper prototypes in systbls.h
      Include linux/compat.h to get access to necessary types
      Use inverse christmas tree order in includes
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      ed8eb755
    • S
      sparc64: fix sparse warning in pci.c · 4ac7b826
      Sam Ravnborg 提交于
      Fix following warning:
      pci.c:886:5: warning: symbol 'pci64_dma_supported' was not declared. Should it be static?
      
      Add proper prototype in kernel.h and delete local prototype in iommu.c
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      4ac7b826
    • S
      sparc64: fix sparse warnings in smp_64.c · a0c54a21
      Sam Ravnborg 提交于
      Fix following warnings:
      smp_64.c:88:6: warning: symbol 'smp_callin' was not declared. Should it be static?
      smp_64.c:133:6: warning: symbol 'cpu_panic' was not declared. Should it be static?
      smp_64.c:187:6: warning: symbol 'smp_synchronize_tick_client' was not declared. Should it be static?
      smp_64.c:821:18: warning: symbol 'smp_call_function_client' was not declared. Should it be static?
      smp_64.c:827:18: warning: symbol 'smp_call_function_single_client' was not declared. Should it be static?
      smp_64.c:964:18: warning: symbol 'smp_new_mmu_context_version_client' was not declared. Should it be static?
      smp_64.c:1149:6: warning: symbol 'smp_capture' was not declared. Should it be static?
      smp_64.c:1171:6: warning: symbol 'smp_release' was not declared. Should it be static?
      smp_64.c:1190:18: warning: symbol 'smp_penguin_jailcell' was not declared. Should it be static?
      smp_64.c:1410:18: warning: symbol 'smp_receive_signal_client' was not declared. Should it be static?
      
      Add prototypes in kernel.h or asm/smp_64.h as appropriate.
      Delete duplicate function kimage_addr_to_ra(), and
      adapt parameter to const void * to match the broader use.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a0c54a21
    • S
      sparc64: fix sparse warning in prom_64.c · cfbddd0d
      Sam Ravnborg 提交于
      Fix following warning:
      prom_64.c:376:6: warning: symbol 'arch_find_n_match_cpu_physical_id' was not declared. Should it be static?
      
      Add missing include to pick up prototype.
      Rearrange includes to use the inverse christmas tree structure.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      cfbddd0d
    • S
      sparc64: fix sparse warning in btext.c · f1eabec5
      Sam Ravnborg 提交于
      Fix following warning:
      btext.c:140:6: warning: symbol 'btext_drawchar' was not declared. Should it be static?
      
      Define the function static as it is only used in this file.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      f1eabec5
    • S
      sparc64: fix sparse warnings in sys_sparc_64.c + unaligned_64.c · 8df52620
      Sam Ravnborg 提交于
      Fix following warnings:
      kernel/sys_sparc_64.c:643:17: warning: symbol 'sys_kern_features' was not declared. Should it be static?
      kernel/unaligned_64.c:297:17: warning: symbol 'kernel_unaligned_trap' was not declared. Should it be static?
      kernel/unaligned_64.c:387:5: warning: symbol 'handle_popc' was not declared. Should it be static?
      kernel/unaligned_64.c:428:5: warning: symbol 'handle_ldf_stq' was not declared. Should it be static?
      kernel/unaligned_64.c:553:6: warning: symbol 'handle_ld_nf' was not declared. Should it be static?
      kernel/unaligned_64.c:579:6: warning: symbol 'handle_lddfmna' was not declared. Should it be static?
      kernel/unaligned_64.c:643:6: warning: symbol 'handle_stdfmna' was not declared. Should it be static?
      
      Functions that are only used in kernel/ - add prototypes in kernel.h
      Functions used outside kernel/ - add prototype in asm/setup.h
      Removed local prototypes
      
      One of the local prototypes had wrong signature (return void - not int).
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      8df52620
    • S
      sparc64: fix sparse warning in process_64.c · d1584504
      Sam Ravnborg 提交于
      Fix following warning:
      process_64.c:91:25: warning: non-ANSI function declaration of function 'arch_cpu_idle_dead'
      
      Add proper (void) to function definition
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d1584504
    • S
      sparc64: fix sparse warning in traps_64.c · 9c2d84de
      Sam Ravnborg 提交于
      Fix following warning:
      traps_64.c:2384:6: error: symbol 'die_if_kernel' redeclared with different type (originally declared at include/asm/bug.h:23) - different modifiers
      
      Add proper __noreturn to the implementation to fix this
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      9c2d84de
    • S
      sparc: drop use of extern for prototypes in arch/sparc/* · 2e74a74f
      Sam Ravnborg 提交于
      Drop the remaining uses of extern for prototypes in .h files
      in the sparc specific part of the kernel tree.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2e74a74f
    • S
      sparc32: drop tadpole specific code · 77e39a79
      Sam Ravnborg 提交于
      tadpole.c assigned cpu_pwr_save based on the current configuration.
      The rest of the tadpole.c file was only used if cpu_pwr_save was
      dereferenced.
      But this variable was never dereferenced - and I went back to a 2.6.12
      kernel to check (from June 2005) - and not even then was it used.
      
      Drop this code as it has not been in use for ~10 years.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      77e39a79
    • S
      sparc: fix sparse warning in math_{32,64} · 8e9f0935
      Sam Ravnborg 提交于
      Fix following sparse warning:
      math_{32,64}.c: warning: symbol 'do_mathemu' was not declared. Should it be static?
      
      Add prototype in processor_{32,64} and drop extern in traps_{32,64}.c
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      8e9f0935
    • S
      sparc32: fix sparse warnings in sys_sparc_32.c · 958b7b07
      Sam Ravnborg 提交于
      Fix following warnings:
      sys_sparc_32.c:32:26: warning: symbol 'sys_getpagesize' was not declared. Should it be static?
      sys_sparc_32.c:71:16: warning: symbol 'sparc_pipe' was not declared. Should it be static?
      sys_sparc_32.c:96:26: warning: symbol 'sys_mmap2' was not declared. Should it be static?
      sys_sparc_32.c:106:26: warning: symbol 'sys_mmap' was not declared. Should it be static?
      sys_sparc_32.c:114:6: warning: symbol 'sparc_remap_file_pages' was not declared. Should it be static?
      sys_sparc_32.c:127:1: warning: symbol 'c_sys_nis_syscall' was not declared. Should it be static?
      sys_sparc_32.c:144:1: warning: symbol 'sparc_breakpoint' was not declared. Should it be static?
      sys_sparc_32.c:200:16: warning: symbol 'sys_getdomainname' was not declared. Should it be static?
      
      Adapt systbls.h for use by both sparc32 + sparc64.
      In the process modify the return type of a few functions.
      
      Change return type from unsigned long to long:
      sys_mmap2()
      sys_mmap()
      
      Change return type from int to long:
      sparc_pipe()
      sys_getdomainname()
      
      The changed return type was done to align with sparc64.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      958b7b07
    • S
      sparc32: fix sparse warnings in time_32.c · fcea8b27
      Sam Ravnborg 提交于
      Fix following warnings:
      time_32.c:63:1: warning: symbol 'rtc_lock' was not declared. Should it be static?
      time_32.c:357:13: warning: symbol 'time_init' was not declared. Should it be static?
      time_32.c:148:16: warning: dereference of noderef expression
      
      Add extern definition of rtc_lock in mc146818rtc.h.
      time_init() is called from init/main.c - add prototype to kernel.h.
      Use proper u32 __iomem * for master_l10_counter.
      Fix all users.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      fcea8b27
    • S
      sparc32: fix sparse warning in auxio_32.c · d2aca8f9
      Sam Ravnborg 提交于
      Fix following warning:
      auxio_32.c:133:33: warning: cast removes address space of expression
      
      To fix this auxio_power_register had to be defined as u8 _iomem.
      Use proper sbus operations on the pointer.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d2aca8f9
    • S
      sparc32: fix sparse warnings in pcic.c · 7738925d
      Sam Ravnborg 提交于
      Fix following warnings:
      pcic.c:164:14: warning: symbol 'pcic_regs' was not declared. Should it be static?
      pcic.c:165:14: warning: symbol 'pcic_speculative' was not declared. Should it be static?
      pcic.c:166:14: warning: symbol 'pcic_trapped' was not declared. Should it be static?
      pcic.c:332:66: warning: Using plain integer as NULL pointer
      pcic.c:344:66: warning: Using plain integer as NULL pointer
      pcic.c:539:38: warning: Using plain integer as NULL pointer
      pcic.c:677:1: warning: symbol 'pcic_pin_to_irq' was not declared. Should it be static?
      pcic.c:783:6: warning: symbol 'pcic_nmi' was not declared. Should it be static?
      
      Add extern for pcic_regs.
      Define a few variables static.
      Replace 0 with NULL.
      Delete unused funtion pcic_pin_to_irq().
      Include kernel.h so we could drop declaration of
      t_nmi and add prototype for pcic_nmi.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      7738925d
    • S
      sparc32: fix build breakage · 178f0ffa
      Sam Ravnborg 提交于
      Add forward declaration to kernel.h to fix build breakage
      in some configurations
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      178f0ffa
  2. 02 5月, 2014 2 次提交
  3. 29 4月, 2014 21 次提交
    • S
      sparc32: fix sparse warnings in leon_smp.c · 1bbc9060
      Sam Ravnborg 提交于
      Fix following warnings:
      leon_smp.c:133:6: warning: symbol 'leon_smp_setbroadcast' was not declared. Should it be static?
      leon_smp.c:151:14: warning: symbol 'leon_smp_getbroadcast' was not declared. Should it be static?
      leon_smp.c:269:6: warning: symbol 'leon_irq_rotate' was not declared. Should it be static?
      leon_smp.c:355:6: warning: symbol 'leonsmp_ipi_interrupt' was not declared. Should it be static?
      leon_smp.c:457:6: warning: symbol 'leon_cross_call_irq' was not declared. Should it be static?
      
      Add static.
      Remove unused functions.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Cc: Daniel Hellstrom <daniel@gaisler.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      1bbc9060
    • S
      sparc32: fix sparse warnings in sun4d_smp.c · 65199b0a
      Sam Ravnborg 提交于
      Fix following warnings:
      sun4d_smp.c:113:13: warning: symbol 'smp4d_boot_cpus' was not declared. Should it be static?
      sun4d_smp.c:121:5: warning: symbol 'smp4d_boot_one_cpu' was not declared. Should it be static?
      sun4d_smp.c:162:13: warning: symbol 'smp4d_smp_done' was not declared. Should it be static?
      sun4d_smp.c:353:6: warning: symbol 'smp4d_cross_call_irq' was not declared. Should it be static?
      sun4d_smp.c:363:6: warning: symbol 'smp4d_percpu_timer_interrupt' was not declared. Should it be static?
      
      Add proper declarations
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      65199b0a
    • S
      sparc32: fix sparse warnings in sun4m_smp.c · b8417de3
      Sam Ravnborg 提交于
      Fix following warnings:
      sun4m_smp.c:72:13: warning: symbol 'smp4m_boot_cpus' was not declared. Should it be static?
      sun4m_smp.c:78:5: warning: symbol 'smp4m_boot_one_cpu' was not declared. Should it be static?
      sun4m_smp.c:120:13: warning: symbol 'smp4m_smp_done' was not declared. Should it be static?
      sun4m_smp.c:230:6: warning: symbol 'smp4m_cross_call_irq' was not declared. Should it be static?
      sun4m_smp.c:240:6: warning: symbol 'smp4m_percpu_timer_interrupt' was not declared. Should it be static?
      
      Add proper declarations.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b8417de3
    • S
      sparc32: fix sparse warnings in leon_pmc.c · 8b45c796
      Sam Ravnborg 提交于
      Fix following warnings:
      leon_pmc.c:15:14: warning: symbol 'pmc_leon_fixup_ids' was not declared. Should it be static?
      leon_pmc.c:22:5: warning: symbol 'pmc_leon_need_fixup' was not declared. Should it be static?
      leon_pmc.c:41:6: warning: symbol 'pmc_leon_idle_fixup' was not declared. Should it be static?
      leon_pmc.c:65:6: warning: symbol 'pmc_leon_idle' was not declared. Should it be static?
      
      Add static to definitions.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Cc: Daniel Hellstrom <daniel@gaisler.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      8b45c796
    • S
      sparc32: fix sparse warnings in leon_kernel.c · 4007b65a
      Sam Ravnborg 提交于
      Fix following warnings:
      leon_kernel.c:40:15: warning: symbol 'leon3_gptimer_idx' was not declared. Should it be static?
      leon_kernel.c:68:6: warning: symbol 'leon_eirq_setup' was not declared. Should it be static?
      leon_kernel.c:273:13: warning: symbol 'leon_percpu_timer_ce_interrupt' was not declared. Should it be static?
      
      Define symbols as static.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Cc: Daniel Hellstrom <daniel@gaisler.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      4007b65a
    • S
      sparc: fix sparse warnings in of_device_common.c · 985edb5b
      Sam Ravnborg 提交于
      Fix following warnings (both sparc32 and sparc64):
      of_device_common.c:13:14: warning: symbol 'irq_of_parse_and_map' was not declared. Should it be static?
      of_device_common.c:24:5: warning: symbol 'of_address_to_resource' was not declared. Should it be static?
      of_device_common.c:37:14: warning: symbol 'of_iomap' was not declared. Should it be static?
      
      Add missing includes.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      985edb5b
    • S
      sparc32: fix sparse warnings in unaligned_32.c · 9edfae3f
      Sam Ravnborg 提交于
      Fix following warnings:
      unaligned_32.c:146:15: warning: symbol 'safe_compute_effective_address' was not declared. Should it be static?
      unaligned_32.c:235:17: warning: symbol 'kernel_unaligned_trap' was not declared. Should it be static?
      unaligned_32.c:319:17: warning: symbol 'user_unaligned_trap' was not declared. Should it be static?
      
      Add proper declarations in kernel.h + setup.h
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      9edfae3f
    • S
      sparc32: fix sparse warning in ptrace_32.c · c8c8782d
      Sam Ravnborg 提交于
      Fix following warning:
      ptrace_32.c:444:16: warning: symbol 'syscall_trace' was not declared. Should it be static?
      
      Add declaration in kernel.h
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c8c8782d
    • S
      sparc32: fix sparse warnings in smp_32.c · c0b0ba84
      Sam Ravnborg 提交于
      Fix following warnings:
      smp_32.c:300:6: warning: symbol 'arch_cpu_pre_starting' was not declared. Should it be static?
      smp_32.c:320:6: warning: symbol 'arch_cpu_pre_online' was not declared. Should it be static?
      smp_32.c:347:6: warning: symbol 'sparc_start_secondary' was not declared. Should it be static?
      
      Add missing static definition.
      
      This left one warning:
         warning: symbol 'setup_profiling_timer' was not declared.
      
      This is a global symbol that has no declaration in any global header.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c0b0ba84
    • S
      sparc32: fix sparse warnings in auxio_32.c · a3ee8faa
      Sam Ravnborg 提交于
      Fix following warnings:
      auxio_32.c:23:14: warning: symbol 'auxio_register' was not declared. Should it be static?
      auxio_32.c:26:13: warning: symbol 'auxio_probe' was not declared. Should it be static?
      auxio_32.c:108:13: warning: symbol 'auxio_power_probe' was not declared. Should it be static?
      
      Add proper decalarations for the above.
      
      The leaves one sparse warning:
      auxio_32.c:130:33: warning: cast removes address space of expression
      
      This is here:
          auxio_power_register = (unsigned char *) of_ioremap()
      
      This is __iomem that is removed from return value of of_ioremap()
      The pointer is later used without any helpers in process_32.c:
          *auxio_power_register |= AUXIO_POWER_OFF;
      
      It would be simple to introduce a few sbus() helpers.
      But as I was not sure this was correct the warning are left as-is.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a3ee8faa
    • S
      sparc32: fix sparse warnings in leon_pci_grpci2.c · 3731e199
      Sam Ravnborg 提交于
      Fix following warnings:
      leon_pci_grpci2.c:218:1: warning: symbol 'grpci2_dev_lock' was not declared. Should it be static?
      leon_pci_grpci2.c:219:20: warning: symbol 'grpci2priv' was not declared. Should it be static?
      leon_pci_grpci2.c:221:5: warning: symbol 'grpci2_map_irq' was not declared. Should it be static?
      leon_pci_grpci2.c:564:6: warning: symbol 'grpci2_hw_init' was not declared. Should it be
      static?
      
      + a lot of these:
      leon_pci_grpci2.c:252:9: warning: incorrect type in argument 1 (different address spaces)
      
      Declare the symbols static as they are only used in this file.
      Added missing __iomem annotations.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Cc: Daniel Hellstrom <daniel@gaisler.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      3731e199
    • S
      sparc32: fix sparse warnings in leon_pci_grpci1.c · d65f0cd3
      Sam Ravnborg 提交于
      Fix following warnings:
      leon_pci_grpci1.c:104:5: warning: symbol 'grpci1_map_irq' was not declared. Should it be static?
      leon_pci_grpci1.c:420:6: warning: symbol 'grpci1_hw_init' was not declared. Should it be static?
      + a lot of these:
      leon_pci_grpci1.c:693:18: warning: incorrect type in argument 1 (different address spaces)
      
      Added missing static to definitions.
      Added __iomem annotations
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Cc: Daniel Hellstrom <daniel@gaisler.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d65f0cd3
    • S
      sparc32: fix sparse warnings in tadpole.c · 6b5f02f3
      Sam Ravnborg 提交于
      Fix following warnings:
      tadpole.c:21:6: warning: symbol 'cpu_pwr_save' was not declared. Should it be static?
      tadpole.c:101:13: warning: symbol 'clock_stop_probe' was not declared. Should it be static?
      
      This actually revealed that cpu_pwr_save is only assigned.
      It was left static with a TODO comment for now - this should be cleaned up later.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      6b5f02f3
    • S
      sparc32: fix sparse warning in devices.c · 8885ec7c
      Sam Ravnborg 提交于
      Fix following warning:
      devices.c:114:13: warning: symbol 'device_scan' was not declared. Should it be static?
      
      Add prototype to asm/setup.h
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      8885ec7c
    • S
      sparc: fix sparse warnings in cpu.c · fd250a66
      Sam Ravnborg 提交于
      Fix following sparc32 warning:
      cpu.c:430:29: warning: symbol 'cpuinfo_op' was not declared. Should it be static?
      
      Fix following sparc64 warnings:
      cpu.c:364:14: warning: symbol 'dcache_parity_tl1_occurred' was not declared. Should it be static?
      cpu.c:365:14: warning: symbol 'icache_parity_tl1_occurred' was not declared. Should it be static?
      
      Rearrange asm/cpu.h to share more stuff between sparc32 and sparc64.
      Added missing include to cpu.c of kernel.h
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      fd250a66
    • S
      sparc32: fix sparse warnings in windows.c · 7c8ee361
      Sam Ravnborg 提交于
      Fix following warnings:
      windows.c:16:6: warning: symbol 'flush_user_windows' was not declared. Should it be static?
      windows.c:109:6: warning: symbol 'try_to_clear_window_buffer' was not declared. Should it be static?
      
      Add missing include of cacheflush.h + add declaration of try_to_clear_window_buffer in kernel.h
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      7c8ee361
    • S
      sparc32: fix sparse warnings in setup_32.c · d191723f
      Sam Ravnborg 提交于
      Fix following warnings:
      setup_32.c:106:15: warning: symbol 'cmdline_memory_size' was not declared. Should it be static?
      setup_32.c:270:16: warning: symbol 'fake_swapper_regs' was not declared. Should it be static?
      setup_32.c:368:55: warning: Using plain integer as NULL pointer
      
      Add missing declaration of cmdline_memory_size and remove the local one in init_32.c
      fake_swapper_regs was only used locally - so defined static.
      When replacing 0 with NULL also add a few spaces around operators
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d191723f
    • S
      sparc32: fix sparse warnings in ioport.c · c31f7651
      Sam Ravnborg 提交于
      Fix following warnings:
      ioport.c:189:38: warning: Using plain integer as NULL pointer
      ioport.c:78:25: warning: symbol 'sparc_iomap' was not declared. Should it be static?
      ioport.c:403:20: warning: symbol 'sbus_dma_ops' was not declared. Should it be static?
      ioport.c:684:39: warning: Using plain integer as NULL pointer
      
      Add one missing prototype, and use NULL.
      sbus_dma_ops declared static.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c31f7651
    • S
      sparc32: fix sparse warnings in signal_32.c · 529b17a9
      Sam Ravnborg 提交于
      Fix following warnings:
      signal_32.c:62:17: warning: symbol 'do_sigreturn' was not declared. Should it be static?
      signal_32.c:126:17: warning: symbol 'do_rt_sigreturn' was not declared. Should it be static?
      signal_32.c:344:39: warning: incorrect type in initializer (different address spaces)
      signal_32.c:344:39:    expected struct __siginfo_fpu_t [usertype] *fp
      signal_32.c:344:39:    got void [noderef] <asn:1>*[assigned] tail
      signal_32.c:346:45: warning: incorrect type in argument 2 (different address spaces)
      signal_32.c:346:45:    expected struct __siginfo_fpu_t [noderef] [usertype] <asn:1>*fpu
      signal_32.c:346:45:    got struct __siginfo_fpu_t [usertype] *fp
      signal_32.c:352:41: warning: incorrect type in initializer (different address spaces)
      signal_32.c:352:41:    expected struct __siginfo_rwin_t [usertype] *rwp
      signal_32.c:352:41:    got void [noderef] <asn:1>*[assigned] tail
      signal_32.c:354:48: warning: incorrect type in argument 2 (different address spaces)
      signal_32.c:354:48:    expected struct __siginfo_rwin_t [noderef] [usertype] <asn:1>*rwin
      signal_32.c:354:48:    got struct __siginfo_rwin_t [usertype] *rwp
      signal_32.c:509:6: warning: symbol 'do_notify_resume' was not declared. Should it be static?
      signal_32.c:520:16: warning: symbol 'do_sys_sigstack' was not declared. Should it be static?
      
      Add missing prototypes and annotate two variables with __user.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      529b17a9
    • S
      sparc32: fix sparse warnings in process_32.h · 8bdd5a1b
      Sam Ravnborg 提交于
      Fix following warnings:
      process_32.c:67:6: warning: symbol 'arch_cpu_idle' was not declared. Should it be static?
      process_32.c:257:16: warning: symbol 'sparc_do_fork' was not declared. Should it be static?
      process_32.c:411:5: warning: symbol 'dump_fpu' was not declared. Should it be static?
      
      Add missing includes and add one missing prototype.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      8bdd5a1b
    • S
      sparc32: fix sparse warnings in irq_32.c · fbb86383
      Sam Ravnborg 提交于
      Fix following warnings:
      irq_32.c:239:5: warning: symbol 'sparc_floppy_request_irq' was not declared. Should it be static?
      irq_32.c:294:24: warning: symbol 'fdc_status' was not declared. Should it be static?
      irq_32.c:297:6: warning: symbol 'pdma_vaddr' was not declared. Should it be static?
      irq_32.c:300:15: warning: symbol 'pdma_size' was not declared. Should it be static?
      irq_32.c:303:14: warning: symbol 'doing_pdma' was not declared. Should it be static?
      irq_32.c:306:6: warning: symbol 'pdma_base' was not declared. Should it be static?
      irq_32.c:309:15: warning: symbol 'pdma_areasize' was not declared. Should it be static?
      irq_32.c:317:6: warning: symbol 'sparc_floppy_irq' was not declared. Should it be static?
      
      The floppy parts were all added to iasm/setup.h - no other header files looked obvious.
      floppy_32.h was not an option as this file can only be included once from the
      floppy driver.
      Signed-off-by: NSam Ravnborg <sam@ravnborg.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      fbb86383