Review and switch to unlocked_ioctl
Signed-off-by: NAlan Cox <alan@redhat.com>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Since 43cc71ee, the platform modalias is
prefixed with "platform:".  Add MODULE_ALIAS() to the hotpluggable watchdog
drivers, to re-enable auto loading.

[dbrownell@users.sourceforge.net: more drivers; registration fixes]
Signed-off-by: NKay Sievers <kay.sievers@vrfy.org>
Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

move watchdog tree from drivers/char/watchdog to drivers/watchdog.
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Consolidate the timeout config register modification into a single
function.  Also, use the enabled flag in the config register to
determine whether the timer is enabled instead of a separately
maintained flag, MV64x60_WDOG_FLAG_ENABLED.

Add spinlock protection around enabling/disabling the watchdog timer.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Make sure that we disable the watchdog at start-up.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Disallow disabling of the watchdog timer unless a particular
character ('V') was recently written to the watchdog device.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Also, use the WATCHDOG_NOWAYOUT macro, rather than #ifdefs,
and use __module_get to prevent module unloading if WATCHDOG_NOWAYOUT
is set.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Allow the watchdog timer to be enabled or disabled via the
WDIOC_SETOPTIONS ioctl.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Add the ability to modify the watchdog timer timeout interval.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

WDIOC_GETTIMEOUT returns seconds, not jiffies.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Return the value of the nonseekable_open function and not 0.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Add support for arch/powerpc, specifically for the prpmc2800 platform.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Previously, the address of the watchdog timer registers was
retrieved by calling a global function, mv64x60_get_bridge_vbase().
That function doesn't exist in arch/powerpc.  Instead, we now get
the register address from a platform data resource and ioremap
the registers within the driver.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

The driver previously registered its platform device data in its own
init function--that's bogus.  Move that code to platform-specific
code in arch/ppc.  This is being done so that the platform code can
decide at runtime whether to initialize this driver or not.
Signed-off-by: NDale Farnsworth <dale@farnsworth.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Return ENOTTY instead of ENOIOCTLCMD in user-visible ioctl() results

The watchdog drivers used to return ENOIOCTLCMD for bad ioctl() commands.
ENOIOCTLCMD should not be visible by the user, so use ENOTTY instead.
Signed-off-by: NSamuel Tardieu <sam@rfc1149.net>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>
Acked-by: NAlan Cox <alan@redhat.com>
Signed-off-by: NAndrew Morton <akpm@osdl.org>

Mark the static struct file_operations in drivers/char as const.  Making
them const prevents accidental bugs, and moves them to the .rodata section
so that they no longer do any false sharing; in addition with the proper
debug option they are then protected against corruption..

[akpm@osdl.org: build fix]
Signed-off-by: NArjan van de Ven <arjan@linux.intel.com>
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NLinus Torvalds <torvalds@osdl.org>

Signed-off-by: NJörn Engel <joern@wohnheim.fh-wedel.de>
Signed-off-by: NAdrian Bunk <bunk@stusta.de>

mv64x600_wdt: convert to the new platform device interface Do not use
platform_device_register_simple() as it is going away.
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NLinus Torvalds <torvalds@osdl.org>

This allows us to eliminate the casts in the drivers, and eventually
remove the use of the device_driver function pointer methods for
platform device drivers.
Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
Acked-by: NGreg Kroah-Hartman <gregkh@suse.de>

Initialise the .owner field of the device driver
with the module that owns it, for easier tracking
of device driver ownership. (probably also better
for sysfs...)
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Convert everyone who uses platform_bus_type to include
linux/platform_device.h.
Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
Acked-by: NGreg Kroah-Hartman <gregkh@suse.de>

 - use nonseekable_open() instead of messing with

	if (*ppos != file->f_pos)
		return -EISPIPE

   in ->write() (->read is NULL).

 - trivial __user annotations
Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: NLinus Torvalds <torvalds@osdl.org>

Add mv64x60 (Marvell Discovery) watchdog support.
Signed-off-by: NJames Chapman <jchapman@katalix.com>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>