1. 27 10月, 2010 1 次提交
    • J
      hpet: unmap unused I/O space · a56d5318
      Jiri Slaby 提交于
      When the initialization code in hpet finds a memory resource and does not
      find an IRQ, it does not unmap the memory resource previously mapped.
      
      There are buggy BIOSes which report resources exactly like this and what
      is worse the memory region bases point to normal RAM.  This normally would
      not matter since the space is not touched.  But when PAT is turned on,
      ioremap causes the page to be uncached and sets this bit in page->flags.
      
      Then when the page is about to be used by the allocator, it is reported
      as:
      
      BUG: Bad page state in process md5sum  pfn:3ed00
      page:ffffea0000dbd800 count:0 mapcount:0 mapping:(null) index:0x0
      page flags: 0x20000001000000(uncached)
      Pid: 7956, comm: md5sum Not tainted 2.6.34-12-desktop #1
      Call Trace:
       [<ffffffff810df851>] bad_page+0xb1/0x100
       [<ffffffff810dfa45>] prep_new_page+0x1a5/0x1c0
       [<ffffffff810dfe01>] get_page_from_freelist+0x3a1/0x640
       [<ffffffff810e01af>] __alloc_pages_nodemask+0x10f/0x6b0
      ...
      
      In this particular case:
      
      1) HPET returns 3ed00000 as memory region base, but it is not in
      reserved ranges reported by the BIOS (excerpt):
       BIOS-e820: 0000000000100000 - 00000000af6cf000 (usable)
       BIOS-e820: 00000000af6cf000 - 00000000afdcf000 (reserved)
      
      2) there is no IRQ resource reported by HPET method. On the other
      hand, the Intel HPET specs (1.0a) says (3.2.5.1):
      _CRS (
        // Report 1K of memory consumed by this Timer Block
        memory range consumed
        // Optional: only used if BIOS allocates Interrupts [1]
        IRQs consumed
      )
      
      [1] For case where Timer Block is configured to consume IRQ0/IRQ8 AND
      Legacy 8254/Legacy RTC hardware still exists, the device objects
      associated with 8254 & RTC devices should not report IRQ0/IRQ8 as
      "consumed resources".
      
      So in theory we should check whether if it is the case and use those
      interrupts instead.
      
      Anyway the address reported by the BIOS here is bogus, so non-presence
      of IRQ doesn't mean the "optional" part in point 2).
      
      Since I got no reply previously, fix this by simply unmapping the space
      when IRQ is not found and memory region was mapped previously.  It would
      be probably more safe to walk the resources again and unmap appropriately
      depending on type.  But as we now use only ioremap for both 2 memory
      resource types, it is not necessarily needed right now.
      
      Addresses https://bugzilla.novell.com/show_bug.cgi?id=629908Reported-by: NOlaf Hering <olaf@aepfle.de>
      Signed-off-by: NJiri Slaby <jslaby@suse.cz>
      Acked-by: NClemens Ladisch <clemens@ladisch.de>
      Cc: <stable@kernel.org>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      a56d5318
  2. 16 9月, 2010 1 次提交
    • A
      hpet: kill BKL, add compat_ioctl · 54066a57
      Arnd Bergmann 提交于
      hpet uses the big kernel lock in its ioctl and open
      functions. Replace this with a private mutex to be
      sure. Since we're already touching the ioctl function,
      add the compat_ioctl version as well -- all commands
      except HPET_INFO are compatible and that one is easy
      to add.
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Cc: Clemens Ladisch <clemens@ladisch.de>
      Cc: Bob Picco <bob.picco@hp.com>
      54066a57
  3. 17 5月, 2010 1 次提交
  4. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  5. 18 3月, 2010 1 次提交
  6. 19 11月, 2009 1 次提交
  7. 12 11月, 2009 1 次提交
    • E
      sysctl drivers: Remove dead binary sysctl support · 894d2491
      Eric W. Biederman 提交于
      Now that sys_sysctl is a wrapper around /proc/sys all of
      the binary sysctl support elsewhere in the tree is
      dead code.
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Corey Minyard <minyard@acm.org>
      Cc: Greg Kroah-Hartman <gregkh@suse.de>
      Cc: Matt Mackall <mpm@selenic.com>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: Neil Brown <neilb@suse.de>
      Cc: "James E.J. Bottomley" <James.Bottomley@suse.de>
      Acked-by: Clemens Ladisch <clemens@ladisch.de> for drivers/char/hpet.c
      Signed-off-by: NEric W. Biederman <ebiederm@xmission.com>
      894d2491
  8. 24 9月, 2009 1 次提交
    • N
      hpet: hpet driver periodic timer setup bug fixes · ae21cf92
      Nils Carlson 提交于
      The periodic interrupt from drivers/char/hpet.c does not work correctly,
      both when using the periodic capability of the hardware and while
      emulating the periodic interrupt (when hardware does not support periodic
      mode).
      
      With timers capable of periodic interrupts, the comparator field is first
      set with the period value followed by set of hidden accumulator, which has
      the side effect of overwriting the comparator value.  This results in
      wrong periodicity for the interrupts.  For, periodic interrupts to work,
      following steps are necessary, in that order.
      
      * Set config with Tn_VAL_SET_CNF bit
      
      * Write to hidden accumulator, the value written is the time when the
        first interrupt should be generated
      
      * Write compartor with period interval for subsequent interrupts
        (http://www.intel.com/hardwaredesign/hpetspec_1.pdf )
      
      When emulating periodic timer with timers not capable of periodic
      interrupt, driver is adding the period to counter value instead of
      comparator value, which causes slow drift when using this emulation.
      
      Also, driver seems to add hpetp->hp_delta both while setting up periodic
      interrupt and while emulating periodic interrupts with timers not capable
      of doing periodic interrupts.  This hp_delta will result in slower than
      expected interrupt rate and should not be used while setting the interval.
      Signed-off-by: NVenkatesh Pallipadi <venkatesh.pallipadi@intel.com>
      Signed-off-by: NNils Carlson <nils.carlson@ericsson.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      ae21cf92
  9. 28 4月, 2009 1 次提交
    • Y
      irq: change ACPI GSI APIs to also take a device argument · a2f809b0
      Yinghai Lu 提交于
      We want to use dev_to_node() later on, to be aware of the 'home node'
      of the GSI in question.
      
      [ Impact: cleanup, prepare the IRQ code to be more NUMA aware ]
      Signed-off-by: NYinghai Lu <yinghai@kernel.org>
      Acked-by: NLen Brown <lenb@kernel.org>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: Suresh Siddha <suresh.b.siddha@intel.com>
      Cc: "Eric W. Biederman" <ebiederm@xmission.com>
      Cc: Rusty Russell <rusty@rustcorp.com.au>
      Cc: Len Brown <lenb@kernel.org>
      Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
      Cc: Tony Luck <tony.luck@intel.com>
      Cc: linux-acpi@vger.kernel.org
      Cc: linux-ia64@vger.kernel.org
      LKML-Reference: <49F65560.20904@kernel.org>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      a2f809b0
  10. 22 4月, 2009 1 次提交
  11. 03 4月, 2009 1 次提交
  12. 24 11月, 2008 1 次提交
  13. 02 11月, 2008 1 次提交
    • A
      saner FASYNC handling on file close · 233e70f4
      Al Viro 提交于
      As it is, all instances of ->release() for files that have ->fasync()
      need to remember to evict file from fasync lists; forgetting that
      creates a hole and we actually have a bunch that *does* forget.
      
      So let's keep our lives simple - let __fput() check FASYNC in
      file->f_flags and call ->fasync() there if it's been set.  And lose that
      crap in ->release() instances - leaving it there is still valid, but we
      don't have to bother anymore.
      Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      233e70f4
  14. 16 10月, 2008 1 次提交
  15. 10 10月, 2008 1 次提交
  16. 01 8月, 2008 2 次提交
    • D
      hpet: /dev/hpet - fixes and cleanup, fix · f92a789d
      David Brownell 提交于
      fix:
      
      On Thursday 31 July 2008, Ingo Molnar wrote:
      >   drivers/built-in.o: In function `hpet_alloc':
      >   : undefined reference to `__udivdi3'
      >   drivers/built-in.o: In function `hpet_alloc':
      >   : undefined reference to `__umoddi3'
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      f92a789d
    • D
      hpet: /dev/hpet - fixes and cleanup · 64a76f66
      David Brownell 提交于
      Minor /dev/hpet updates and bugfixes:
      
        * Remove dead code, mostly remnants of an incomplete/unusable
          kernel interface ... noted when addressing "sparse" warnings:
            + hpet_unregister() and a routine it calls
            + hpet_task and all references, including hpet_task_lock
            + hpet_data.hd_flags (and HPET_DATA_PLATFORM)
      
        * Correct and improve boot message:
            + displays *counter* (shared between comparators) bit width,
              not *timer* bit widths (which are often mixed)
            + relabel "timers" as "comparators"; this is less confusing,
              they are not independent like normal timers are (sigh)
            + display MHz not Hz; it's never less than 10 MHz.
      
        * Tighten and correct the userspace interface code
            + don't accidentally program comparators in 64-bit mode using
              32-bit values ... always force comparators into 32-bit mode
            + provide the correct bit definition flagging comparators with
              periodic capability ... the ABI is unchanged
      
        * Update Documentation/hpet.txt
            + be more correct and current
            + expand description a bit
            + don't mention that now-gone kernel interface
      
      Plus, add a FIXME comment for something that could cause big trouble
      on systems with more capable HPETs than at least Intel seems to ship.
      
      It seems that few folk use this userspace interface; it's not very
      usable given the general lack of HPET IRQ routing.  I'm told that
      the only real point of it any more is to mmap for fast timestamps;
      IMO that's handled better through the gettimeofday() vsyscall.
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Acked-by: NClemens Ladisch <clemens@ladisch.de>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      64a76f66
  17. 26 7月, 2008 1 次提交
  18. 21 6月, 2008 1 次提交
  19. 02 6月, 2008 1 次提交
  20. 30 4月, 2008 1 次提交
  21. 05 4月, 2008 1 次提交
  22. 30 1月, 2008 3 次提交
  23. 27 9月, 2007 1 次提交
  24. 26 9月, 2007 1 次提交
  25. 01 9月, 2007 1 次提交
    • L
      Do not use the ia64 clocksource on non-ia64 architectures · 3b2b64fd
      Linus Torvalds 提交于
      The HPET clocksource in drivers/char/hpet.c was written as generic code
      for ia64, but it is not yet ready to replace the native HPET clocksource
      implementations that the i386/x86-64 architectures use.
      
      On x86[-64], trying to register this clocksource results in potentially
      multiple hpet-based clocksources being registered, and if the ia64 one
      is chosen on x86_64 some users have experienced hangs.
      
      Eventually all three architectures may end up using the same code, but
      that is not the case right now.
      
      Cc: John Stultz <johnstul@us.ibm.com>
      Cc: Tony Luck <tony.luck@intel.com>
      Cc: Paolo Ornati <ornati@fastwebnet.it>
      Cc: Bob Picco <bob.picco@hp.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      3b2b64fd
  26. 27 7月, 2007 1 次提交
  27. 24 7月, 2007 1 次提交
  28. 21 7月, 2007 1 次提交
  29. 15 2月, 2007 2 次提交
  30. 04 12月, 2006 1 次提交
  31. 05 10月, 2006 1 次提交
    • D
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells 提交于
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: NDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  32. 26 9月, 2006 1 次提交
  33. 04 7月, 2006 1 次提交
  34. 03 7月, 2006 1 次提交
  35. 01 7月, 2006 1 次提交
  36. 02 4月, 2006 1 次提交