An extra reference is taken out on an operation in
gb_operation_request_send(). If the response never arrives, we need to
put back the reference.
Signed-off-by: NPerry Hung <perry@leaflabs.com>
Tested-by: NMitchell Tasman <tasman@leaflabs.com>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

If an operation is issued and the response never comes back,
gb_operation_timeout() cancels the operation but never wakes up the
waiter in gb_operation_request_send().

This patch removes the timeout workqueue and changes the request wait to
wait_for_completion_interruptible_timeout(), with timeout set to
OPERATION_TIMEOUT_DEFAULT.
Signed-off-by: NPerry Hung <perry@leaflabs.com>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

offset is defined as unsigned so there is no point checking for
negative values of offset.
Signed-off-by: NBill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Signed-off-by: NBill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

val is an unsigned long so there is no point in checking if it is less
than zero.
Signed-off-by: NBill Pemberton <wfp5p@worldbroken.com>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

This .c file isn't needed by the kernel driver, it's there for firmware
developers only, so just move it into the Documentation directory to
reduce confusion.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Use the "gb-" prefix for the ES1 Host controller driver.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Use the "gb" prefix for module names, not a suffix.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Use the "gb" prefix for module names, not a suffix.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

This module provides the Bridged PHY protocols, so name the thing
properly.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Provide an install Makefile target for those that want to install the
kernel modules.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

--
v3: resend to list, somehow this thread got taken private and v2 never
    made it there.

v2: add -a option to depmod, thanks to Mitchell

The data_in_size variable was set to 1 for the status byte.
But now, the status byte has move to header. Then, the status byte
is "allocated" twice and cause bad message size error.
Signed-off-by: NAlexandre Bailon <abailon@baylibre.com>
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Right now some sysfs attributes have \n and some do not, so fix that and
put \n at the end of all of them to make it easier to parse things
properly in userspace.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

When removing a connection with no protocol assigned to it, the kernel
oopses as we always thought protocols were always there.

Fix that problem, oopses are bad.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

We want to be able to "blame" a protocol for things at times, so give
them a name we can refer to them by.  Announce when they are added or
removed from the system so we have a chance to know what is going on
in the kernel logs.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Use the list that the driver core keeps of our structure, no need to
duplicate it with a local list as well.  This gets rid of a static lock
too, always a nice thing to do.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

The i2c protocol belongs in the gpbridge driver, so move it
there.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

This bundles together the existing GP Bridged PHY protocols that were
part of the Greybus core: USB, UART, SDIO, PWM, and GPIO.  This is now a
stand-alone kernel module.  More logic will be moving here in the future
to handle bridged devices.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

This moves the battery class protocol to be a stand-alone kernel module.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

We can't use the gb_protocol_driver() macro here as we need to do some
init and exit logic when loading and removing, so "open code" the module
init and exit functions.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Now that protocols can be in a module, we need to reference count them
to lock them into memory so they can't be removed while in use.  So add
a module owner structure, and have it automatically be assigned when
registering the protocol.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

Use a "name" for when we don't have a valid device id yet, instead of a
magic value of 0xff.
Reported-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

This splits the i2c-gb protocol into a stand-alone kernel module.

It's not going to stay in this fashion for long, this was done to test
the "can a protcol be loaded later" logic.  Future refactoring is going
to move the gpbridge protocols to a separate kernel module, where this
protocol is going to live.

But for now, split it out, it is good to test with, and shows a bug in
gbsim at the moment.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

When adding a new protocol to the system, walk all bundles and try to
hook up any connections that do not have a protocol already.  This sets
the stage to allow for protocols to be loaded at any time, not just
before the device is seen in the system.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Protocol handlers need some greybus symbols, so export them so that they
can be built outside of the greybus core.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

We will want to return this value as a return value for module_init()
and bool does not play well with module_init().  So make it a "real"
error value and return int and fix up all callers of the function.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

The list was global and had no locking.  It's not like we were ever
parsing more than one manifest at the same time right now, but we might
in the future.  And we really want this to be local to the interface
itself, for future work redoing how to bind protocols to bundles, so
move the list to the interface structure.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Modules in the greybus system sit above the interface, so insert them
early in the sysfs tree.  We dynamically create them when we have an
interface that references a module, as we don't get a "module create"
message directly.  They also dynamically go away when the last interface
associated with a module is removed.

Naming scheme for modules/interfaces/bundles/connections is bumped up by
one ':', and now looks like the following:

/sys/bus/greybus $ tree
.
├── devices
│   ├── 7 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7
│   ├── 7:7 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7
│   ├── 7:7:0 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7/7:7:0
│   └── 7:7:0:1 -> ../../../devices/pci0000:00/0000:00:14.0/usb1/1-1/7/7:7/7:7:0/7:7:0:1
├── drivers
├── drivers_autoprobe
├── drivers_probe
└── uevent

6 directories, 3 files
/sys/bus/greybus $ grep . devices/*/uevent
devices/7/uevent:DEVTYPE=greybus_module
devices/7:7/uevent:DEVTYPE=greybus_interface
devices/7:7:0/uevent:DEVTYPE=greybus_bundle
devices/7:7:0:1/uevent:DEVTYPE=greybus_connection

We still have some "confusion" about interface ids and module ids, which
will be cleaned up later when the svc control protocol changes die down,
right now we just name a module after the interface as we don't have any
modules that have multiple interfaces in our systems.

This has been tested with gbsim.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

It's a local interface lock, not a modules lock, so rename it.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

This is really a list of interfaces, not modules, so rename it so that
we don't get confused when we really do add modules to the whole system
later on.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

rename gb_add_module     -> gb_add_interface
rename gb_remove_modules -> gb_remove_interfaces
rename gb_remove_module  -> gb_remove_interface

And move the function prototypes to interface.h, where they belong.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Align up the BIT() #defines and properly comment the include block
define.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

MAX_CPORTS_PER_MODULE and MAX_STRINGS_PER_MODULE are not used anywhere
anymore, so remove them lest someone thing we have limits.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

This moves the id structure name to not have "block" in it, as that
doesn't make sense anymore with the renaming of the gb_interface
structure.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Rename struct gb_interface_block to struct gb_interface

Lots of renaming, and variable renames as well (gb_ib->intf), but all
should be sane with regards to the new naming scheme we are using.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Interface_block is being renamed to interface, so move the file first.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Alex pointed out one rename I missed previously, this fixes up the
interface_block list of bundles name.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

Rename struct gb_interface to struct gb_bundle

It's a lot of renaming, some structures got renamed and also some
fields, but the goal was to rename things to make sense with the new
naming of how the system is put together in the 'driver model' view.
Reviewed-by: NAlex Elder <elder@linaro.org>
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>

-EPROTO happens when devices are starting to go away in a system, or
there is something wrong on the USB connection.  Either way, it's safe
to resubmit the urb for this error, don't complain to userspace about
this, as the user will see this for every device removed, which looks
scary, but means nothing.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>

We are renameing the "interface" term to "bundle" so rename the files
before we start changing structure names to make it easier for people to
see what really is happening in the changes.
Signed-off-by: NGreg Kroah-Hartman <greg@kroah.com>
Reviewed-by: NAlex Elder <elder@linaro.org>