1. 07 9月, 2011 11 次提交
  2. 11 6月, 2011 2 次提交
  3. 22 3月, 2011 11 次提交
  4. 21 12月, 2010 3 次提交
  5. 23 10月, 2010 1 次提交
    • S
      [media] s5p-fimc: dubious one-bit signed bitfields · dda7ae78
      Sylwester Nawrocki 提交于
      > From: Dan Carpenter [mailto:error27@gmail.com]
      >
      > These are signed so instead of being 1 and 0 as intended they are -1 and
      > 0.  It doesn't cause a bug in the current code but Sparse warns about
      > it:
      >
      > drivers/media/video/s5p-fimc/fimc-core.h:226:28:
      > 	error: dubious one-bit signed bitfield
      >  struct fimc_scaler {
      > -	int	scaleup_h:1;
      > -	int	scaleup_v:1;
      > -	int	copy_mode:1;
      > -	int	enabled:1;
      > +	unsigned int	scaleup_h:1;
      > +	unsigned int	caleup_v:1;
      > +	unsigned int	copy_mode:1;
      > +	unsigned int	enabled:1;
      
      In general I agree, however this patch would change scaleup_v:1
      to caleup_v, so it cannot be applied in current form.
      Here is the corrected patch:
      
      Reported-by: Dan Carpenter <error27@gmail.com<
      Signed-off-by: NSylwester Nawrocki <s.nawrocki@samsung.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      dda7ae78
  6. 21 10月, 2010 3 次提交
  7. 09 8月, 2010 2 次提交