1. 01 11月, 2011 1 次提交
  2. 23 6月, 2011 2 次提交
  3. 01 6月, 2011 1 次提交
    • J
      zd1211rw: fix to work on OHCI · 59342f6a
      Jussi Kivilinna 提交于
      zd1211 devices register 'EP 4 OUT' endpoint as Interrupt type on USB 2.0:
      
            Endpoint Descriptor:
              bLength                 7
              bDescriptorType         5
              bEndpointAddress     0x04  EP 4 OUT
              bmAttributes            3
                Transfer Type            Interrupt
                Synch Type               None
                Usage Type               Data
              wMaxPacketSize     0x0040  1x 64 bytes
              bInterval               1
      
      However on USB 1.1 endpoint becomes Bulk:
      
            Endpoint Descriptor:
              bLength                 7
              bDescriptorType         5
              bEndpointAddress     0x04  EP 4 OUT
              bmAttributes            2
                Transfer Type            Bulk
                Synch Type               None
                Usage Type               Data
              wMaxPacketSize     0x0040  1x 64 bytes
              bInterval               0
      
      Commit 37939810 assumed that endpoint is
      always interrupt type and changed usb_bulk_msg() calls to usb_interrupt_msg().
      
      Problem here is that usb_bulk_msg() on interrupt endpoint selfcorrects the
      call and changes requested pipe to interrupt type (see usb_bulk_msg).
      However with usb_interrupt_msg() on bulk endpoint does not correct the
      pipe type to bulk, but instead URB is submitted with interrupt type pipe.
      
      So pre-2.6.39 used usb_bulk_msg() and therefore worked with both endpoint
      types, however in 2.6.39 usb_interrupt_msg() with bulk endpoint causes
      ohci_hcd to fail submitted URB instantly with -ENOSPC and preventing zd1211rw
      from working with OHCI.
      
      Fix this by detecting endpoint type and using correct endpoint/pipe types
      for URB. Also fix asynchronous zd_usb_iowrite16v_async() to use right
      URB type on 'EP 4 OUT'.
      
      Cc: stable@kernel.org
      Signed-off-by: NJussi Kivilinna <jussi.kivilinna@mbnet.fi>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      59342f6a
  4. 08 4月, 2011 1 次提交
  5. 05 4月, 2011 2 次提交
  6. 22 3月, 2011 1 次提交
  7. 15 2月, 2011 3 次提交
  8. 05 2月, 2011 8 次提交
  9. 16 11月, 2010 1 次提交
  10. 03 6月, 2010 1 次提交
  11. 21 5月, 2010 1 次提交
  12. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  13. 19 1月, 2010 1 次提交
  14. 23 12月, 2009 1 次提交
  15. 12 11月, 2009 1 次提交
  16. 28 10月, 2009 1 次提交
    • B
      zd1211rw: Fix TX status reporting in order to have proper rate control · 7f4013f0
      Benoit PAPILLAULT 提交于
      First, we reduce the number of hardware retries to 0 (ie 2 real retries
      for each rate). Next, when we report the retries to mac80211, we always
      report a retry count of 1 (it seems to be 2 in fact, but using 2 seems
      to lead to wrong performance for some reason). We use a state machine to
      determine the real fate of a packet based on the 802.11 ACK and what the
      Zydas hardware is saying when a real retry occurs. The real retry rates
      are encoded in a static array. It has been tested with both zd1211 and
      zd1211b hardware. Of course, since the Zydas hardware is not reporting
      retries accurately, we are just doing our best in order to get the best
      performance (ie higher throughput).
      Signed-off-by: NBenoit PAPILLAULT <benoit.papillault@free.fr>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      7f4013f0
  17. 23 9月, 2009 1 次提交
  18. 25 7月, 2009 1 次提交
  19. 11 7月, 2009 1 次提交
  20. 09 7月, 2009 2 次提交
  21. 19 6月, 2009 1 次提交
  22. 12 2月, 2009 1 次提交
  23. 23 1月, 2009 1 次提交
  24. 30 12月, 2008 1 次提交
    • J
      drivers/net/usb: use USB API functions rather than constants · f201a8a4
      Julia Lawall 提交于
      This set of patches introduces calls to the following set of functions:
      
      usb_endpoint_dir_in(epd)
      usb_endpoint_dir_out(epd)
      usb_endpoint_is_bulk_in(epd)
      usb_endpoint_is_bulk_out(epd)
      usb_endpoint_is_int_in(epd)
      usb_endpoint_is_int_out(epd)
      usb_endpoint_num(epd)
      usb_endpoint_type(epd)
      usb_endpoint_xfer_bulk(epd)
      usb_endpoint_xfer_control(epd)
      usb_endpoint_xfer_int(epd)
      usb_endpoint_xfer_isoc(epd)
      
      In some cases, introducing one of these functions is not possible, and it
      just replaces an explicit integer value by one of the following constants:
      
      USB_ENDPOINT_XFER_BULK
      USB_ENDPOINT_XFER_CONTROL
      USB_ENDPOINT_XFER_INT
      USB_ENDPOINT_XFER_ISOC
      
      In drivers/net/wireless/zd1211rw/zd_usb.c the code:
      
      (endpoint->bEndpointAddress & USB_TYPE_MASK) == USB_DIR_OUT
      
      is suspicious.  If it is intended to use USB_ENDPOINT_DIR_MASK rather than
      USB_TYPE_MASK, then the whole conditional test could be converted to a call
      to usb_endpoint_is_bulk_in.
      
      An extract of the semantic patch that makes these changes is as follows:
      (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @r1@ struct usb_endpoint_descriptor *epd; @@
      
      - ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
      - \(USB_ENDPOINT_XFER_CONTROL\|0\))
      + usb_endpoint_xfer_control(epd)
      
      @r5@ struct usb_endpoint_descriptor *epd; @@
      
      - ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
      -  \(USB_DIR_IN\|0x80\))
      + usb_endpoint_dir_in(epd)
      
      @inc@
      @@
      
      #include <linux/usb.h>
      
      @depends on !inc && (r1||r5)@
      @@
      
      + #include <linux/usb.h>
        #include <linux/usb/...>
      // </smpl>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      f201a8a4
  25. 07 11月, 2008 1 次提交
  26. 01 11月, 2008 1 次提交
  27. 23 9月, 2008 1 次提交
  28. 08 7月, 2008 1 次提交