1. 11 11月, 2013 5 次提交
  2. 10 11月, 2013 11 次提交
  3. 31 10月, 2013 13 次提交
  4. 30 10月, 2013 11 次提交
    • K
      staging: ft1000: return values corrected in scram_start_dwnld · b1bdd4d3
      Kelley Nielsen 提交于
      The ft1000 usb driver ignores expected Linux error codes, and uses two
      values defined in ft1000_usb.h: STATUS_SUCCESS 0, and STATUS_FAILURE
      0x1001; and sometimes -1. This patch changes the return values of the
      function scram_start_dwnld to match the status of the handshake returned
      by its helper functions, get_handshake and get_handshake_usb. If the
      handshake fails, -ENETRESET is returned instead of the inappropriate
      STATUS_FAILURE. Also, a new test has been added to differentiate failure
      due to timeout from failure due to net reset (the default). -ETIMEDOUT
      is returned in this case. Finally, 0 is returned on success instead of
      STATUS_SUCCESS.
      Signed-off-by: NKelley Nielsen <kelleynnn@gmail.com>
      Suggested-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b1bdd4d3
    • K
      staging: ft1000: change values of status return variable in write_dpram32_and_check · 43fc69b1
      Kelley Nielsen 提交于
      The ft1000 usb driver ignores expected Linux error codes, and uses two
      values defined in ft1000_usb.h: STATUS_SUCCESS 0, and STATUS_FAILURE
      0x1001; and sometimes -1. This patch changes the return value of the
      function write_dpram_32_and check to 0 or -EREMOTEIO, respectively. The
      relevant change was made in the helper function check_buffers (which is
      only called from write_dpram32_and_check); it now returns 0 on success
      and -EREMOTEIO on failure, and this is allowed to propagate through
      write_dpram32_and_check. Assignments to the return variable status that
      are no longer needed were removed as well. In one function up the call
      chain, dsp_reload in ft1000_hw.c, the status variable was changed from
      u16 to int to avoid collecting a signed value in an unsigned variable.
      Signed-off-by: NKelley Nielsen <kelleynnn@gmail.com>
      Suggested-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      43fc69b1
    • L
      staging: bcm: Remove unnecessary pointer casting · 2fef7e13
      Lisa Nguyen 提交于
      Some void pointers can be assigned to other
      pointer variables in functions without casting.
      Signed-off-by: NLisa Nguyen <lisa@xenapiadmin.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      2fef7e13
    • F
      imx-drm: ipuv3-crtc: Invert IPU DI0 clock polarity · f0ac9beb
      Fabio Estevam 提交于
      sig_cfg.clk_pol controls the 'di0_polarity_disp_clk' bit of register
      IPUx_DI0_GENERAL through the following code in imx-drm/ipu-v3/ipu-di.c:
      
      	if (!sig->clk_pol)
      		di_gen |= DI_GEN_POLARITY_DISP_CLK;
      
      With 'di0_polarity_disp_clk' bit set we do not have stable HDMI output on
      mx6solo: contours of pictures look jittery and the white colour does not appear
      really white.
      
      Russell King initially reported this problem at:
      http://www.spinics.net/lists/arm-kernel/msg279805.html
      
      Inverting 'di0_polarity_disp_clk' leads to stable HDMI output image.
      
      Tested on the following boards:
      - mx6solowandboard (HDMI output)
      - mx6qwandboard (HDMI output)
      - mx6qsabrelite (LVDS)
      - mx6qsabresd (HDMI output and LVDS)
      - mx6dlsabresd (HDMI output)
      - mx53qsb (parallel WVGA display)
      Reported-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      Suggested-by: NSascha Hauer <s.hauer@pengutronix.de>
      Signed-off-by: NFabio Estevam <fabio.estevam@freescale.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      f0ac9beb
    • L
      staging: r8188eu: Fix sparse warnings in rtl_p2p.c · 0e51fc36
      Larry Finger 提交于
      Sparse displays the following:
      
        CHECK   drivers/staging/rtl8188eu/core/rtw_p2p.c
      drivers/staging/rtl8188eu/core/rtw_p2p.c:162:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_p2p.c:162:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_p2p.c:162:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_p2p.c:221:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_p2p.c:221:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_p2p.c:221:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_p2p.c:292:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_p2p.c:292:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_p2p.c:292:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_p2p.c:371:15:    got restricted __le16 *<noident>
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      0e51fc36
    • L
      staging: r8188eu: Fix sparse warnings in rtw_mlme_ext.c · ac049e30
      Larry Finger 提交于
      Sparse displays the following:
      
        CHECK   drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1874:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1874:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:1874:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2221:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2221:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2221:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2583:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2583:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2583:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2750:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2750:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2750:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3002:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3002:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3002:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3197:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3197:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3197:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3311:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3311:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3311:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3563:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3563:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:3563:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4522:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4522:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4522:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4750:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4750:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4750:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4906:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4906:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4906:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5040:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5040:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5040:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5184:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5184:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5184:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5322:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5322:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5322:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5654:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5654:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5654:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5769:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5769:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5769:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5894:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5894:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5894:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5996:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5996:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:5996:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6066:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6066:15:    expected unsigned short [usertype] *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6066:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15:    expected unsigned short *fctrl
      drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:6200:15:    got restricted __le16 *<noident>
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      ac049e30
    • L
      staging: r8188eu: Fix sparse warnings in rtl8188e.cmd.c · c4af455f
      Larry Finger 提交于
      Sparse displays the following:
      
        CHECK   drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15:    expected unsigned short [usertype] *fctrl
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:285:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:368:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:368:15:    expected unsigned short [usertype] *fctrl
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:368:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:403:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:403:15:    expected unsigned short [usertype] *fctrl
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:403:15:    got restricted __le16 *<noident>
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15: warning: incorrect type in assignment (different base types)
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15:    expected unsigned short [usertype] *fctrl
      drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c:465:15:    got restricted __le16 *<noident>
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      c4af455f
    • L
      staging: r8188eu: Fix sparse warnings in rtw_ieee80211.c · be987763
      Larry Finger 提交于
      Sparse reports the following:
      
        CHECK   drivers/staging/rtl8188eu/core/rtw_ieee80211.c
      drivers/staging/rtl8188eu/core/rtw_ieee80211.c:1593:14: warning: cast to restricted __le16
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      be987763
    • I
      staging: comedi: s626: replace S626_MULT_X? values · 7a1046e5
      Ian Abbott 提交于
      Replace the use of the `S626_MULT_X1`, `S626_MULT_X2` and `S626_MULT_X4`
      clock multiplier values with the equivalent `S626_CLKMULT_1X`,
      `S626_CLKMULT_2X` and `S626_CLKMULT_4X` values to avoid duplication.
      Replace the use of `S626_MULT_X0` with a new macro
      `S626_CLKMULT_SPECIAL` (this is treated specially by the
      'ClkMultA'/'ClkMultB' field of the 'CRA'/'CRB' register).  Remove the
      now unused `S626_MULT_X?` macros.
      Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
      Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      7a1046e5
    • I
      staging: comedi: s626: remove S626_BF_* macros · 43ce748f
      Ian Abbott 提交于
      The `S626_BF_*` bitfield position macros are no longer used and are just
      a subset of the corresponding `S626_STDBIT_*` bitfield position macros.
      Remove them.
      Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
      Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      43ce748f
    • I
      staging: comedi: s626: expand standardized IndxSrc values · 2cea19fa
      Ian Abbott 提交于
      The 'IndxSrc' value for the standardized encoder setup is currently 1
      bit wide and takes one of the following values:
      
        S626_INDXSRC_HARD = 0 // index source from hardware encoder
        S626_INDXSRC_SOFT = 1 // index source software controlled by IndxPol
      
      However the hardware 'IndxSrcA' and 'IndxSrcB' values for the 'A' and
      'B' counters are 2 bits wide.  The above standardized values 0 and 1
      correspond to the hardware values 0 and 2.
      
      In order to simplify conversions between the standardized values and
      hardware values, expand the range of standardized values to cover all
      four possible values.  The new values are as follows:
      
        S626_INDXSRC_ENCODER = 0  // index source from hardware encoder
        S626_INDXSRC_DIGIN = 1    // index source from digital inputs
        S626_INDXSRC_SOFT = 2     // index source s/w controlled by IndxPol
        S626_INDXSRC_DISABLED = 2 // index source disabled
      
      (Note the change in value for `S626_INDXSRC_SOFT` and the replacement of
      `S626_INDXSRC_HARD` with `S626_INDXSRC_ENCODER` for consistency with the
      `CntSrc` values.)
      Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
      Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      2cea19fa