1. 08 11月, 2013 14 次提交
    • M
      [media] stv0367: Don't use dynamic static allocation · 9aca4fb0
      Mauro Carvalho Chehab 提交于
      Dynamic static allocation is evil, as Kernel stack is too low, and
      compilation complains about it on some archs:
      	drivers/media/dvb-frontends/stv0367.c:791:1: warning: 'stv0367_writeregs.constprop.4' uses dynamic stack allocation [enabled by default]
      Instead, let's enforce a limit for the buffer. Considering that I2C
      transfers are generally limited, and that devices used on USB has a
      max data length of 64 bytes for	the control URBs.
      So, it seem safe to use 64 bytes as the hard limit for all those devices.
       On most cases, the limit is a way lower than that, but	this limit
      is small enough to not affect the Kernel stack, and it is a no brain
      limit, as using smaller ones would require to either carefully each
      driver or to take a look on each datasheet.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      9aca4fb0
    • M
      [media] stb0899_drv: Don't use dynamic static allocation · ba474642
      Mauro Carvalho Chehab 提交于
      Dynamic static allocation is evil, as Kernel stack is too low, and
      compilation complains about it on some archs:
      	drivers/media/dvb-frontends/stb0899_drv.c:540:1: warning: 'stb0899_write_regs' uses dynamic stack allocation [enabled by default]
      Instead, let's enforce a limit for the buffer. Considering that I2C
      transfers are generally limited, and that devices used on USB has a
      max data length of 64 bytes for	the control URBs.
      So, it seem safe to use 64 bytes as the hard limit for all those devices.
       On most cases, the limit is a way lower than that, but	this limit
      is small enough to not affect the Kernel stack, and it is a no brain
      limit, as using smaller ones would require to either carefully each
      driver or to take a look on each datasheet.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      ba474642
    • M
      [media] dvb-frontends: Don't use dynamic static allocation · 37ebaf68
      Mauro Carvalho Chehab 提交于
      Dynamic static allocation is evil, as Kernel stack is too low, and
      compilation complains about it on some archs:
      	drivers/media/dvb-frontends/af9013.c:77:1: warning: 'af9013_wr_regs_i2c' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/af9033.c:188:1: warning: 'af9033_wr_reg_val_tab' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/af9033.c:68:1: warning: 'af9033_wr_regs' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/bcm3510.c:230:1: warning: 'bcm3510_do_hab_cmd' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/cxd2820r_core.c:84:1: warning: 'cxd2820r_rd_regs_i2c.isra.1' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/rtl2830.c:56:1: warning: 'rtl2830_wr' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/rtl2832.c:187:1: warning: 'rtl2832_wr' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/tda10071.c:52:1: warning: 'tda10071_wr_regs' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/tda10071.c:84:1: warning: 'tda10071_rd_regs' uses dynamic stack allocation [enabled by default]
      Instead, let's enforce a limit for the buffer. Considering that I2C
      transfers are generally limited, and that devices used on USB has a
      max data length of 64 bytes for	the control URBs.
      So, it seem safe to use 64 bytes as the hard limit for all those devices.
       On most cases, the limit is a way lower than that, but	this limit
      is small enough to not affect the Kernel stack, and it is a no brain
      limit, as using smaller ones would require to either carefully each
      driver or to take a look on each datasheet.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Reviewed-by: NAntti Palosaari <crope@iki.fi>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      37ebaf68
    • M
      [media] dvb-frontends: Don't use dynamic static allocation · 8393796d
      Mauro Carvalho Chehab 提交于
      Dynamic static allocation is evil, as Kernel stack is too low, and
      compilation complains about it on some archs:
      	drivers/media/dvb-frontends/bcm3510.c:230:1: warning: 'bcm3510_do_hab_cmd' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/itd1000.c:69:1: warning: 'itd1000_write_regs.constprop.0' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/mt312.c:126:1: warning: 'mt312_write' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/nxt200x.c:111:1: warning: 'nxt200x_writebytes' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/stb6100.c:216:1: warning: 'stb6100_write_reg_range.constprop.3' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/stv6110.c:98:1: warning: 'stv6110_write_regs' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/stv6110x.c:85:1: warning: 'stv6110x_write_regs' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/tda18271c2dd.c:147:1: warning: 'WriteRegs' uses dynamic stack allocation [enabled by default]
      	drivers/media/dvb-frontends/zl10039.c:119:1: warning: 'zl10039_write' uses dynamic stack allocation [enabled by default]
      Instead, let's enforce a limit for the buffer. Considering that I2C
      transfers are generally limited, and that devices used on USB has a
      max data length of 64 bytes for the control URBs.
      So, it seem safe to use 64 bytes as the hard limit for all those devices.
       On most cases, the limit is a way lower than that, but this limit
      is small enough to not affect the Kernel stack, and it is a no brain
      limit, as using smaller ones would require to either carefully each
      driver or to take a look on each datasheet.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      8393796d
    • M
      [media] s5h1420: Don't use dynamic static allocation · 9736a89d
      Mauro Carvalho Chehab 提交于
      Dynamic static allocation is evil, as Kernel stack is too low, and
      compilation complains about it on some archs:
      	drivers/media/dvb-frontends/s5h1420.c:851:1: warning: 's5h1420_tuner_i2c_tuner_xfer' uses dynamic stack allocation [enabled by default]
      Instead, let's enforce a limit for the buffer.
      In the specific case of this frontend, only ttpci uses it. The maximum
      number of messages there is two, on I2C read operations. As the logic
      can add an extra operation, change the size to 3.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      9736a89d
    • M
      [media] uvc/lirc_serial: Fix some warnings on parisc arch · ce01cbdc
      Mauro Carvalho Chehab 提交于
      On this arch, usec is not unsigned long. So, we need to typecast,
      in order to remove those warnings:
      	drivers/media/usb/uvc/uvc_video.c: In function 'uvc_video_clock_update':
      	drivers/media/usb/uvc/uvc_video.c:678:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 9 has type '__kernel_suseconds_t' [-Wformat]
      	drivers/staging/media/lirc/lirc_serial.c: In function 'irq_handler':
      	drivers/staging/media/lirc/lirc_serial.c:707:5: warning: format '%lx' expects argument of type 'long unsigned int', but argument 6 has type '__kernel_suseconds_t' [-Wformat]
      	drivers/staging/media/lirc/lirc_serial.c:707:5: warning: format '%lx' expects argument of type 'long unsigned int', but argument 7 has type '__kernel_suseconds_t' [-Wformat]
      	drivers/staging/media/lirc/lirc_serial.c:719:5: warning: format '%lx' expects argument of type 'long unsigned int', but argument 6 has type '__kernel_suseconds_t' [-Wformat]
      	drivers/staging/media/lirc/lirc_serial.c:719:5: warning: format '%lx' expects argument of type 'long unsigned int', but argument 7 has type '__kernel_suseconds_t' [-Wformat]
      	drivers/staging/media/lirc/lirc_serial.c:728:6: warning: format '%lx' expects argument of type 'long unsigned int', but argument 6 has type '__kernel_suseconds_t' [-Wformat]
      	drivers/staging/media/lirc/lirc_serial.c:728:6: warning: format '%lx' expects argument of type 'long unsigned int', but argument 7 has type '__kernel_suseconds_t' [-Wformat]
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Acked-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      ce01cbdc
    • M
      [media] rc: Fir warnings on m68k arch · 221cefa4
      Mauro Carvalho Chehab 提交于
      Fix the following warnings:
      	drivers/media/rc/fintek-cir.c: In function 'fintek_cr_write':
      	drivers/media/rc/fintek-cir.c:45:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/fintek-cir.c:46:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/fintek-cir.c: In function 'fintek_cr_read':
      	drivers/media/rc/fintek-cir.c:54:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/fintek-cir.c:55:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/fintek-cir.c: In function 'fintek_config_mode_enable':
      	drivers/media/rc/fintek-cir.c:80:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/fintek-cir.c:81:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/fintek-cir.c: In function 'fintek_config_mode_disable':
      	drivers/media/rc/fintek-cir.c:87:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/nuvoton-cir.c: In function 'nvt_cr_write':
      	drivers/media/rc/nuvoton-cir.c:45:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/nuvoton-cir.c:46:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/nuvoton-cir.c: In function 'nvt_cr_read':
      	drivers/media/rc/nuvoton-cir.c:52:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/nuvoton-cir.c:53:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/nuvoton-cir.c: In function 'nvt_efm_enable':
      	drivers/media/rc/nuvoton-cir.c:74:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/nuvoton-cir.c:75:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/nuvoton-cir.c: In function 'nvt_efm_disable':
      	drivers/media/rc/nuvoton-cir.c:81:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/nuvoton-cir.c: In function 'nvt_select_logical_dev':
      	drivers/media/rc/nuvoton-cir.c:91:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      	drivers/media/rc/nuvoton-cir.c:92:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
      Those are caused because the I/O port is u32, instead of u8.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      221cefa4
    • M
      [media] radio-si470x-i2c: fix a warning on ia64 · c6c3795e
      Mauro Carvalho Chehab 提交于
      on ia64, those warnings appear:
      	drivers/media/radio/si470x/radio-si470x-i2c.c:470:12: warning: 'si470x_i2c_suspend' defined but not used [-Wunused-function]
      	drivers/media/radio/si470x/radio-si470x-i2c.c:487:12: warning: 'si470x_i2c_resume' defined but not used [-Wunused-function]
      They're caused because the PM logic uses this define:
      	#define SET_SYSTEM_SLEEP_PM_OPS()
      With is only defined for CONFIG_PM_SLEEP.
      So, change the logic there to test for CONFIG_PM_SLEEP, instead of
      CONFIG_PM.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      c6c3795e
    • S
      [media] iguanair: simplify calculation of carrier delay cycles · 9bd766b7
      Sean Young 提交于
      Simplify the logic that	calculates the carrier,	and removes a warning
      on avr32 arch:
              drivers/media/rc/iguanair.c: In function 'iguanair_set_tx_carrier':
              drivers/media/rc/iguanair.c:304: warning: 'sevens' may be used uninitialized in this function
      Signed-off-by: NSean Young <sean@mess.org>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      9bd766b7
    • M
      [media] tef6862: fix warning on avr32 arch · 5f27ca41
      Mauro Carvalho Chehab 提交于
      On avr32 arch, we get those warnings:
      	drivers/media/radio/tef6862.c:59:1: warning: "MODE_SHIFT" redefined
      	In file included from /devel/v4l/ktest-build/arch/avr32/include/asm/ptrace.h:11,
      	arch/avr32/include/uapi/asm/ptrace.h:41:1: warning: this is the location of the previous definition
      Prefix MSA_ to the MSA register bitmap macros, to avoid reusing the same symbol.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      5f27ca41
    • M
      [media] cx18: struct i2c_client is too big for stack · 1d212cf0
      Mauro Carvalho Chehab 提交于
      	drivers/media/pci/cx18/cx18-driver.c: In function 'cx18_read_eeprom':
      	drivers/media/pci/cx18/cx18-driver.c:357:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=]
      That happens because the routine allocates 256 bytes for an eeprom buffer, plus
      the size of struct i2c_client, with is big.
      Change the logic to dynamically allocate/deallocate space for struct i2c_client,
      instead of  using the stack.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      1d212cf0
    • M
      [media] zoran: don't build it on alpha · 51d8e7fb
      Mauro Carvalho Chehab 提交于
      This driver uses virt_to_bus() with is deprecated on Alpha:
      	drivers/media/pci/zoran/zoran_device.c: In function 'zr36057_set_vfe':
      	drivers/media/pci/zoran/zoran_device.c:451:3: warning: 'virt_to_bus' is deprecated (declared at /devel/v4l/ktest-build/arch/alpha/include/asm/io.h:114) [-Wdeprecated-declarations]
      	drivers/media/pci/zoran/zoran_device.c:453:3: warning: 'virt_to_bus' is deprecated (declared at /devel/v4l/ktest-build/arch/alpha/include/asm/io.h:114) [-Wdeprecated-declarations]
      	drivers/media/pci/zoran/zoran_device.c: In function 'zr36057_set_jpg':
      	drivers/media/pci/zoran/zoran_device.c:796:2: warning: 'virt_to_bus' is deprecated (declared at /devel/v4l/ktest-build/arch/alpha/include/asm/io.h:114) [-Wdeprecated-declarations]
      	drivers/media/pci/zoran/zoran_driver.c: In function 'v4l_fbuffer_alloc':
      	drivers/media/pci/zoran/zoran_driver.c:241:3: warning: 'virt_to_bus' is deprecated (declared at /devel/v4l/ktest-build/arch/alpha/include/asm/io.h:114) [-Wdeprecated-declarations]
      	drivers/media/pci/zoran/zoran_driver.c:245:3: warning: 'virt_to_bus' is deprecated (declared at /devel/v4l/ktest-build/arch/alpha/include/asm/io.h:114) [-Wdeprecated-declarations]
      	drivers/media/pci/zoran/zoran_driver.c: In function 'jpg_fbuffer_alloc':
      	drivers/media/pci/zoran/zoran_driver.c:334:3: warning: 'virt_to_bus' is deprecated (declared at /devel/v4l/ktest-build/arch/alpha/include/asm/io.h:114) [-Wdeprecated-declarations]
      	drivers/media/pci/zoran/zoran_driver.c:347:5: warning: 'virt_to_bus' is deprecated (declared at /devel/v4l/ktest-build/arch/alpha/include/asm/io.h:114) [-Wdeprecated-declarations]
      	drivers/media/pci/zoran/zoran_driver.c:366:6: warning: 'virt_to_bus' is deprecated (declared at /devel/v4l/ktest-build/arch/alpha/include/asm/io.h:114) [-Wdeprecated-declarations]
      As we're not even sure if it works on Alpha, better to just disable its compilation there.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      51d8e7fb
    • M
      [media] radio-shark: remove a warning when CONFIG_PM is not defined · c5b0b3cb
      Mauro Carvalho Chehab 提交于
      On alpha, allyesconfig doesn't have CONFIG_PM, and produces the following warnings:
      	drivers/media/radio/radio-shark.c:274:13: warning: 'shark_resume_leds' defined but not used [-Wunused-function]
      	drivers/media/radio/radio-shark2.c:240:13: warning: 'shark_resume_leds' defined but not used [-Wunused-function]
      That's because those functions are used only at device resume.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      c5b0b3cb
    • M
      [media] tda9887: remove an warning when compiling for alpha · 408679cd
      Mauro Carvalho Chehab 提交于
      There's no need to zero the buffer, as if the routine gets an error,
      rc will be different than one.
      That fixes the following warning:
      	drivers/media/tuners/tda9887.c: In function 'tda9887_status':
      	drivers/media/tuners/tda9887.c:539:2: warning: value computed is not used [-Wunused-value]
      While here, make fix the CodingStyle on this function.
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      Reviewed-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>
      408679cd
  2. 31 10月, 2013 26 次提交