1. 07 10月, 2015 1 次提交
  2. 22 9月, 2015 2 次提交
  3. 07 8月, 2015 1 次提交
  4. 19 5月, 2015 4 次提交
  5. 26 1月, 2015 2 次提交
    • T
      390/qeth: Fix locking warning during qeth device setup · 1aec42bc
      Thomas Richter 提交于
      Do not wait for channel command buffers in IPA commands.
      The potential wait could be done while holding a spin lock and causes
      in recent kernels such a bug if kernel lock debugging is enabled:
      
      kernel: BUG: sleeping function called from invalid context at drivers/s390/net/qeth_core_main.c:
      794
      kernel: in_atomic(): 1, irqs_disabled(): 0, pid: 2031, name: NetworkManager
      kernel: 2 locks held by NetworkManager/2031:
      kernel:  #0:  (rtnl_mutex){+.+.+.}, at: [<00000000006e0d7a>] rtnetlink_rcv+0x32/0x50
      kernel:  #1:  (_xmit_ETHER){+.....}, at: [<00000000006cfe90>] dev_set_rx_mode+0x30/0x50
      kernel: CPU: 0 PID: 2031 Comm: NetworkManager Not tainted 3.18.0-rc5-next-20141124 #1
      kernel:        00000000275fb1f0 00000000275fb280 0000000000000002 0000000000000000
                     00000000275fb320 00000000275fb298 00000000275fb298 00000000007e326a
                     0000000000000000 000000000099ce2c 00000000009b4988 000000000000000b
                     00000000275fb2e0 00000000275fb280 0000000000000000 0000000000000000
                     0000000000000000 00000000001129c8 00000000275fb280 00000000275fb2e0
      kernel: Call Trace:
      kernel: ([<00000000001128b0>] show_trace+0xf8/0x158)
      kernel:  [<000000000011297a>] show_stack+0x6a/0xe8
      kernel:  [<00000000007e995a>] dump_stack+0x82/0xb0
      kernel:  [<000000000017d668>] ___might_sleep+0x170/0x228
      kernel:  [<000003ff80026f0e>] qeth_wait_for_buffer+0x36/0xd0 [qeth]
      kernel:  [<000003ff80026fe2>] qeth_get_ipacmd_buffer+0x3a/0xc0 [qeth]
      kernel:  [<000003ff80105078>] qeth_l3_send_setdelmc+0x58/0xf8 [qeth_l3]
      kernel:  [<000003ff8010b1fe>] qeth_l3_set_ip_addr_list+0x2c6/0x848 [qeth_l3]
      kernel:  [<000003ff8010bbb4>] qeth_l3_set_multicast_list+0x434/0xc48 [qeth_l3]
      kernel:  [<00000000006cfe9a>] dev_set_rx_mode+0x3a/0x50
      kernel:  [<00000000006cff90>] __dev_open+0xe0/0x140
      kernel:  [<00000000006d02a0>] __dev_change_flags+0xa0/0x178
      kernel:  [<00000000006d03a8>] dev_change_flags+0x30/0x70
      kernel:  [<00000000006e14ee>] do_setlink+0x346/0x9a0
      ...
      
      The device driver has plenty of command buffers available
      per channel for channel command communication.
      In the extremely rare case when there is no command buffer
      available, return a NULL pointer and issue a warning
      in the kernel log. The caller handles the case when
      a NULL pointer is encountered and returns an error.
      
      In the case the wait for command buffer is possible
      (because no lock is held as in the OSN case), still wait
      until a channel command buffer is available.
      Signed-off-by: NThomas Richter <tmricht@linux.vnet.ibm.com>
      Signed-off-by: NUrsula Braun <ursula.braun@de.ibm.com>
      Reviewed-by: NEugene Crosser <Eugene.Crosser@ru.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      1aec42bc
    • E
      qeth: clean up error handling · efbbc1d5
      Eugene Crosser 提交于
      In the functions that are registering and unregistering MAC
      addresses in the qeth-handled hardware, remove callback functions
      that are unnesessary, as only the return code is analyzed.
      Translate hardware response codes to semi-standard 'errno'-like
      codes for readability.
      
      Add kernel-doc description to the internal API function
      qeth_send_control_data().
      Signed-off-by: NEugene Crosser <Eugene.Crosser@ru.ibm.com>
      Signed-off-by: NUrsula Braun <ursula.braun@de.ibm.com>
      Reviewed-by: NThomas-Mich Richter <tmricht@linux.vnet.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      efbbc1d5
  6. 18 1月, 2015 1 次提交
  7. 27 10月, 2014 1 次提交
  8. 16 7月, 2014 1 次提交
    • T
      net: set name_assign_type in alloc_netdev() · c835a677
      Tom Gundersen 提交于
      Extend alloc_netdev{,_mq{,s}}() to take name_assign_type as argument, and convert
      all users to pass NET_NAME_UNKNOWN.
      
      Coccinelle patch:
      
      @@
      expression sizeof_priv, name, setup, txqs, rxqs, count;
      @@
      
      (
      -alloc_netdev_mqs(sizeof_priv, name, setup, txqs, rxqs)
      +alloc_netdev_mqs(sizeof_priv, name, NET_NAME_UNKNOWN, setup, txqs, rxqs)
      |
      -alloc_netdev_mq(sizeof_priv, name, setup, count)
      +alloc_netdev_mq(sizeof_priv, name, NET_NAME_UNKNOWN, setup, count)
      |
      -alloc_netdev(sizeof_priv, name, setup)
      +alloc_netdev(sizeof_priv, name, NET_NAME_UNKNOWN, setup)
      )
      
      v9: move comments here from the wrong commit
      Signed-off-by: NTom Gundersen <teg@jklm.no>
      Reviewed-by: NDavid Herrmann <dh.herrmann@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c835a677
  9. 14 5月, 2014 1 次提交
  10. 29 4月, 2014 1 次提交
  11. 20 3月, 2014 1 次提交
  12. 26 2月, 2014 1 次提交
  13. 29 1月, 2014 1 次提交
  14. 16 1月, 2014 2 次提交
  15. 23 4月, 2013 2 次提交
  16. 20 4月, 2013 2 次提交
  17. 09 4月, 2013 1 次提交
  18. 22 1月, 2013 1 次提交
    • S
      qeth: Support VEPA mode · 0f54761d
      Stefan Raspl 提交于
      The existing port isolation mode 'forward' will now verify that the adjacent
      switch port supports the required reflective relay (RR) mode. This patch adds
      the required error handling for the cases where enabling port isolation mode
      'forward' can now fail.
      Furthermore, once established, we never fall back from one of the port
      isolation modes to a non-isolated mode without further user-interaction.
      This includes cases where the isolation mode was enabled successfully, but
      ceases to work e.g. due to configuration changes at the switch port.
      Finally, configuring an isolation mode with the device being offline
      will make onlining the device fail permanently upon errors encountered until
      either errors are resolved or the isolation mode is changed by the user to a
      different mode.
      Signed-off-by: NStefan Raspl <raspl@linux.vnet.ibm.com>
      Signed-off-by: NFrank Blaschka <frank.blaschka@de.ibm.com>
      Reviewed-by: NUrsula Braun <ursula.braun@de.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      0f54761d
  19. 20 11月, 2012 2 次提交
  20. 14 11月, 2012 2 次提交
  21. 17 10月, 2012 1 次提交
    • S
      qeth: fix deadlock between recovery and bonding driver · 2efaf5ff
      Stefan Raspl 提交于
      The recovery thread, when failing, tears down the respective interface. To do
      so, it needs to obtain the rtnl lock first, as the interface configuration is
      changed.
      If another process tries to modify an interface setting at the same time, that
      process can obtain the rtnl lock first, but the respective callback in the qeth
      driver will block until recovery has completed - which cannot happen since the
      calling process already obtained it.
      In one particular case, the bonding driver acquired the rtnl lock to modify the
      card's MAC address, while the recovery failed at the same time due to the card
      being removed. Hence qeth_l2_set_mac_address (implicitly holding the rtnl lock)
      was waiting on qeth_l2_recover, which deadlocked when waiting on the rtnl lock.
      This patch uses rtnl_trylock instead of rtnl_lock in the recovery thread. If the
      lock cannot be obtained, the interface will be left up, but the card state
      remains in CARD_STATE_RECOVER, which will prevent any further activities on the
      card.
      Signed-off-by: NStefan Raspl <raspl@linux.vnet.ibm.com>
      Signed-off-by: NFrank Blaschka <frank.blaschka@de.ibm.com>
      Reviewed-by: NUrsula Braun <ursula.braun@de.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2efaf5ff
  22. 20 7月, 2012 1 次提交
    • H
      s390/comments: unify copyright messages and remove file names · a53c8fab
      Heiko Carstens 提交于
      Remove the file name from the comment at top of many files. In most
      cases the file name was wrong anyway, so it's rather pointless.
      
      Also unify the IBM copyright statement. We did have a lot of sightly
      different statements and wanted to change them one after another
      whenever a file gets touched. However that never happened. Instead
      people start to take the old/"wrong" statements to use as a template
      for new files.
      So unify all of them in one go.
      Signed-off-by: NHeiko Carstens <heiko.carstens@de.ibm.com>
      a53c8fab
  23. 17 7月, 2012 1 次提交
  24. 16 5月, 2012 1 次提交
  25. 08 3月, 2012 1 次提交
  26. 09 2月, 2012 1 次提交
  27. 21 12月, 2011 1 次提交
    • U
      qeth: forbid recovery during shutdown · f78ac2bb
      Ursula Braun 提交于
      A recovery does not make sense during shutdown and may even cause an
      error like this:
      
      qeth 0.0.f503: A recovery process has been started for the device
      Badness at drivers/s390/cio/qdio_main.c:1156
      Modules linked in: autofs4 sunrpc dm_multipath scsi_dh scsi_mod qeth_l3 ipv6 vmu
      r qeth qdio ccwgroup ext3 jbd mbcache dasd_eckd_mod dasd_mod dm_mirror dm_region
      _hash dm_log dm_mod [last unloaded: scsi_wait_scan]
      CPU: 3 Not tainted 2.6.32-202.el6.s390x #1
      Process qeth_recover (pid: 1498, task: 000000003efe2040, ksp: 000000003d5e3b80)
      Krnl PSW : 0404200180000000 000003c000be6da8 (qdio_int_handler+0x88/0x43c [qdio]
      )
                 R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:0 CC:2 PM:0 EA:3
      Krnl GPRS: ffffffffffff3bac 0000000000000005 0000000000000000 fffffffffffffff4
                 0000000000000000 000000000000000c 0000000000000000 000000003ca97000
                 0000000000000380 fffffffffffffff4 000000003f22d800 000000003f22c478
                 000003c000bdf000 000003c000bea270 000000003f447e10 000000003f447db0
      Krnl Code: 000003c000be6d9a: c21f00000004       clfi    %r1,4
                 000003c000be6da0: a7c40021           brc     12,3c000be6de2
                 000003c000be6da4: a7f40001           brc     15,3c000be6da6
                >000003c000be6da8: e320a0080004       lg      %r2,8(%r10)
                 000003c000be6dae: a7390003           lghi    %r3,3
                 000003c000be6db2: a72b0178           aghi    %r2,376
                 000003c000be6db6: a7490001           lghi    %r4,1
                 000003c000be6dba: a7590000           lghi    %r5,0
      Call Trace:
      ([<000000000080ee80>] __per_cpu_offset+0x0/0x200)
      [<00000000003d90e8>] ccw_device_call_handler+0x70/0xcc
      [<00000000003d83a2>] ccw_device_irq+0x82/0x180
      [<00000000003cc6a8>] do_IRQ+0x16c/0x1ec
      [<0000000000118abe>] io_return+0x0/0x8
      [<000003c000d04c74>] qeth_determine_capabilities+0x208/0x5cc [qeth]
      ([<000003c000d04c4a>] qeth_determine_capabilities+0x1de/0x5cc [qeth])
      [<000003c000d0a6e0>] qeth_core_hardsetup_card+0x160/0x1258 [qeth]
      [<000003c000f49f56>] __qeth_l3_set_online+0x132/0xb14 [qeth_l3]
      [<000003c000f4ac70>] qeth_l3_recover+0x168/0x224 [qeth_l3]
      [<000000000016e210>] kthread+0xa4/0xac
      [<0000000000109c6e>] kernel_thread_starter+0x6/0xc
      [<0000000000109c68>] kernel_thread_starter+0x0/0xc
      
      The patch forbids start of a recovery once qeth shutdown is running.
      Signed-off-by: NUrsula Braun <ursula.braun@de.ibm.com>
      Signed-off-by: NFrank Blaschka <frank.blaschka@de.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      f78ac2bb
  28. 09 12月, 2011 1 次提交
  29. 18 8月, 2011 1 次提交
  30. 13 8月, 2011 1 次提交