Fix warning by checkpatch.pl
Add * for block comments on subsequent lines
Signed-off-by: NAnson Jacob <ansonjacob.aj@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the following checkpatch.pl warnings:

WARNING: Block comments use * on subsequent lines
+	/* TX_PE will reserve 3 us for MAX2829 A mode only,
+	   it is for better TX throughput */

WARNING: Block comments use a trailing */ on a separate line
+	   it is for better TX throughput */
Signed-off-by: NAnson Jacob <ansonjacob.aj@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The following patch fixes "Alignment should match open parantheses"
check thrown by checkpatch.pl
Signed-off-by: NRithvik Patibandla <rithvikp98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The following patch fixes two checks thrown by checkpatch.pl, "Spaces
preferred around '+'" and "No space is necessary after a cast"
Signed-off-by: NRithvik Patibandla <rithvikp98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes "Alignment should match open parantheses" check
thrown by checkpatch.pl
Signed-off-by: NRithvik Patibandla <rithvikp98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix "Alignment should match open paranthesis" check thrown by
checkpatch.pl
Signed-off-by: NRithvik Patibandla <rithvikp98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix "Avoid camel case" issue thrown by checkpatch.pl
Signed-off-by: NRithvik Patibandla <rithvikp98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix "Please use a blank line after function declaration" check thrown
by checkpatch.pl
Signed-off-by: NRithvik Patibandla <rithvikp98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix "Blank lines aren't necessary after an open brace" check thrown by
checkpatch.pl
Signed-off-by: NRithvik Patibandla <rithvikp98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix "Alignment should match with open paranthesis" check thrown by
checkpatch.pl
Signed-off-by: NRithvik Patibandla <rithvikp98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix "Block comments use * on subsequent lines" and "Block comments use
*/ on trailing lines" warnings thrown by checkpatch.pl
Signed-off-by: NRithvik Patibandla <rithvikp98@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the checkpatch.pl warning:

WARNING: Block comments use * on subsequent lines
Signed-off-by: NEdward Lipinsky <ellipinsky@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Split lines over 80 characters and separated assignments.
Signed-off-by: NStefan Wolz <wolzstefan@web.de>
Signed-off-by: NChristian Halder <christian.halder@fau.de>
Signed-off-by: NSebastian Handwerker <sebastian.handwerker@posteo.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixed multiline comments to meet style standards,
fixed typos and split comment lines over 80 characters.
Signed-off-by: NStefan Wolz <wolzstefan@web.de>
Signed-off-by: NChristian Halder <christian.halder@fau.de>
Signed-off-by: NSebastian Handwerker <sebastian.handwerker@posteo.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Deleted unnecessary newlines and added whitespaces around operators.
Signed-off-by: NStefan Wolz <wolzstefan@web.de>
Signed-off-by: NChristian Halder <christian.halder@fau.de>
Signed-off-by: NSebastian Handwerker <sebastian.handwerker@posteo.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixed alignment in multiline declarations.
Signed-off-by: NStefan Wolz <wolzstefan@web.de>
Signed-off-by: NChristian Halder <christian.halder@fau.de>
Signed-off-by: NSebastian Handwerker <sebastian.handwerker@posteo.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Nyeongjun Kim <iam.yeongjunkim@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This is a patch to the ddk750_chip.c file that fixes up two block
comment coding style warnings found by the checkpatch.pl tool
Signed-off-by: NMoshe Green <mgmoshes@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This is a patch to the ddk750_chip.c file that fixes up a line length
warning found by the checkpatch.pl tool
Signed-off-by: NMoshe Green <mgmoshes@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This is a patch to the ddk750_chip.c file that fixes up a
line length warning found by the checkpatch.pl tool.
Signed-off-by: NMoshe Green <paledirac@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Removed a blankline after an opening bracket.
Signed-off-by: NSamuele Baisi <ciccio87@gmail.com>
Acked-by: NLuis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace semaphore netlink_mutex with mutex. Semaphores are
going away in the future.
Signed-off-by: NBinoy Jayan <binoy.jayan@linaro.org>
Reviewed-by: NArnd Bergmann <arnd@arndb.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The value assigned to ret will be overwritten before it could be read in a
future iteration of the loop. Removing the unnecessary assignment.
Signed-off-by: NLuis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.

There was a check on CAP_NET_ADMIN in cvm_oct_set_settings, but this
check is already done in dev_ethtool, so no need to repeat it before
calling the generic function.
Signed-off-by: NPhilippe Reynes <tremyfr@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The private structure contain a pointer to phydev, but the structure
net_device already contain such pointer. So we can remove the pointer
phydev in the private structure, and update the driver to use the
one contained in struct net_device.
Signed-off-by: NPhilippe Reynes <tremyfr@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

There will be a separate banner message after pow0 is set up (or an
error message if it failed).
Signed-off-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Check for pow0 port first before calling the interface helper. This
avoids the following error log when setting up pow0 interface:

	cvmx_helper_get_interface_num: Illegal IPD port number
Signed-off-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Some helper functions call INDEX before checking if the interface is
valid. Since pow0 is not a real interface, we get the following errors:

	cvmx_helper_get_interface_index_num: Illegal IPD port number

Fix by using INDEX only when needed with real interfaces.
Signed-off-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Merge several structures for statistics to one structure and remove
unnecessary union nesting.
Signed-off-by: NLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove the volatile specifiers of struct slic_shmem. Furthermore store the
bus addresses for the isr pointer, link status and statistics separately
and access the upper and lower word of these addresses by means of
[lower|upper]_32_bits(). By doing this take the endianness into account.
Signed-off-by: NLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use the new register accessors that use offsets instead of the slic_regs
structure to read/write registers. Since not longer needed remove the
structure completley.
Signed-off-by: NLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Introduce the function slic_flush_write() which reads from the HOSTID
register and can be used to avoid PCI write posting. Use the function at
several critical places in the code.
Signed-off-by: NLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Introduce accessor functions that read and write registers by using a
register offset.
This is in preparation to replace the register addressing by means of the
slic_regs struct with an addressing by means of offsets.
Signed-off-by: NLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

There is no reason to delay tx queue activation until a link is detected.
So start the queue when the interface is brought up and stop it when the
interface is brought down.
Signed-off-by: NLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Writes to registers should be done uncached for various reasons. Ensure
this by replacing ioremap() with ioremap_nocache().
Signed-off-by: NLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Notify the network stack about link states via netif_carrier_[off|on]().
Also set the link state off initially and when the interface is brought
down.
Signed-off-by: NLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The memory allocation in slic_init_adapter() can fail. Return an error in
this case and unwind properly. Also make sure that the allocated memory is
properly freed in case of an error in the calling probe() function.
By doing this also replace the alloc() followed by memset to zero the
memory with a zalloc() version.
Signed-off-by: NLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fix checkpatch.pl warning about 'line over 80 characters'.
Signed-off-by: NAnson Jacob <ansonjacob.aj@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

WARNING: Statements should start on a tabstop
Signed-off-by: NPrit Raj <prit.adra@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace unsigned by unsigned int in fbtft driver.  Issue found by
checkpatch.
Signed-off-by: NMing Yang <minos.future@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>