store_protocols() treats dev->rc_map.rc_type as a bitmap which is wrong for
two reasons. First of all, it is pretty bogus to change the protocol type of
the keymap just because the hardware has been asked to decode a different
protocol.
Second, dev->rc_map.rc_type is an enum (i.e. a single protocol) as pointed
out by James Hogan <james.hogan@imgtec.com>.
Fix both issues by introducing a separate enabled_protocols member to
struct rc_dev.
Signed-off-by: NDavid Härdeman <david@hardeman.nu>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

ts2020.h was included twice.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

This patch enable dual tuner for Avermedia Twinstar.
Signed-off-by: NJose Alberto Reguero <jareguero@telefonica.net>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The dv_preset API is deprecated and is replaced by the much improved dv_timings
API. Remove the dv_preset support from this driver as this will allow us to
remove the dv_preset API altogether (s5p-tv being the last user of this code).
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Tested-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The dv_preset API is deprecated and is replaced by the much improved dv_timings
API. Remove the dv_preset support from this driver as this will allow us to
remove the dv_preset API altogether (s5p-tv being the last user of this code).
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Tested-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

The dv_preset API is deprecated and is replaced by the much improved dv_timings
API. Remove the dv_preset support from this driver as this will allow us to
remove the dv_preset API altogether (s5p-tv being the last user of this code).
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Tested-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

This just adds dv_timings support without modifying existing dv_preset
support.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Tested-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

This just adds dv_timings support without modifying existing dv_preset
support.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Tested-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

This just adds dv_timings support without modifying existing dv_preset
support, although I had to refactor a little bit in order to share
hdmiphy_find_conf() between the preset and timings code.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Tested-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Acked-by: NTomasz Stanislawski <t.stanislaws@samsung.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

usb_free_coherent() is safe with NULL addr and this check is
not required.
Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Last parameter of function GetLockStatus() isn't used so drop it.
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

export the symbols which are used by two modules vpif_capture and
vpif_display. renamed "ch_params" to "vpif_ch_params" so as to avoid
name collision.
This patch fixes following error:
ERROR: "ch_params" [drivers/media/platform/davinci/vpif_display.ko] undefined!
ERROR: "vpif_ch_params_count" [drivers/media/platform/davinci/vpif_display.ko] undefined!
ERROR: "vpif_base" [drivers/media/platform/davinci/vpif_display.ko] undefined!
ERROR: "ch_params" [drivers/media/platform/davinci/vpif_capture.ko] undefined!
ERROR: "vpif_ch_params_count" [drivers/media/platform/davinci/vpif_capture.ko] undefined!
ERROR: "vpif_base" [drivers/media/platform/davinci/vpif_capture.ko] undefined!
make[1]: *** [__modpost] Error 1
Reported-by: NSekhar Nori <nsekhar@ti.com>
Signed-off-by: NLad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

for NUL terminated string, need always set 0 in the end.
Signed-off-by: NChen Gang <gang.chen@asianux.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Add MODULE_ALIAS entry for radio-si4713 platform driver.
Signed-off-by: NEduardo Valentin <edubezval@gmail.com>
Acked-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Simple addition of platform_driver->driver->owner for radio-si4713.
Signed-off-by: NEduardo Valentin <edubezval@gmail.com>
Acked-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

As per code header comment, changing the driver license entry
to match the correct version.
Signed-off-by: NEduardo Valentin <edubezval@gmail.com>
Acked-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Minor changes to make alignment match on open parenthesis.
Signed-off-by: NEduardo Valentin <edubezval@gmail.com>
Acked-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

I just made commit: "dvb_usb_v2: rework USB streaming logic" that
breaks that driver PID filter.
it913x driver checks use of PID filter directly from DVB USB v2 core
internal variable "adap->pid_filtering" and stores it to own state.
Calling order of .pid_filter_ctrl() and .pid_filter() was changed
and due to that state was updated too late. Update state earlier.
TODO: checking PID filter usage from DVB USB v2 is not very good idea
as PID filter callbacks are called only when PID filter is enabled.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Control flow order changed a little bit. HW PID filter is now
disabled also when streaming is stopped - earlier it was just
set only when streaming was started.
Control flow is now:
* set streaming status bit
* submit USB streaming packets
* enable HW PID filter
* ask device to start streaming
* N x add PID to device HW PID filter
... streaming video ...
* N x remove PID from device HW PID filter
* ask device to stop streaming
* disable HW PID filter
* kill USB streaming packets
* clear streaming status bit
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

New checkpatch version likes to see strings not to split multiple
lines even those are exceeding 80 line length.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

New checkpatch version likes to see strings not to split multiple
lines even those are exceeding 80 line length.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

There was sync mutex which was held over userspace. That is very
wrong and could cause deadlock if different userspace process is
used to "unlock". Wait queue seems to be correct solution for
that kind of synchronizing issue so use it instead.
lock debug gives following bug report:
================================================
[ BUG: lock held when returning to user space! ]
3.9.0-rc1+ #38 Tainted: G           O
------------------------------------------------
tzap/4614 is leaving the kernel with locks still held!
1 lock held by tzap/4614:
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Instead of checking everywhere there for 3 symbols, use instead
IS_ENABLED macro.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Instead of checking everywhere there for 3 symbols, use instead
IS_ENABLED macro.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Instead of checking everywhere there for 3 symbols, use instead
IS_ENABLED macro.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Instead of checking everywhere there for 3 symbols, use instead
IS_ENABLED macro.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

As reported by Geert Uytterhoeven <geert@linux-m68k.org>:
	drivers/media/usb/hdpvr/hdpvr-video.c: warning: "CONFIG_I2C_MODULE" is not defined [-Wundef]
Reported-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Thanks-to: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

dvb_usb_v2_generic_io() was not declared. It should be static.
Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Commit aab3125c broke em28xx. I traced
this eventually to the change in what algo_data points to. This pointer
is also passed to em28xx_tuner_callback() through several hidden tuner
layers (yuck!) and that callback was not updated.
Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

There's currently a bug on em28xx-i2c that makes it write the
wrong values to register 06, that controlls the I2C bus speed
and bus.

Fix it to change only the I2C bus flag.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

It used to be a code that returns arror at ov7660_init.
However, this was removed by changeset c84e412f:

@@ -231,33 +116,40 @@ int ov7660_init(struct sd *sd)
        if (dump_sensor)
                ov7660_dump_registers(sd);

-   err = ov7660_set_gain(&sd->gspca_dev, sensor_settings[GAIN_IDX]);
-   if (err < 0)
-           return err;
+ return 0;
+}

-   err = ov7660_set_auto_white_balance(&sd->gspca_dev,
-           sensor_settings[AUTO_WHITE_BALANCE_IDX]);
-   if (err < 0)
-           return err;

As complained by gcc:
	drivers/media/usb/gspca/m5602/m5602_ov7660.c: In function 'ov7660_init':
	drivers/media/usb/gspca/m5602/m5602_ov7660.c:99:9: warning: variable 'err' set but not used [-Wunused-but-set-variable]

It should be noticed that the original error code was crappy, as it wasn't
returning any error if sensor init fails.

Fix it by returning an error if the sensor can't be initialized.

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

This field is unused. Remove it.
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Changeset 8f3741e0 accidentally broke the CNR estimation. It should
be calculated as "a + b - c". However, previously, the subtraction
by c only occurred if SNR would be positive, due to a bad binding
to DVBv3 API.

This also fixes the following warning:
	drivers/media/dvb-frontends/drxk_hard.c:2556:6: warning: variable 'c' set but not used [-Wunused-but-set-variable]
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

As reported by Frank Schäfer <fschaefer.oss@googlemail.com>:
	ERROR: "__divdi3" [drivers/media/common/siano/smsdvb.ko] undefined!
Reported-by: NFrank Schäfer <fschaefer.oss@googlemail.com>
Tested-by: NGianluca Gennari <gennarone@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Use more careful error checks.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Use register address auto increment to reduce I/O when large
register / values tables are written.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

That register is property of demodulator so move it correct place.
Signed-off-by: NAntti Palosaari <crope@iki.fi>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>