1. 09 1月, 2018 5 次提交
  2. 09 11月, 2017 2 次提交
    • A
      ASoC: Intel: improve SND_SOC_INTEL_MACH dependencies · 960115b8
      Arnd Bergmann 提交于
      I ran into a build error with CONFIG_SND_SOC_INTEL_COMMON=m
      and SND_SOC_INTEL_MACH=y:
      
      ERROR: "snd_soc_acpi_intel_broadwell_machines" [sound/soc/intel/common/snd-soc-sst-acpi.ko] undefined!
      ERROR: "snd_soc_acpi_intel_haswell_machines" [sound/soc/intel/common/snd-soc-sst-acpi.ko] undefined!
      ERROR: "snd_soc_acpi_intel_cherrytrail_machines" [sound/soc/intel/atom/sst/snd-intel-sst-acpi.ko] undefined!
      ERROR: "snd_soc_acpi_intel_baytrail_machines" [sound/soc/intel/atom/sst/snd-intel-sst-acpi.ko] undefined!
      
      The problem here is that the sound/soc/intel/common/ directory
      is then entered only for building modules, but the sst-acpi.o
      never gets built since it depends on a built-in Kconfig symbol.
      
      That configuration obviously makes no sense since all options
      below SND_SOC_INTEL_MACH also depend on something else that
      in turn depends on CONFIG_SND_SOC_INTEL_COMMON.
      
      Adding a SND_SOC_INTEL_SST_TOPLEVEL dependency to SND_SOC_INTEL_MACH
      solves the build error. I notice we can also consolidate the
      'depends on SND_SOC_INTEL_MACH' lines by using an 'if' block to
      simplify it further and make sure the configuration stays sane.
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Acked-By: NVinod Koul <vinod.koul@intel.com>
      Reviewed-by: NPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      960115b8
    • A
      ASoC: Intel: improve DMADEVICES dependency · 326c4aa2
      Arnd Bergmann 提交于
      As pointed out by Pierre-Louis Bossart, the dependency I added
      was broader than necessary, only Baytrail and Haswell/Broadwell
      actually need it, the others don't.
      
      At the same time, we have individual entries for the codecs
      that all have the 'select' statement but now don't need it
      any more.
      
      Fixes: f7a88db6 ("ASoC: Intel: fix Kconfig dependencies")
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Acked-By: NVinod Koul <vinod.koul@intel.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      326c4aa2
  3. 21 10月, 2017 5 次提交
  4. 17 8月, 2017 1 次提交
  5. 15 6月, 2017 1 次提交
  6. 14 6月, 2017 1 次提交
  7. 25 5月, 2017 1 次提交
  8. 14 3月, 2017 2 次提交
  9. 18 1月, 2017 4 次提交
  10. 11 10月, 2016 1 次提交
    • A
      ASoC: Intel: haswell depends on sst-firmware · c3474e21
      Arnd Bergmann 提交于
      The Intel Haswell audio support fails to link if
      CONFIG_SND_SOC_INTEL_SST_FIRMWARE is disabled:
      
      sst-haswell-dsp.c: undefined reference to `sst_mem_block_register'
      sst-haswell-dsp.c: undefined reference to `sst_mem_block_unregister_all'
      sst-haswell-dsp.c: undefined reference to `sst_module_alloc_blocks'
      sst-haswell-dsp.c: undefined reference to `sst_module_free'
      sst-haswell-dsp.c: undefined reference to `sst_module_new'
      sst-haswell-pcm.c: undefined reference to `sst_module_get_from_id'
      sst-haswell-pcm.c: undefined reference to `sst_module_runtime_restore'
      sst-haswell-pcm.c: undefined reference to `sst_module_runtime_save'
      ERROR: "sst_block_alloc_scratch" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_block_free_scratch" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_dsp_dma_copyfrom" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_dsp_dma_copyto" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_dsp_dma_get_channel" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_dsp_dma_put_channel" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_dsp_free" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_dsp_get_offset" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_dsp_new" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_fw_free_all" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_fw_new" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_fw_reload" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_fw_unload" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_module_runtime_alloc_blocks" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_module_runtime_get_from_id" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      ERROR: "sst_module_runtime_new" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
      
      This moves the 'select' statement from two of the three haswell based users
      into the line that is used by all of them, so make it harder to get wrong
      and to fix the existing randconfig regressions.
      
      Fixes: 2d995e5d ("ASoC: Intel: boards: Add bdw-rt5677 machine driver")
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      c3474e21
  11. 25 9月, 2016 1 次提交
  12. 04 9月, 2016 1 次提交
  13. 12 7月, 2016 1 次提交
    • T
      ASoC: intel: Fix sst-dsp dependency on dw stuff · a395bdd6
      Takashi Iwai 提交于
      The recent commit [a92ea59b: ASoC: Intel: sst: only select
      sst-firmware when DW DMAC is built-in] introduced more strict kconfig
      dependency (depends on DW_DMAC_CORE=y) for avoiding the build failures
      due to dependency messes in intel-sst.  This makes, however, it
      impossible to use this driver with the modularized systems,
      i.e. typically on Linux distros.
      
      The problem addressed in the commit above is that sst_dsp_new() and
      sst_dsp_free() includes the firmware init / finish that call dw_*()
      functions.  Thus building it as built-in with DW_DMAC_CORE module
      results in the missing symbols.
      
      However, these sst_dsp functions are basically called only from the
      drivers that depend on DW_DMAC_CORE already.  That is, once when these
      functions are split out, the rest can be independent from dw stuff.
      
      This patch attempts to solve the issue by the following:
      - Split sst-dsp stuff into two modules: snd-soc-sst-dsp and
        snd-soc-sst-firmware.
      - Move sst_dsp_new() and sst_dsp_free() to the latter module so that
        the former module can be independent from DW_DMAC_CORE.
      - Add a new kconfig SND_SOC_INTEL_SST_FIRMWARE to select the latter
        module by machine drivers.
      
      One only remaining pitfall is that each machine driver has to select
      SND_SOC_INTEL_SST_FIRMWARE carefully depending on DW_DMAC_CORE.
      This can't be done cleanly due to the restriction of the current
      kbuild.
      
      Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=988117
      Fixes: a92ea59b ('ASoC: Intel: sst: only select sst-firmware when DW DMAC is built-in')
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      a395bdd6
  14. 22 6月, 2016 2 次提交
    • V
      ASoC: Intel: Kconfig: formatting update · c3f2fe62
      Vinod Koul 提交于
      Kconfig help texts were missing periods as suggested by Randy.
      
      Also fix the alignment on a block of help text to be consistent
      with rest.
      Suggested-by: NRandy Dunlap <rdunlap@infradead.org>
      Signed-off-by: NVinod Koul <vinod.koul@intel.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      c3f2fe62
    • V
      ASoC: Intel: Kconfig: fix build when ACPI is not enabled · 3493d4a8
      Vinod Koul 提交于
      Randy reported following error when ACPI is not enabled:
      
      warning: (SND_SOC_INTEL_BYTCR_RT5640_MACH && SND_SOC_INTEL_BYTCR_RT5651_MACH
      && SND_SOC_INTEL_CHT_BSW_RT5672_MACH && SND_SOC_INTEL_CHT_BSW_RT5645_MACH &&
      SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH) selects SND_SST_IPC_ACPI
      +which has unmet direct dependencies (SOUND && !M68K && !UML && SND &&
      SND_SOC && ACPI)
      
      causing these build errors:
      
      In file included from ../sound/soc/intel/atom/sst/sst_acpi.c:40:0:
      ../include/acpi/acpi_bus.h:65:20: error: conflicting types for
      'acpi_evaluate_dsm'
       union acpi_object *acpi_evaluate_dsm(acpi_handle handle, const u8 *uuid,
      In file included from ../sound/soc/intel/atom/sst/sst_acpi.c:31:0:
      ../include/linux/acpi.h:676:34: note: previous definition of
      'acpi_evaluate_dsm' was here
       static inline union acpi_object *acpi_evaluate_dsm(acpi_handle handle,
      
      CONFIG_SND_SST_IPC_ACPI was already dependent upon ACPI, but that was not
      solving it. So move the depends up to machine drivers and remove from
      CONFIG_SND_SST_IPC_ACPI.
      Reported-by: NRandy Dunlap <rdunlap@infradead.org>
      Signed-off-by: NVinod Koul <vinod.koul@intel.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      3493d4a8
  15. 02 6月, 2016 1 次提交
  16. 11 5月, 2016 1 次提交
  17. 31 3月, 2016 1 次提交
  18. 18 3月, 2016 1 次提交
  19. 24 2月, 2016 3 次提交
  20. 19 2月, 2016 1 次提交
  21. 08 2月, 2016 2 次提交
  22. 05 1月, 2016 1 次提交
  23. 19 12月, 2015 1 次提交