1. 01 12月, 2016 1 次提交
  2. 07 11月, 2016 1 次提交
  3. 29 8月, 2016 3 次提交
  4. 11 8月, 2016 1 次提交
    • P
      drm/imx-ldb: Add support to drm-bridge · dc80d703
      Peter Senna Tschudin 提交于
      Add support to attach a drm_bridge to imx-ldb in addition to
      existing support to attach a LVDS panel.
      
      This patch does a simple code refactoring by moving code
      from for_each_child_of_node iterator to a new function named
      imx_ldb_panel_ddc(). This was necessary to allow the panel ddc
      code to run only when the imx_ldb is not attached to a bridge.
      
      Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
      Cc: Philipp Zabel <p.zabel@pengutronix.de>
      Cc: Rob Herring <robh@kernel.org>
      Cc: Fabio Estevam <fabio.estevam@nxp.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Thierry Reding <treding@nvidia.com>
      Cc: Thierry Reding <thierry.reding@gmail.com>
      Signed-off-by: NPeter Senna Tschudin <peter.senna@collabora.com>
      Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
      dc80d703
  5. 08 8月, 2016 2 次提交
  6. 28 7月, 2016 1 次提交
    • P
      drm/imx: imx-ldb: do not try to dereference crtc->state->state in encoder mode_set · ff615eed
      Philipp Zabel 提交于
      The code in imx_ldb_encoder_mode_set crashes with a NULL pointer
      dereference trying to access crtc->state->state, which was previously
      cleared by drm_atomic_helper_swap_state:
      
          Unable to handle kernel NULL pointer dereference at virtual address 00000010
          pgd = ae08c000
          [00000010] *pgd=3e00e831, *pte=00000000, *ppte=00000000
          Internal error: Oops: 17 [#1] PREEMPT SMP ARM
          Modules linked in:
          CPU: 1 PID: 102 Comm: kmsfb-manage Not tainted 4.7.0-rc5+ #232
          Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree)
          task: ae058c40 ti: ae04e000 task.ti: ae04e000
          PC is at imx_ldb_encoder_mode_set+0x138/0x2f8
          LR is at 0xae881818
          pc : [<8051a8c8>]    lr : [<ae881818>]    psr: 600f0013
          sp : ae04fc70  ip : ae04fbb0  fp : ae04fcbc
          r10: ae8ea018  r9 : 00000000  r8 : ae246418
          r7 : ae8ea010  r6 : ae8ea308  r5 : 00000000  r4 : 00000000
          r3 : 00000000  r2 : 00000000  r1 : 00000110  r0 : 00000000
          Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
          Control: 10c5387d  Table: 3e08c04a  DAC: 00000051
          Process kmsfb-manage (pid: 102, stack limit = 0xae04e210)
          Stack: (0xae04fc70 to 0xae050000)
          fc60:                                     043ce660 00000001 0000009e 043ce660
          fc80: 00000002 00000000 00000000 af75cf50 00001009 ae23f440 00000001 ae246418
          fca0: 8155a210 ae8ea308 8093c364 ae2464e0 ae04fcec ae04fcc0 804ef350 8051a79c
          fcc0: 00000004 00000004 ae23f440 af3f9000 ae881818 8155a210 af1af200 ae8ea020
          fce0: ae04fd1c ae04fcf0 80519124 804ef060 ae04fd34 00000000 00000000 00000000
          fd00: ae881818 ae23f440 80d4ec8c 00000000 ae04fd34 ae04fd20 804f00b4 80518fac
          fd20: ae23f440 00000000 ae04fd54 ae04fd38 804f2190 804f0074 ae23f440 af3f9000
          fd40: ae04fdd4 ae881818 ae04fd6c ae04fd58 80516390 804f20f4 ae23f440 00000000
          fd60: ae04fd8c ae04fd70 804f26f4 80516348 ae23a000 ae881818 00000001 af3f9000
          fd80: ae04fdac ae04fd90 80502c58 804f2678 ae04fe50 ae23f400 00000001 af3f9000
          fda0: ae04fe1c ae04fdb0 80507a1c 80502bf8 ae23a000 ae058c40 af1af200 ae23f400
          fdc0: ae23a000 af3f9000 ae881818 ae23a00c 80176c7c ae23a000 ae881818 af1af200
          fde0: 00000000 00000000 ae23f400 00000001 ae04fe1c 00000051 ae04fe50 8155a210
          fe00: 80932060 c06864a2 af3f9000 ae246200 ae04fefc ae04fe20 804f9718 805074e8
          fe20: ae04feac ae04fe30 80177360 8017631c 805074dc 00000068 00000068 00000062
          fe40: 00000068 000000a2 ae04fe50 7ef29688 7ef29c40 00000000 00000001 00000018
          fe60: 00000026 00000000 00000000 00000000 00000001 000115bc 05010500 05a0059f
          fe80: 03200000 03360321 00000337 0000003c 00000000 00000040 30383231 30303878
          fea0: 00000000 00000000 00000000 00000000 00000000 00000000 00004000 aea6a140
          fec0: 00000000 80d77b71 00000000 80283110 600f0013 7ef29688 af342bb0 ae250b40
          fee0: 80275440 00000003 ae04e000 00000000 ae04ff7c ae04ff00 80274ac8 804f957c
          ff00: 80283128 80179030 00000000 00000000 80282fd8 ae1e0000 0000003d aea6a1d0
          ff20: 00000002 00000003 00004000 007f8c60 c06864a2 7ef29688 ae04e000 00000000
          ff40: ae04ff6c ae04ff50 80283260 80282fe4 00017050 ae250b41 00000003 ae250b40
          ff60: c06864a2 7ef29688 ae04e000 00000000 ae04ffa4 ae04ff80 80275440 80274a20
          ff80: 00017050 00000001 007f8c60 00000036 801088a4 ae04e000 00000000 ae04ffa8
          ffa0: 80108700 80275408 00017050 00000001 00000003 c06864a2 7ef29688 000115bc
          ffc0: 00017050 00000001 007f8c60 00000036 00000003 00000000 00000026 00000018
          ffe0: 00016f28 7ef29684 0000b7d9 76e4a1e6 400f0030 00000003 3ff7e861 3ff7ec61
          Backtrace:
          [<8051a790>] (imx_ldb_encoder_mode_set) from [<804ef350>] (drm_atomic_helper_commit_modeset_disables+0x2fc/0x3f0)
           r10:ae2464e0 r9:8093c364 r8:ae8ea308 r7:8155a210 r6:ae246418 r5:00000001
           r4:ae23f440
          [<804ef054>] (drm_atomic_helper_commit_modeset_disables) from [<80519124>] (imx_drm_atomic_commit_tail+0x184/0x1e0)
           r10:ae8ea020 r9:af1af200 r8:8155a210 r7:ae881818 r6:af3f9000 r5:ae23f440
           r4:00000004 r3:00000004
          [<80518fa0>] (imx_drm_atomic_commit_tail) from [<804f00b4>] (commit_tail+0x4c/0x68)
           r6:00000000 r5:80d4ec8c r4:ae23f440
          [<804f0068>] (commit_tail) from [<804f2190>] (drm_atomic_helper_commit+0xa8/0xd4)
           r5:00000000 r4:ae23f440
          [<804f20e8>] (drm_atomic_helper_commit) from [<80516390>] (drm_atomic_commit+0x54/0x74)
           r7:ae881818 r6:ae04fdd4 r5:af3f9000 r4:ae23f440
          [<8051633c>] (drm_atomic_commit) from [<804f26f4>] (drm_atomic_helper_set_config+0x88/0xac)
           r5:00000000 r4:ae23f440
          [<804f266c>] (drm_atomic_helper_set_config) from [<80502c58>] (drm_mode_set_config_internal+0x6c/0xf4)
           r7:af3f9000 r6:00000001 r5:ae881818 r4:ae23a000
          [<80502bec>] (drm_mode_set_config_internal) from [<80507a1c>] (drm_mode_setcrtc+0x540/0x5b8)
           r7:af3f9000 r6:00000001 r5:ae23f400 r4:ae04fe50
          [<805074dc>] (drm_mode_setcrtc) from [<804f9718>] (drm_ioctl+0x1a8/0x46c)
           r10:ae246200 r9:af3f9000 r8:c06864a2 r7:80932060 r6:8155a210 r5:ae04fe50
           r4:00000051
          [<804f9570>] (drm_ioctl) from [<80274ac8>] (do_vfs_ioctl+0xb4/0x9e8)
           r10:00000000 r9:ae04e000 r8:00000003 r7:80275440 r6:ae250b40 r5:af342bb0
           r4:7ef29688
          [<80274a14>] (do_vfs_ioctl) from [<80275440>] (SyS_ioctl+0x44/0x6c)
           r10:00000000 r9:ae04e000 r8:7ef29688 r7:c06864a2 r6:ae250b40 r5:00000003
           r4:ae250b41
          [<802753fc>] (SyS_ioctl) from [<80108700>] (ret_fast_syscall+0x0/0x1c)
           r9:ae04e000 r8:801088a4 r7:00000036 r6:007f8c60 r5:00000001 r4:00017050
          Code: 1a000018 e596e034 e59e3368 e59331bc (e5930010)
          ---[ end trace 464e7d3c7f4b9706 ]---
      
      Instead of trying to walk only the connectors in atomic state to which we
      don't have access, just walk all connectors to find one connected to the
      current encoder and containing a bus_format description.
      
      Fixes: 49f98bc4 ("drm/imx: store internal bus configuration in crtc state")
      Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
      Acked-by: NLiu Ying <gnuiyl@gmail.com>
      ff615eed
  7. 13 7月, 2016 6 次提交
  8. 30 5月, 2016 3 次提交
  9. 01 3月, 2016 1 次提交
  10. 16 2月, 2016 1 次提交
  11. 15 12月, 2015 1 次提交
  12. 11 12月, 2015 1 次提交
  13. 31 3月, 2015 5 次提交
    • P
      drm/imx: imx-ldb: allow to determine bus format from the connected panel · 5e501ed7
      Philipp Zabel 提交于
      This patch makes the fsl,data-width and fsl,data-mapping device tree
      properties optional if a panel is connected to the ldb output port
      via the of_graph bindings. The data mapping is determined from the
      display_info.bus_format field provided by the panel.
      Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
      5e501ed7
    • P
      drm/imx: imx-ldb: reset display clock input when disabling LVDS · 3973aff0
      Philipp Zabel 提交于
      The LDB driver changes the attached display interface's input clock mux
      to the LDB_DI clock reference. Change it back again when disabling the
      LVDS display. Changing back to the PLL5 for example allows to configure
      the same DI for HDMI output later.
      Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
      3973aff0
    • P
      drm/imx: imx-ldb: add drm_panel support · 751e2676
      Philipp Zabel 提交于
      This patch allows to optionally attach the lvds-channel to a panel
      supported by a drm_panel driver using of-graph bindings, instead of
      supplying the modes via display-timings in the device tree.
      
      This depends on of_graph_get_port_by_id and uses the OF graph to
      link the optional DRM panel to the LDB lvds-channel. The output
      port number is 1 on devices without the 4-port input multiplexer
      (i.MX5) and 4 on devices with the mux (i.MX6).
      
      Before:
      
      	ldb {
      		...
      
      		lvds-channel@0 {
      			...
      
      			display-timings {
      				native-timing = <&timing1>;
      				timing1: etm0700g0dh6 {
      					hactive = <800>;
      					vactive = <480>;
      					clock-frequency = <33260000>;
      					hsync-len = <128>;
      					hback-porch = <88>;
      					hfront-porch = <40>;
      					vsync-len = <2>;
      					vback-porch = <33>;
      					vfront-porch = <10>;
      					hsync-active = <0>;
      					vsync-active = <0>;
      					...
      				};
      			};
      			...
      		};
      	};
      
      After:
      	ldb {
      		...
      
      		lvds-channel@0 {
      			...
      
      			port@4 {
      				reg = <4>;
      
      				lvds_out: endpoint {
      					remote_endpoint = <&panel_in>;
      				};
      			};
      		};
      	};
      
      	panel {
      		compatible = "edt,etm0700g0dh6", "simple-panel";
      		...
      
      		port {
      			panel_in: endpoint {
      				remote-endpoint = <&lvds_out>;
      			};
      		};
      	};
      
      [Fixed build error due to missing select on DRM_PANEL --rmk]
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
      751e2676
    • P
      drm/imx: consolidate bus format variable names · 2872c807
      Philipp Zabel 提交于
      This patch consolidates the different interface_pix_fmt, pixel_fmt, pix_fmt,
      and pixfmt variables to a common name "bus_format" wherever they describe the
      pixel format on the bus between display controller and encoder hardware.
      At the same time, it renames imx_drm_panel_format to imx_drm_set_bus_format.
      Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
      Tested-by: NEmil Renner Berthing <kernel@esmil.dk>
      2872c807
    • P
      drm/imx: switch to use media bus formats · a7c6e76f
      Philipp Zabel 提交于
      imx-drm internally misused the V4L2_PIX_FMT constants, which are supposed to
      describe the pixel format of frame buffers in memory, to describe the pixel
      format on the bus between the display controller and the encoder hardware.
      Now that MEDIA_BUS_FMT constants are available to drm drivers, use those
      instead.
      Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
      Tested-by: NEmil Renner Berthing <kernel@esmil.dk>
      a7c6e76f
  14. 24 2月, 2015 1 次提交
  15. 08 1月, 2015 1 次提交
  16. 07 1月, 2015 1 次提交
  17. 26 11月, 2014 1 次提交
    • P
      drm: imx: Move imx-drm driver out of staging · 6556f7f8
      Philipp Zabel 提交于
      The imx-drm driver was put into staging mostly for the following reasons,
      all of which have been addressed or superseded:
       - convert the irq driver to use linear irq domains
       - work out the device tree bindings, this lead to the common of_graph
         bindings being used
       - factor out common helper functions, this mostly resulted in the
         component framework and drm of_graph helpers.
      
      Before adding new fixes, and certainly before adding new features,
      move it into its proper place below drivers/gpu/drm.
      Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
      Signed-off-by: NDave Airlie <airlied@redhat.com>
      6556f7f8
  18. 06 11月, 2014 1 次提交
  19. 20 10月, 2014 1 次提交
  20. 09 9月, 2014 1 次提交
    • R
      imx-drm: imx-ldb: fix NULL pointer in imx_ldb_unbind() · d9fdb9fb
      Russell King 提交于
      When trying to unbind imx-drm, the following oops was observed from
      the imx-ldb driver:
      
      Unable to handle kernel NULL pointer dereference at virtual address 0000001c
      pgd = de954000
      [0000001c] *pgd=2e92c831, *pte=00000000, *ppte=00000000
      Internal error: Oops: 17 [#1] SMP ARM
      Modules linked in: bnep rfcomm bluetooth nfsd exportfs hid_cypress brcmfmac brcmutil snd_soc_fsl_ssi snd_soc_fsl_spdif imx_pcm_fiq imx_pcm_dma imx_ldb(C) imx_thermal imx_sdma imx2_wdt snd_soc_sgtl5000 snd_soc_imx_sgtl5000 snd_soc_imx_spdif snd_soc_imx_audmux
      CPU: 1 PID: 1228 Comm: bash Tainted: G         C    3.16.0-rc2+ #1229
      task: ea378d80 ti: de948000 task.ti: de948000
      PC is at imx_ldb_unbind+0x1c/0x58 [imx_ldb]
      LR is at component_unbind+0x38/0x70
      pc : [<bf025068>]    lr : [<c0353108>]    psr: 200f0013
      sp : de949da8  ip : de949dc0  fp : de949dbc
      r10: e9a44b0c  r9 : 00000000  r8 : de949f78
      r7 : 00000012  r6 : e9b3f400  r5 : e9b133b8  r4 : e9b13010
      r3 : 00000000  r2 : e9b3f400  r1 : ea9a0210  r0 : e9b13020
      Flags: nzCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment user
      Control: 10c53c7d  Table: 2e95404a  DAC: 00000015
      Process bash (pid: 1228, stack limit = 0xde948240)
      Stack: (0xde949da8 to 0xde94a000)
      ...
      Backtrace:
      [<bf02504c>] (imx_ldb_unbind [imx_ldb]) from [<c0353108>] (component_unbind+0x38/0x70)
      [<c03530d0>] (component_unbind) from [<c03531d4>] (component_unbind_all+0x94/0xc8)
      [<c0353140>] (component_unbind_all) from [<c04bc224>] (imx_drm_driver_unload+0x34/0x4c)
      [<c04bc1f0>] (imx_drm_driver_unload) from [<c03394a4>] (drm_dev_unregister+0x2c/0xa0)
      [<c0339478>] (drm_dev_unregister) from [<c0339f8c>] (drm_put_dev+0x30/0x6c)
      [<c0339f5c>] (drm_put_dev) from [<c04bc1cc>] (imx_drm_unbind+0x14/0x18)
      [<c04bc1b8>] (imx_drm_unbind) from [<c03530b4>] (component_master_del+0xbc/0xd8)
      ...
      Code: e5904058 e2840010 e2845fea e59430a0 (e593301c)
      ---[ end trace 4f211c6dbbcd4963 ]---
      
      This is caused by only having one channel out of the pair configured in
      DT; the second channel remains uninitialised, but upon unbind, the
      driver attempts to clean up both, thereby dereferencing a NULL pointer.
      Avoid this by checking that the second channel is initialised.
      
      Fixes: 1b3f7675 ("imx-drm: initialise drm components directly")
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      d9fdb9fb
  21. 22 4月, 2014 1 次提交
    • A
      drm: make mode_valid callback optional · f9b0e251
      Andrzej Hajda 提交于
      Many drm connectors do not need mode validation.
      The patch makes this callback optional and removes dumb implementations.
      
      v2: Rebase:
      - imx move to a shared (but still dummy) ->mode_valid implementation.
      - probe helpers have been extracted to drm_probe_helper.c
      
      Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> (v1)
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      f9b0e251
  22. 19 3月, 2014 1 次提交
  23. 13 3月, 2014 1 次提交
    • D
      drm/kms: rip out drm_mode_connector_detach_encoder · 69fa5293
      Daniel Vetter 提交于
      It's only used by imx, and that one gets it wrong - there's no need
      to deteach the encoder before removing it.
      
      And really, neither current drm modesetting code nor all the userspace
      we have can handle dynamic changes in the set of possible encoders for
      a given connector. So let's just remove this before someone starts
      doing something really nasty with it.
      
      As a plus, one less kerneldoc comment to write.
      
      Cc: Sascha Hauer <s.hauer@pengutronix.de>
      Cc: Russell King <rmk+kernel@arm.linux.org.uk>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Reviewed-by: NAlex Deucher <alexander.deucher@amd.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      69fa5293
  24. 08 3月, 2014 1 次提交
    • P
      staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs · 655b43cc
      Philipp Zabel 提交于
      This patch adds support to find the involved components connected to
      the IPU display interface ports using the OF graph bindings documented
      in Documentation/devicetree/bindings/media/video-interfaces.txt.
      It makes use of the of_graph (formerly v4l2_of) parsing helpers and
      thus depends on the patch that moves those out to drivers/of.
      
      Each display interface needs to have an associated port node in the
      device tree. We can associate this node with the crtc platform device
      and use it to find the crtc corresponding to a given port node instead
      of using a combination of parent device node and id number, as before.
      
      Explicitly converting the void* cookie to the port device tree node
      allows to get rid of the ipu_id and di_id fields. The multiplexer
      setting on i.MX6 now can be obtained from the port id (reg property)
      in the device tree.
      
      The imx-drm node now needs a ports property that contains phandles
      to each of the IPU display interface port nodes. From there, all
      attached encoders are scanned and enabled encoders are added to a
      waiting list.
      The bind order makes sure that once all components are probed, crtcs
      are bound before encoders, so that imx_drm_encoder_parse_of can be
      called from the encoder bind callbacks.
      
      For parsing the OF graph, temporary copies of the V4L2 OF graph
      helpers are used, that can be removed again once those are available
      at a generic place.
      Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      655b43cc
  25. 01 3月, 2014 1 次提交
  26. 28 2月, 2014 1 次提交