1. 28 10月, 2010 6 次提交
  2. 27 10月, 2010 4 次提交
  3. 26 10月, 2010 20 次提交
    • R
      pch_can: depends on PCI · 10d8c463
      Randy Dunlap 提交于
      Fix pch_can build when CONFIG_PCI is not enabled.  It uses pci interfaces
      and data structures, so it should depend on PCI.
      
      drivers/net/can/pch_can.c:1044: error: implicit declaration of function 'pci_enable_msi'
      drivers/net/can/pch_can.c:1079: error: implicit declaration of function 'pci_disable_msi'
      Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      10d8c463
    • D
      tms380tr: Use mdelay() in tms380tr_wait(). · 5202e173
      David S. Miller 提交于
      This driver tries to do up to half-second udelay()
      calls, which overflows on x86-64.
      Reported-by: NAndi Kleen <andi@firstfloor.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      5202e173
    • E
      mlx4_en: Fix out of bounds array access · 0926f910
      Eli Cohen 提交于
      When searching for a free entry in either mlx4_register_vlan() or
      mlx4_register_mac(), and there is no free entry, the loop terminates without
      updating the local variable free thus causing out of array bounds access. Fix
      this by adding a proper check outside the loop.
      Signed-off-by: NEli Cohen <eli@mellanox.co.il>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      0926f910
    • J
      macb: Don't re-enable interrupts while in polling mode · b336369c
      Joshua Hoke 提交于
      On a busy network, the macb driver could get stuck in the interrupt
      handler, quickly triggering the watchdog, due to a confluence of
      factors:
      
       1. macb_poll re-enables interrupts unconditionally, even when it will
          be called again because it exhausted its rx budget
      
       2. macb_interrupt only disables interrupts after scheduling
          macb_poll, but scheduling fails when macb_poll is already scheduled
          because it didn't call napi_complete
      
       3. macb_interrupt loops until the interrupt status register is clear,
          which will never happen in this case if the driver doesn't disable
          the RX interrupt
      
      Since macb_interrupt runs in interrupt context, this effectively locks
      up the machine, triggering the hardware watchdog.
      
      This issue was readily reproducible on a flooded network with a
      modified 2.6.27.48 kernel. The same problem appears to still be in the
      2.6.36-rc8 driver code, so I am submitting this patch against that
      version. I have not tested this version of the patch except to make
      sure the kernel compiles.
      Signed-off-by: NJoshua Hoke <joshua.hoke@sixnet.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b336369c
    • S
      be2net: Fix CSO for UDP packets · c6ce2f4b
      Somnath Kotur 提交于
      We're setting skb->ip_summed to CHECKSUM_NONE for all non-TCP pkts, making the stack
      recompute checksum.This is a bug for UDP pkts for which cso must be used.
      Signed-off-by: NSomnath Kotur <somnath.kotur@emulex.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c6ce2f4b
    • S
      be2net: Call netif_carier_off() after register_netdev() · 63a76944
      Somnath Kotur 提交于
      Calling netif_carrier_off before register_netdev was causing the network interface
      to miss a linkwatch pending event leading to  an inconsistent state if the link
      is not up when interface is initialized.This is now invoked after register_netdev.
      Signed-off-by: NSomnath Kotur <somnath.kotur@emulex.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      63a76944
    • D
      cxgb3: fix device opening error path · 18edc84c
      Divy Le Ray 提交于
      Only negative return from bind_qsets() should be considered an error and
      propagated.
      It fixes an issue reported by IBM on P Series platform.
      Signed-off-by: NDivy Le Ray <divy@chelsio.com>
      Tested-by: NNishanth Aravamudan <nacc@us.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      18edc84c
    • D
      iwlwifi: quiet a noisy printk · 822395b5
      Don Fry 提交于
      Timing issues in microcode for some devices can cause a compressed BA to
      be sent to the driver prior to returning any a-MPDU notification.
      Traces show RTS-CTS is exchanged and then the timer fires which causes an
      empty BA to be sent which acknowledges nothing.  This results in a noisy
      printk. Only print the message if the bitmap is non-zero.
      Signed-off-by: NDon Fry <donald.h.fry@intel.com>
      Signed-off-by: NWey-Yi Guy <wey-yi.w.guy@intel.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      822395b5
    • F
      ath9k: resume aggregation immediately after a hardware reset · fac6b6a0
      Felix Fietkau 提交于
      Since aggregation is usually triggered by tx completion, a hardware
      reset (because of beacon stuck, tx hang or baseband hang) can
      significantly delay the transmission of the next AMPDU (until the next
      tx completion event).
      Fix this by rescheduling aggregation after such a reset.
      Signed-off-by: NFelix Fietkau <nbd@openwrt.org>
      Cc: stable@kernel.org
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      fac6b6a0
    • C
      carl9170: fix scheduling while atomic · dafeac38
      Christian Lamparter 提交于
      This patch fixes the following mishap:
      
      BUG: scheduling while atomic: wpa_supplicant/4164/0x00000002
      Modules linked in: carl9170 mac80211 [...]
      Pid: 4164, comm: wpa_supplicant Not tainted 2.6.36-wl+ #119
      Call Trace:
       [<c13779a9>] ? schedule+0x349/0x4c0
       [<c13780d6>] ? schedule_timeout+0x106/0x1e0
       [<c1037f50>] ? process_timeout+0x0/0x10
       [<c1377e8d>] ? wait_for_common+0x9d/0x140
       [<c1029110>] ? default_wake_function+0x0/0x10
       [<f80c6080>] ? carl9170_exec_cmd+0xf0/0x250 [carl9170]
       [<f80c695e>] ? carl9170_set_mac_reg+0x5e/0x70 [carl9170]
       [<f80c3f76>] ? carl9170_op_add_interface+0x176/0x310 [carl9170]
       [...]
      
      rcu_read_unlock() call was erroneously placed after the
      sync. function carl9170_mod_virtual_mac.
      Signed-off-by: NChristian Lamparter <chunkeey@googlemail.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      dafeac38
    • R
      b43: N-PHY: fix infinite-loop-typo · 30115c22
      Rafał Miłecki 提交于
      Signed-off-by: NRafał Miłecki <zajec5@gmail.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      30115c22
    • G
      wl1251: fix module names · 04348f27
      Grazvydas Ignotas 提交于
      The wl1251 move accidently renamed wl1251_sdio and wl1251_spi
      modules to just sdio and spi. Restore proper module names.
      Signed-off-by: NGrazvydas Ignotas <notasas@gmail.com>
      Acked-by: NKalle Valo <kvalo@adurom.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      04348f27
    • F
      ath9k: fix handling of rate control probe frames · 0299a50a
      Felix Fietkau 提交于
      The ath9k aggregation code was already checking the rate control probe flag
      to prevent starting an aggregate frame with a sampling rate. What was missing
      was closing an aggregate before adding a probing frame to it.
      Without that, rate control cannot have precise control over probing, which
      delays using faster rates when the channel conditions improve.
      Signed-off-by: NFelix Fietkau <nbd@openwrt.org>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      0299a50a
    • F
      ath9k: fix crash in ath_update_survey_stats · 0845735e
      Felix Fietkau 提交于
      If ah->curchan is uninitialized, the channel index is bogus, which leads
      to invalid memory access when the cycle counters are updated.
      Signed-off-by: NFelix Fietkau <nbd@openwrt.org>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      0845735e
    • S
      ath9k_hw: Fix divide by zero cases in paprd. · 2d3fca18
      Senthil Balasubramanian 提交于
      We are not handling all divide by zero cases in paprd.
      Add additional checks for divide by zero cases in papard.
      
      This patch has fixes intended for kernel 2.6.36.
      
      Cc: stable@kernel.org
      Signed-off-by: NSenthil Balasubramanian <senthilkumar@atheros.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      2d3fca18
    • L
      ath9k_hw: Fix TX carrier leakage for IEEE compliance on AR9003 2.2 · 0dfa6dbb
      Luis R. Rodriguez 提交于
      This updates the initvals for the AR9003 2.2 chipsets. The initvals
      are the initial register values we use for our registers upon hardware
      reset. This synchs up the initvals to match what our latest recommendation
      from our systems engineering team.
      
      The description of changes in this update:
      
              Improves ability to support very strong Rx conditions.
              Enhances DFS support for AP-mode.
              Improves performance of Tx carrier leak calibration.
              Adds support for Japan channel 14 Tx filtering requirements.
              Improves Tx power accuracy.
      
      Impact:
      
              Update required to address degraded throughput at very short range.
              Update required for AP-mode DFS certification.
              Update required to comply to IEEE Tx carrier leak specification.
              May not meet expected +/- 2 dB Tx power accuracy without update.
      
      The most important fix here would be the TX carrier leakage required
      to comply with IEEE 802.11 specifications. The group of changes have
      been tested all together in one release.
      
      References:
      
      	Osprey 2.2 header file ver #33
      
      Checksums:
      
      $ ./initvals -f ar9003-2p2
      0x000000004a488fc7        ar9300_2p2_radio_postamble
      0x0000000046cb1300        ar9300Modes_lowest_ob_db_tx_gain_table_2p2
      0x00000000e912711f        ar9300Modes_fast_clock_2p2
      0x0000000037ac0ee8        ar9300_2p2_radio_core
      0x00000000047a7700        ar9300Common_rx_gain_table_merlin_2p2
      0x0000000003f783bb        ar9300_2p2_mac_postamble
      0x00000000301fc841        ar9300_2p2_soc_postamble
      0x000000005ec8075f        ar9200_merlin_2p2_radio_core
      0x0000000083372ffa        ar9300_2p2_baseband_postamble
      0x00000000c4f59974        ar9300_2p2_baseband_core
      0x00000000e20d2e72        ar9300Modes_high_power_tx_gain_table_2p2
      0x000000007fd55c70        ar9300Modes_high_ob_db_tx_gain_table_2p2
      0x0000000029495000        ar9300Common_rx_gain_table_2p2
      0x0000000042cb1300        ar9300Modes_low_ob_db_tx_gain_table_2p2
      0x00000000c4739cd6        ar9300_2p2_mac_core
      0x000000003521a300        ar9300Common_wo_xlna_rx_gain_table_2p2
      0x00000000a15ccf1b        ar9300_2p2_soc_preamble
      0x0000000029734396        ar9300PciePhy_pll_on_clkreq_disable_L1_2p2
      0x000000002d834396        ar9300PciePhy_clkreq_enable_L1_2p2
      0x0000000029834396        ar9300PciePhy_clkreq_disable_L1_2p2
      
      $ ./initvals -f ar9003-2p2 | sha1sum
      0ceddb5cf66737610fb51f04cf3e9ff71870c7b4  -
      
      Cc: stable@kernel.org
      Cc: Yixiang Li <yixiang.li@atheros.com>
      Cc: Don Breslin <don.breslin@atheros.com>
      Signed-off-by: NLuis R. Rodriguez <lrodriguez@atheros.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      0dfa6dbb
    • C
      carl9170: fix memory leak issue in async cmd macro wrappers · 3d2f2cd0
      Christian Lamparter 提交于
      This patch continues where the previous commit:
      	"carl9170: fix async command buffer leak"
      left off.
      
      Similar to carl9170_reboot/carl9170_powersave, the
      carl9170_async_regwrite* macros would leak the
      temporary command buffer, if __carl9170_exec_cmd
      fails to upload the command to the device.
      Signed-off-by: NChristian Lamparter <chunkeey@googlemail.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      3d2f2cd0
    • C
      carl9170: fix async command buffer leak · cae7f953
      Christian Lamparter 提交于
      If __carl9170_exec_cmd fails to upload an asynchronous
      command to the device, the functions: carl9170_reboot
      and carl9170_powersave will leak the temporary command
      assembly buffer.
      Signed-off-by: NChristian Lamparter <chunkeey@googlemail.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      cae7f953
    • B
      ath5k: Properly initialize ath_common->cc_lock. · 9192f715
      Ben Greear 提交于
      Otherwise, lockdep splats, at the least:
      
      INFO: trying to register non-static key.
      the code is fine but needs lockdep annotation.
      turning off the locking correctness validator.
      Pid: 0, comm: swapper Not tainted 2.6.36-rc8-wl+ #32
      Call Trace:
       [<c075d940>] ? printk+0xf/0x17
       [<c045507a>] register_lock_class+0x5a/0x29e
       [<c0456af5>] __lock_acquire+0xa2/0xb8c
       [<c0455be2>] ? mark_lock+0x1e/0x1de
       [<c041a540>] ? acpi_get_override_irq+0x85/0x8c
       [<c0455536>] ? trace_hardirqs_off+0xb/0xd
       [<c0457639>] lock_acquire+0x5a/0x78
       [<f8126835>] ? ath5k_ani_calibration+0x24/0x52b [ath5k]
       [<c075f6ed>] _raw_spin_lock_bh+0x20/0x2f
       [<f8126835>] ? ath5k_ani_calibration+0x24/0x52b [ath5k]
       [<f8126835>] ath5k_ani_calibration+0x24/0x52b [ath5k]
       [<c0438f99>] ? tasklet_action+0x3b/0xc6
       [<f8123c2b>] ath5k_tasklet_ani+0x18/0x22 [ath5k]
       [<c0438fd1>] tasklet_action+0x73/0xc6
       [<c043945f>] __do_softirq+0x86/0x111
       [<c0439520>] do_softirq+0x36/0x5a
       [<c0439659>] irq_exit+0x35/0x69
       [<c0403fb9>] do_IRQ+0x86/0x9a
       [<c04034ee>] common_interrupt+0x2e/0x40
       [<c045007b>] ? do_adjtimex+0x223/0x55e
       [<c0408245>] ? mwait_idle+0x5c/0x6c
       [<c040227f>] cpu_idle+0x4e/0x6b
       [<c074b6e9>] rest_init+0x8d/0x92
       [<c09758ea>] start_kernel+0x320/0x325
       [<c09750d0>] i386_start_kernel+0xd0/0xd7
      Signed-off-by: NBen Greear <greearb@candelatech.com>
      Acked-by: NBruno Randolf <br1@einfach.org>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      9192f715
    • B
      ath9k: Properly initialize ath_common->cc_lock. · 20b25744
      Ben Greear 提交于
      Otherwise, lockdep splats, at the least:
      
      INFO: trying to register non-static key.
      the code is fine but needs lockdep annotation.
      turning off the locking correctness validator.
      Pid: 2240, comm: ip Not tainted 2.6.36-rc8-wl+ #32
      Call Trace:
       [<c075d940>] ? printk+0xf/0x17
       [<c045507a>] register_lock_class+0x5a/0x29e
       [<c0455be2>] ? mark_lock+0x1e/0x1de
       [<c0456af5>] __lock_acquire+0xa2/0xb8c
       [<c0455be2>] ? mark_lock+0x1e/0x1de
       [<c0457639>] lock_acquire+0x5a/0x78
       [<f8c5115b>] ? ath9k_config+0x274/0x3d8 [ath9k]
       [<c075f602>] _raw_spin_lock_irqsave+0x2f/0x3f
       [<f8c5115b>] ? ath9k_config+0x274/0x3d8 [ath9k]
       [<f8c5115b>] ath9k_config+0x274/0x3d8 [ath9k]
       [<f8c0ba2e>] ieee80211_hw_config+0x11b/0x125 [mac80211]
       [<f8c17edf>] ieee80211_do_open+0x3c5/0x466 [mac80211]
       [<f8c171d6>] ? ieee80211_check_concurrent_iface+0x21/0x13a [mac80211]
       [<f8c17fdb>] ieee80211_open+0x5b/0x5e [mac80211]
       [<c06ce76b>] __dev_open+0x80/0xae
       [<c06cc99b>] __dev_change_flags+0xa0/0x115
       [<c06ce6bf>] dev_change_flags+0x13/0x3f
       [<c06d7e78>] do_setlink+0x23a/0x51b
       [<c0455037>] ? register_lock_class+0x17/0x29e
       [<c06d847c>] rtnl_newlink+0x269/0x431
       [<c06d8291>] ? rtnl_newlink+0x7e/0x431
       [<c0455be2>] ? mark_lock+0x1e/0x1de
       [<c0455de9>] ? mark_held_locks+0x47/0x5f
       [<c075ebcf>] ? __mutex_lock_common+0x2bb/0x2d6
       [<c0456045>] ? trace_hardirqs_on_caller+0x104/0x125
       [<c075ebe0>] ? __mutex_lock_common+0x2cc/0x2d6
       [<c06d8213>] ? rtnl_newlink+0x0/0x431
       [<c06d79e2>] rtnetlink_rcv_msg+0x182/0x198
       [<c06d7860>] ? rtnetlink_rcv_msg+0x0/0x198
       [<c06e503c>] netlink_rcv_skb+0x30/0x77
       [<c06d7859>] rtnetlink_rcv+0x1b/0x22
       [<c06e4e77>] netlink_unicast+0xbe/0x119
       [<c06e5a15>] netlink_sendmsg+0x234/0x24c
       [<c06bf93a>] __sock_sendmsg+0x51/0x5a
       [<c06bfba4>] sock_sendmsg+0x93/0xa7
       [<c04968cf>] ? might_fault+0x47/0x81
       [<c0496904>] ? might_fault+0x7c/0x81
       [<c06c7904>] ? copy_from_user+0x8/0xa
       [<c06c7c2d>] ? verify_iovec+0x3e/0x6d
       [<c06bfd8c>] sys_sendmsg+0x149/0x193
       [<c0455037>] ? register_lock_class+0x17/0x29e
       [<c0455be2>] ? mark_lock+0x1e/0x1de
       [<c0498d7a>] ? __do_fault+0x1fc/0x3a5
       [<c048690a>] ? unlock_page+0x40/0x43
       [<c0498ef7>] ? __do_fault+0x379/0x3a5
       [<c04576dd>] ? lock_release_non_nested+0x86/0x1d8
       [<c04968cf>] ? might_fault+0x47/0x81
       [<c04968cf>] ? might_fault+0x47/0x81
       [<c06c148b>] sys_socketcall+0x15e/0x1a5
       [<c0402f1c>] sysenter_do_call+0x12/0x38
      Signed-off-by: NBen Greear <greearb@candelatech.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      20b25744
  4. 25 10月, 2010 10 次提交