1. 04 1月, 2014 1 次提交
  2. 06 12月, 2013 1 次提交
  3. 12 11月, 2013 1 次提交
    • M
      rtlwifi: Fix endian error in extracting packet type · 0c5d63f0
      Mark Cave-Ayland 提交于
      All of the rtlwifi drivers have an error in the routine that tests if
      the data is "special". If it is, the subsequant transmission will be
      at the lowest rate to enhance reliability. The 16-bit quantity is
      big-endian, but was being extracted in native CPU mode. One of the
      effects of this bug is to inhibit association under some conditions
      as the TX rate is too high.
      
      Based on suggestions by Joe Perches, the entire routine is rewritten.
      
      One of the local headers contained duplicates of some of the ETH_P_XXX
      definitions. These are deleted.
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
      Cc: Stable <stable@vger.kernel.org> [2.6.38+]
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      0c5d63f0
  4. 04 10月, 2013 1 次提交
  5. 04 9月, 2013 1 次提交
    • J
      drivers/net: Convert uses of compare_ether_addr to ether_addr_equal · 7367d0b5
      Joe Perches 提交于
      Use the new bool function ether_addr_equal to add
      some clarity and reduce the likelihood for misuse
      of compare_ether_addr for sorting.
      
      Done via cocci script: (and a little typing)
      
      $ cat compare_ether_addr.cocci
      @@
      expression a,b;
      @@
      -	!compare_ether_addr(a, b)
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	compare_ether_addr(a, b)
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!ether_addr_equal(a, b) == 0
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!ether_addr_equal(a, b) != 0
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	ether_addr_equal(a, b) == 0
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	ether_addr_equal(a, b) != 0
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!!ether_addr_equal(a, b)
      +	ether_addr_equal(a, b)
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      7367d0b5
  6. 19 7月, 2013 1 次提交
    • L
      rtlwifi: Fix build errors for unusual cases · 6f334c2b
      Larry Finger 提交于
      The present build configuration for the rtlwifi family of drivers will
      fail under two known conditions:
      
      (1) If rtlwifi is selected without selecting any of the dependent drivers,
          there are errors in the build.
      (2) If the PCI drivers are built into the kernel and the USB drivers are modules,
          or vice versa, there are missing globals.
      
      The first condition is fixed by never building rtlwifi unless at least one
      of the device drivers is selected. The second failure is fixed by splitting
      the PCI and USB codes out of rtlwifi, and creating their own mini drivers.
      If the drivers that use them are modules, they will also be modules.
      
      Although a number of files are touched by this patch, only Makefile and Kconfig
      have undergone significant changes. The only modifications to the other files
      were to export entry points needed by the new rtl_pci and rtl_usb units, or to
      rename two variables that had names that were likely to cause namespace collisions.
      
      Reported-by: Fengguang Wu <fengguang.wu@intel.com>  [Condition 1]
      Reported-by: Ben Hutchings <bhutchings@solarflare.com> [Condition 2]
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Cc: Ben Hutchings <bhutchings@solarflare.com>
      Cc: Fengguang Wu <fengguang.wu@intel.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      6f334c2b
  7. 04 7月, 2013 1 次提交
  8. 03 6月, 2013 1 次提交
  9. 02 4月, 2013 3 次提交
  10. 26 3月, 2013 1 次提交
  11. 15 2月, 2013 1 次提交
    • J
      mac80211: stop toggling IEEE80211_HT_CAP_SUP_WIDTH_20_40 · e1a0c6b3
      Johannes Berg 提交于
      For VHT, many more bandwidth changes are possible. As a first
      step, stop toggling the IEEE80211_HT_CAP_SUP_WIDTH_20_40 flag
      in the HT capabilities and instead introduce a bandwidth field
      indicating the currently usable bandwidth to transmit to the
      station. Of course, make all drivers use it.
      
      To achieve this, make ieee80211_ht_cap_ie_to_sta_ht_cap() get
      the station as an argument, rather than the new capabilities,
      so it can set up the new bandwidth field.
      
      If the station is a VHT station and VHT bandwidth is in use,
      also set the bandwidth accordingly.
      
      Doing this allows us to get rid of the supports_40mhz flag as
      the HT capabilities now reflect the true capability instead of
      the current setting.
      
      While at it, also fix ieee80211_ht_cap_ie_to_sta_ht_cap() to not
      ignore HT cap overrides when MCS TX isn't supported (not that it
      really happens...)
      Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
      e1a0c6b3
  12. 05 2月, 2013 1 次提交
  13. 15 11月, 2012 1 次提交
  14. 31 7月, 2012 1 次提交
  15. 13 7月, 2012 1 次提交
  16. 07 6月, 2012 1 次提交
    • J
      wireless: Remove casts to same type · 2c208890
      Joe Perches 提交于
      Adding casts of objects to the same type is unnecessary
      and confusing for a human reader.
      
      For example, this cast:
      
              int y;
              int *p = (int *)&y;
      
      I used the coccinelle script below to find and remove these
      unnecessary casts.  I manually removed the conversions this
      script produces of casts with __force, __iomem and __user.
      
      @@
      type T;
      T *p;
      @@
      
      -       (T *)p
      +       p
      
      Neatened the mwifiex_deauthenticate_infra function which
      was doing odd things with array pointers and not using
      is_zero_ether_addr.
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2c208890
  17. 11 5月, 2012 1 次提交
    • J
      drivers/net: Convert compare_ether_addr to ether_addr_equal · 2e42e474
      Joe Perches 提交于
      Use the new bool function ether_addr_equal to add
      some clarity and reduce the likelihood for misuse
      of compare_ether_addr for sorting.
      
      Done via cocci script:
      
      $ cat compare_ether_addr.cocci
      @@
      expression a,b;
      @@
      -	!compare_ether_addr(a, b)
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	compare_ether_addr(a, b)
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!ether_addr_equal(a, b) == 0
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!ether_addr_equal(a, b) != 0
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	ether_addr_equal(a, b) == 0
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	ether_addr_equal(a, b) != 0
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!!ether_addr_equal(a, b)
      +	ether_addr_equal(a, b)
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2e42e474
  18. 10 4月, 2012 1 次提交
  19. 23 2月, 2012 1 次提交
  20. 31 1月, 2012 2 次提交
  21. 28 1月, 2012 1 次提交
  22. 25 1月, 2012 2 次提交
  23. 20 12月, 2011 2 次提交
    • R
      net: fix assignment of 0/1 to bool variables. · 3db1cd5c
      Rusty Russell 提交于
      DaveM said:
         Please, this kind of stuff rots forever and not using bool properly
         drives me crazy.
      
      Joe Perches <joe@perches.com> gave me the spatch script:
      
      	@@
      	bool b;
      	@@
      	-b = 0
      	+b = false
      	@@
      	bool b;
      	@@
      	-b = 1
      	+b = true
      
      I merely installed coccinelle, read the documentation and took credit.
      Signed-off-by: NRusty Russell <rusty@rustcorp.com.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      3db1cd5c
    • L
      rtlwifi: Fix locking problem introduces with commit 6539306b · b9116b9a
      Larry Finger 提交于
      When I tested commit 6539306b, I did not notice that loading an out-of-tree
      module turns off lockdep testing in kernel 3.2. For that reason, I missed
      the kernel WARNING shown below:
      
      The solution fixes the warning by partially reverting commit 6539306b.
      
      [   84.168146] ------------[ cut here ]------------
      [   84.168155] WARNING: at kernel/mutex.c:198 mutex_lock_nested+0x309/0x310()
      [   84.168158] Hardware name: HP Pavilion dv2700 Notebook PC
      [   84.168161] Modules linked in: nfs lockd auth_rpcgss nfs_acl sunrpc af_packet cpufreq_conservative cpufreq_userspace cpufreq_powersave powernow_k8 mperf e
      xt3 jbd ide_cd_mod cdrom snd_hda_codec_conexant arc4 rtl8192ce ide_pci_generic rtl8192c_common rtlwifi snd_hda_intel mac80211 snd_hda_codec snd_pcm snd_timer
       amd74xx ide_core cfg80211 k8temp snd joydev soundcore hwmon battery forcedeth i2c_nforce2 sg rfkill ac serio_raw snd_page_alloc button video i2c_core ipv6 a
      utofs4 ext4 mbcache jbd2 crc16 sd_mod ahci ohci_hcd libahci libata scsi_mod ehci_hcd usbcore usb_common fan processor thermal
      [   84.168231] Pid: 1218, comm: kworker/u:2 Not tainted 3.2.0-rc5-wl+ #155
      [   84.168234] Call Trace:
      [   84.168240]  [<ffffffff81048aaa>] warn_slowpath_common+0x7a/0xb0
      [   84.168245]  [<ffffffff81048af5>] warn_slowpath_null+0x15/0x20
      [   84.168249]  [<ffffffff813811f9>] mutex_lock_nested+0x309/0x310
      [   84.168269]  [<ffffffffa00793f9>] ? rtl_ips_nic_on+0x49/0xb0 [rtlwifi]
      [   84.168277]  [<ffffffffa00793f9>] rtl_ips_nic_on+0x49/0xb0 [rtlwifi]
      [   84.168284]  [<ffffffffa007ab85>] rtl_pci_tx+0x1b5/0x560 [rtlwifi]
      [   84.168291]  [<ffffffffa007635a>] rtl_op_tx+0x9a/0xa0 [rtlwifi]
      [   84.168359]  [<ffffffffa043cf51>] __ieee80211_tx+0x181/0x2b0 [mac80211]
      [   84.168375]  [<ffffffffa043ef06>] ieee80211_tx+0xf6/0x120 [mac80211]
      [   84.168391]  [<ffffffffa043ee49>] ? ieee80211_tx+0x39/0x120 [mac80211]
      [   84.168408]  [<ffffffffa043f80b>] ieee80211_xmit+0xdb/0x100 [mac80211]
      [   84.168425]  [<ffffffffa043f730>] ? ieee80211_skb_resize.isra.26+0xb0/0xb0 [mac80211]
      [   84.168441]  [<ffffffffa0440b2a>] ieee80211_tx_skb_tid+0x5a/0x70 [mac80211]
      [   84.168458]  [<ffffffffa0443da2>] ieee80211_send_auth+0x152/0x1b0 [mac80211]
      [   84.168474]  [<ffffffffa042e169>] ieee80211_work_work+0x1049/0x1860 [mac80211]
      [   84.168489]  [<ffffffffa042d120>] ? free_work+0x20/0x20 [mac80211]
      [   84.168504]  [<ffffffffa042d120>] ? free_work+0x20/0x20 [mac80211]
      [   84.168510]  [<ffffffff81065ffc>] process_one_work+0x17c/0x530
      [   84.168514]  [<ffffffff81065f92>] ? process_one_work+0x112/0x530
      [   84.168519]  [<ffffffff81066994>] worker_thread+0x164/0x350
      [   84.168524]  [<ffffffff8108420d>] ? trace_hardirqs_on+0xd/0x10
      [   84.168528]  [<ffffffff81066830>] ? manage_workers.isra.28+0x220/0x220
      [   84.168533]  [<ffffffff8106bc17>] kthread+0x87/0x90
      [   84.168539]  [<ffffffff813854b4>] kernel_thread_helper+0x4/0x10
      [   84.168543]  [<ffffffff81382bdd>] ? retint_restore_args+0xe/0xe
      [   84.168547]  [<ffffffff8106bb90>] ? __init_kthread_worker+0x70/0x70
      [   84.168552]  [<ffffffff813854b0>] ? gs_change+0xb/0xb
      [   84.168554] ---[ end trace f25a4fdc768c028f ]---
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Cc: Stanislaw Gruska <sgruszka@redhat.com>
      Cc: Chaoming Li <chaoming_li@realsil.com.cn>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      b9116b9a
  24. 14 12月, 2011 1 次提交
  25. 22 11月, 2011 1 次提交
  26. 01 11月, 2011 1 次提交
  27. 15 10月, 2011 1 次提交
  28. 25 8月, 2011 1 次提交
  29. 22 7月, 2011 1 次提交
  30. 21 7月, 2011 1 次提交
  31. 21 6月, 2011 1 次提交
  32. 02 6月, 2011 1 次提交
    • L
      rtlwifi: Fix warnings from gcc 4.6.0 · 19086fce
      Larry Finger 提交于
      gcc 4.6.0 warnings for rtlwifi:
      
        CC [M]  drivers/net/wireless/rtlwifi/base.o
      drivers/net/wireless/rtlwifi/base.c: In function ‘rtl_tx_agg_stop’:
      drivers/net/wireless/rtlwifi/base.c:891:23: warning: variable ‘tid_data’ set but not used [-Wunused-but-set-variable]
      drivers/net/wireless/rtlwifi/base.c: In function ‘rtl_tx_agg_oper’:
      drivers/net/wireless/rtlwifi/base.c:921:23: warning: variable ‘tid_data’ set but not used [-Wunused-but-set-variable]
        CC [M]  drivers/net/wireless/rtlwifi/efuse.o
      drivers/net/wireless/rtlwifi/efuse.c: In function ‘efuse_pg_packet_write’:
      drivers/net/wireless/rtlwifi/efuse.c:928:24: warning: variable ‘dataempty’ set but not used [-Wunused-but-set-variable]
      drivers/net/wireless/rtlwifi/efuse.c: In function ‘efuse_get_current_size’:
      drivers/net/wireless/rtlwifi/efuse.c:1179:5: warning: variable ‘hoffset’ set but not used [-Wunused-but-set-variable]
        CC [M]  drivers/net/wireless/rtlwifi/ps.o
      drivers/net/wireless/rtlwifi/ps.c: In function ‘rtl_ps_set_rf_state’:
      drivers/net/wireless/rtlwifi/ps.c:85:19: warning: variable ‘rtstate’ set but not used [-Wunused-but-set-variable]
        CC [M]  drivers/net/wireless/rtlwifi/regd.o
      drivers/net/wireless/rtlwifi/regd.c: In function ‘_rtl_dump_channel_map’:
      drivers/net/wireless/rtlwifi/regd.c:310:28: warning: variable ‘ch’ set but not used [-Wunused-but-set-variable]
        CC [M]  drivers/net/wireless/rtlwifi/usb.o
      drivers/net/wireless/rtlwifi/usb.c: In function ‘_rtl_usb_transmit’:
      drivers/net/wireless/rtlwifi/usb.c:826:21: warning: variable ‘urb_list’ set but not used [-Wunused-but-set-variable]
      drivers/net/wireless/rtlwifi/usb.c:825:23: warning: variable ‘skb_list’ set but not used [-Wunused-but-set-variable]
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      19086fce
  33. 27 4月, 2011 3 次提交