1. 24 1月, 2017 3 次提交
  2. 20 1月, 2017 11 次提交
  3. 19 1月, 2017 2 次提交
    • J
      HID: wacom: Fix sibling detection regression · a9ce7856
      Jason Gerecke 提交于
      Commit 345857bb ("HID: wacom: generic: Add support for sensor offsets") included
      a change to the operation and location of the call to 'wacom_add_shared_data'
      in 'wacom_parse_and_register'. The modifications included moving it higher up
      so that it would occur before the call to 'wacom_retrieve_hid_descriptor'. This
      was done to prevent a crash that would have occured when the report containing
      tablet offsets was fed into the driver with 'wacom_hid_report_raw_event'
      (specifically: the various 'wacom_wac_*_report' functions were written with the
      assumption that they would only be called once tablet setup had completed;
      'wacom_wac_pen_report' in particular dereferences 'shared' which wasn't yet
      allocated).
      
      Moving the call to 'wacom_add_shared_data' effectively prevented the crash but
      also broke the sibiling detection code which assumes that the HID descriptor
      has been read and the various device_type flags set.
      
      To fix this situation, we restore the original 'wacom_add_shared_data'
      operation and location and instead implement an alternative change that can
      also prevent the crash. Specifically, we notice that the report functions
      mentioned above expect to be called only for input reports.  By adding a check,
      we can prevent feature reports (such as the offset report) from
      causing trouble.
      
      Fixes: 345857bb ("HID: wacom: generic: Add support for sensor offsets")
      Signed-off-by: NJason Gerecke <jason.gerecke@wacom.com>
      Tested-by: NPing Cheng <pingc@wacom.com>
      Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      a9ce7856
    • L
      gpio: provide lockdep keys for nested/unnested irqchips · 739e6f59
      Linus Walleij 提交于
      The helper function for adding a GPIO chip compiles in a lockdep
      key for debugging, the same key is needed for nested chips as
      well.
      
      The macro construction is unreadable, replace this with two
      static inlines instead.
      
      The _gpiochip_irqchip_add prefixed function is not helpful,
      rename it with gpiochip_irqchip_add_key() that tell us what the
      function is actually doing.
      
      Fixes: d245b3f9 ("gpio: simplify adding threaded interrupts")
      Cc: Roger Quadros <rogerq@ti.com>
      Reported-by: NClemens Gruber <clemens.gruber@pqgruber.com>
      Reported-by: NRoger Quadros <rogerq@ti.com>
      Reported-by: NGrygorii Strashko <grygorii.strashko@ti.com>
      Tested-by: NClemens Gruber <clemens.gruber@pqgruber.com>
      Tested-by: NGrygorii Strashko <grygorii.strashko@ti.com>
      Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
      739e6f59
  4. 18 1月, 2017 24 次提交