Placed comments to register writes before the function calls to
eliminate long strings and make code more readable.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Eliminated code duplication when searching for a display.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The patch removes spaces before tabs so that checkpatch.pl is content.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Removed unnecessary line continuations in several lines.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Split module description strings are merged for searchability.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Indentation with spaces fixed.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Put spaces around assignment operators for readability.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Split long function declarations, function calls, comments etc.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fix coding style issue "Missing a blank line after declarations"
detected by checkpatch.pl in visorchipset.c
Signed-off-by: NAlessandro Parini <alessandro.parini@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fix coding style issue "braces {} are not necessary for single statement blocks"
detected by checkpatch.pl in visorchipset.c
Signed-off-by: NAlessandro Parini <alessandro.parini@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

buf_unalloc is essentially a vme_free_consistent:
1) image[i].kern_buf is never NULL in buf_alloc call
2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Checking for image[minor].resource != NULL is not needed since all
resources are allocated before device is created.

image[minor].users accounting is deleted because it's not being used.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Reorder code so that forward declarations are not needed.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes checkpatch.pl warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: NDogukan Ergun <dogukan.ergun@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove itypes.h that is not needed.
Signed-off-by: NChaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove BOOL_T typedef.
Signed-off-by: NChaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The iochannel.h file no longer needs to include
conttrolvmchannel.h, vbuschannel.h and vmcallinterfaces.h.
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Universe II datasheet defines following address space values
for LM_CTL[16:18]

000=A16
001=A24
010=A32
011,100,101=Reserved
110=User1
111=User2

Mask 5<<16 is not the right one for matching [16:18], instead we should
use 7<<16.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This makes vme_user_llseek ignore all minors that don't have llseek
implementation.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This moves DMA mapping of the first list element to vme_list_add, the
same place where other elements mappings occur. This prevents extra
mapping or over-unmapping in the cases when vme_list_exec is called more
or less than one time respectively.

Also adds dma_mapping_error check.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

DMA lists on tsi148 weren't processed further than the first item
because of the broken logic. This regression was introduced in:

ac1a4f2c "Staging: VME: Ensure TSI148 link list descriptors..."
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The function rtw_mfree_all_stainfo() is just holding the lock,
traversing the list, and then unlocking. It is not doing anything else.
So removed the function and modified the places from where it was called.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

These variables were being set but not used afterwards.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The CONFIGs, the enum and the function declaration was not being
used anywhere.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

is_valid_p2p_probereq is initialized to false and never modified. Code
depending on it is dead code. Remove all of it.
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The is_valid_p2p_probereq is never referenced in the function body.
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Acked-by: NJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The is_valid_p2p_probereq is never referenced in the function body.
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

These are internal functions. Remove their declaration in rtw_mlme_ext.h
and make them static.
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

These are internal functions. Remove their declaration in rtw_mlme_ext.h
and make them static.
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The message handling stored in mlme_sta_tbl and OnAction_tbl are internal and
will be declared static, and their declaration removed from rtw_mlme_ext.h, in
a later commit.

This would break compilation, since they are are referenced before their
definition.

Reorder these functions and the structures that hold them so that symbols are
defined before they are referenced, without the need for forward declarations.

This commit only reorders code, there is no content change.
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fixed all checkpatch.pl ERROR: do not use C99 // comments

Any C99 comments used to comment out code are simply removed.
Also some of the errors occur inside '#if 0' blocks which I
might as well fix since checkpatch.pl caught them but the blocks
themselves should probably be cleaned up later.

Changes since v1: close a comment block
Signed-off-by: NJuston Li <juston.h.li@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch was detected with the help of coccinelle tool.
The redundant comparisons of bool variables are removed in r8192U_dm.c.
Signed-off-by: NHarisangam Sharvari <sharisan@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>