1. 11 9月, 2013 1 次提交
  2. 01 8月, 2013 1 次提交
    • E
      spi/atmel: Fix format specifier warnings · 2de024b7
      Emil Goode 提交于
      This patch fixes the following sparse warnings.
      dma_addr_t can be either u32 or u64 so we should cast to the
      largest type and use the format specifier %llx.
      
      drivers/spi/spi-atmel.c: In function ‘atmel_spi_next_xfer_dma_submit’:
      drivers/spi/spi-atmel.c:631:2: warning:
      	format ‘%x’ expects argument of type ‘unsigned int’,
      	but argument 7 has type ‘dma_addr_t’ [-Wformat]
      drivers/spi/spi-atmel.c:631:2: warning:
      	format ‘%x’ expects argument of type ‘unsigned int’,
      	but argument 9 has type ‘dma_addr_t’ [-Wformat]
      drivers/spi/spi-atmel.c: In function ‘atmel_spi_pdc_next_xfer’:
      drivers/spi/spi-atmel.c:734:3: warning:
      	format ‘%x’ expects argument of type ‘unsigned int’,
      	but argument 7 has type ‘dma_addr_t’ [-Wformat]
      drivers/spi/spi-atmel.c:734:3: warning:
      	format ‘%x’ expects argument of type ‘unsigned int’,
      	but argument 9 has type ‘dma_addr_t’ [-Wformat]
      drivers/spi/spi-atmel.c:773:3: warning:
      	format ‘%x’ expects argument of type ‘unsigned int’,
      	but argument 7 has type ‘dma_addr_t’ [-Wformat]
      drivers/spi/spi-atmel.c:773:3: warning:
      	format ‘%x’ expects argument of type ‘unsigned int’,
      	but argument 9 has type ‘dma_addr_t’ [-Wformat]
      Signed-off-by: NEmil Goode <emilgoode@gmail.com>
      Signed-off-by: NMark Brown <broonie@linaro.org>
      2de024b7
  3. 29 7月, 2013 1 次提交
  4. 17 7月, 2013 1 次提交
  5. 03 6月, 2013 1 次提交
  6. 30 5月, 2013 1 次提交
  7. 02 5月, 2013 1 次提交
  8. 24 4月, 2013 3 次提交
  9. 07 4月, 2013 1 次提交
  10. 01 4月, 2013 4 次提交
  11. 05 2月, 2013 1 次提交
  12. 18 12月, 2012 1 次提交
  13. 08 12月, 2012 1 次提交
  14. 06 11月, 2012 1 次提交
  15. 09 11月, 2011 1 次提交
    • J
      atmel/spi: fix missing probe · 1cb201af
      Jean-Christophe PLAGNIOL-VILLARD 提交于
      Commit 940ab889 "drivercore: Add helper macro for platform_driver boilerplate"
      converted this driver to use module_platform_driver, but due to the use
      of platform_driver_probe(), this resulted in the call to atmel_spi_probe being
      lost. Place the call to this function into the driver structure.
      
      fix section missmatch
      
      atmel_spi_probe is marked __init where it's supposed to be __devinit
      atmel_spi_remove is marked __exit where it's supposed to be __devexit
      Signed-off-by: NJean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
      Cc: Greg Kroah-Hartman <gregkh@suse.de>
      Cc: Grant Likely <grant.likely@secretlab.ca>
      Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
      Acked-by: NNicolas Ferre <nicolas.ferre@atmel.com>
      1cb201af
  16. 25 10月, 2011 1 次提交
  17. 08 8月, 2011 1 次提交
  18. 06 6月, 2011 1 次提交
  19. 19 5月, 2011 1 次提交
  20. 01 12月, 2010 1 次提交
  21. 02 11月, 2010 1 次提交
  22. 16 10月, 2010 1 次提交
  23. 14 10月, 2010 1 次提交
  24. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  25. 17 12月, 2009 2 次提交
  26. 19 6月, 2009 2 次提交
  27. 25 3月, 2009 1 次提交
  28. 16 1月, 2009 1 次提交
  29. 07 1月, 2009 2 次提交
  30. 13 11月, 2008 1 次提交
    • J
      atmel_spi: work-around required for new HW bug in AT91SAM9263 Rev.B SPI controller · 50d7d5bf
      Jean-Christophe Lallemand 提交于
      We're working with an AT91SAM9263 Rev B in our design and I experienced
      some inconsistency in spi-based touchscreen usage between our board and
      the Atmel evaluation kit we have that runs on a Rev A chip.
      
      The data was apparently delayed by 1 byte and got ridiculous data out of
      the touchscreen driver, very strange.  As everything looked normal in
      the spi, touchscreen and dma logs, I contacted the Atmel support and
      they triggered me on a new HW bug that appeared in the Rev B SPI
      controller.
      
      The problem is that the SPI controller on the Rev B needs that the
      software reset is performed two times so that it's performed correctly.
      
      Applying the patch below solves the issue on my Rev B board.  I've tested
      it as well on my Rev A evaluation kit and it has apparently no unwanted
      side effect, things continue to work as expected.
      Signed-off-by: NHaavard Skinnemoen <haavard.skinnemoen@atmel.com>
      Cc: David Brownell <david-b@pacbell.net>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      50d7d5bf
  31. 07 8月, 2008 1 次提交
  32. 05 8月, 2008 1 次提交
    • G
      atmel_spi: fix hang due to missed interrupt · dc329442
      Gerard Kam 提交于
      For some time my at91sam9260 board with JFFS2 on serial flash (m25p80)
      would hang when accessing the serial flash and SPI bus.  Slowing the SPI
      clock down to 9 MHz reduced the occurrence of the hang from "always"
      during boot to a nuisance level that allowed other SW development to
      continue.  Finally had to address this issue when an application stresses
      the I/O to always cause a hang.
      
      Hang seems to be caused by a missed SPI interrupt, so that the task ends
      up waiting forever after calling spi_sync().  The fix has 2 parts.  First
      is to halt the DMA engine before the "current" PDC registers are loaded.
      This ensures that the "next" registers are loaded before the DMA operation
      takes off.  The second part of the fix is a kludge that adds a
      "completion" interrupt in case the ENDRX interrupt for the last segment of
      the DMA chaining operation was missed.
      
      The patch allows the SPI clock for the serial flash to be increased from 9
      MHz to 15 MHz (or more?).  No hangs or SPI overruns were encountered.
      
      Haavard: while this patch does indeed improve things, I still see overruns
      and CRC errors on my NGW100 board when running the DataFlash at 10 MHz.
      However, I think some improvement is better than nothing, so I'm passing
      this on for inclusion in 2.6.27.
      Signed-off-by: NGerard Kam <gerardk5@verizon.net>
      Signed-off-by: NHaavard Skinnemoen <haavard.skinnemoen@atmel.com>
      Cc: David Brownell <david-b@pacbell.net>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      dc329442