1. 22 7月, 2008 1 次提交
  2. 09 2月, 2008 1 次提交
  3. 15 11月, 2007 1 次提交
    • R
      __do_IRQ does not check IRQ_DISABLED when IRQ_PER_CPU is set · c642b839
      Russ Anderson 提交于
      In __do_IRQ(), the normal case is that IRQ_DISABLED is checked and if set
      the handler (handle_IRQ_event()) is not called.
      
      Earlier in __do_IRQ(), if IRQ_PER_CPU is set the code does not check
      IRQ_DISABLED and calls the handler even though IRQ_DISABLED is set.  This
      behavior seems unintentional.
      
      One user encountering this behavior is the CPE handler (in
      arch/ia64/kernel/mca.c).  When the CPE handler encounters too many CPEs
      (such as a solid single bit error), it sets up a polling timer and disables
      the CPE interrupt (to avoid excessive overhead logging the stream of single
      bit errors).  disable_irq_nosync() is called which sets IRQ_DISABLED.  The
      IRQ_PER_CPU flag was previously set (in ia64_mca_late_init()).  The net
      result is the CPE handler gets called even though it is marked disabled.
      
      If the behavior of not checking IRQ_DISABLED when IRQ_PER_CPU is set is
      intentional, it would be worthy of a comment describing the intended
      behavior.  disable_irq_nosync() does call chip->disable() to provide a
      chipset specifiec interface for disabling the interrupt, which avoids this
      issue when used.
      Signed-off-by: NRuss Anderson <rja@sgi.com>
      Cc: "Luck, Tony" <tony.luck@intel.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Ingo Molnar <mingo@elte.hu>
      Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      c642b839
  4. 10 5月, 2007 1 次提交
  5. 09 5月, 2007 2 次提交
    • B
      Add IRQF_IRQPOLL flag (common code) · d85a60d8
      Bernhard Walle 提交于
      irqpoll is broken on some architectures that don't use the IRQ 0 for the timer
      interrupt like IA64.  This patch adds a IRQF_IRQPOLL flag.
      
      Each architecture is handled in a separate pach.  As I left the irq == 0 as
      condition, this should not break existing architectures that use timer_irq ==
      0 and that I did't address with that patch (because I don't know).
      
      This patch:
      
      This patch adds a IRQF_IRQPOLL flag that the interrupt registration code could
      use for the interrupt it wants to use for IRQ polling.
      
      Because this must not be the timer interrupt, an additional flag was added
      instead of re-using the IRQF_TIMER constant.  Until all architectures will
      have an IRQF_IRQPOLL interrupt, irq == 0 will stay as alternative as it should
      not break anything.
      
      Also, note_interrupt() is called on CPU-specific interrupts to be used as
      interrupt source for IRQ polling.
      Signed-off-by: NBernhard Walle <bwalle@suse.de>
      Cc: Russell King <rmk@arm.linux.org.uk>
      Cc: Kyle McMartin <kyle@mcmartin.ca>
      Cc: Matthew Wilcox <willy@debian.org>
      Cc: Grant Grundler <grundler@google.com>
      Cc: Paul Mundt <lethal@linux-sh.org>
      Cc: "Luck, Tony" <tony.luck@intel.com>
      Cc: Ingo Molnar <mingo@elte.hu>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      d85a60d8
    • R
      Pad irq_desc to internode cacheline size · e729aa16
      Ravikiran G Thirumalai 提交于
      We noticed a drop in n/w performance due to the irq_desc being cacheline
      aligned rather than internode aligned.  We see 50% of expected performance
      when two e1000 nics local to two different nodes have consecutive irq
      descriptors allocated, due to false sharing.
      
      Note that this patch does away with cacheline padding for the UP case, as
      it does not seem useful for UP configurations.
      Signed-off-by: NRavikiran Thirumalai <kiran@scalex86.org>
      Signed-off-by: NShai Fultheim <shai@scalex86.org>
      Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
      Cc: Ingo Molnar <mingo@elte.hu>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      e729aa16
  6. 08 12月, 2006 1 次提交
  7. 23 11月, 2006 1 次提交
  8. 05 10月, 2006 1 次提交
    • D
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells 提交于
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: NDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  9. 26 9月, 2006 1 次提交
  10. 02 9月, 2006 1 次提交
  11. 04 7月, 2006 2 次提交
  12. 03 7月, 2006 2 次提交
  13. 02 7月, 2006 2 次提交
  14. 30 6月, 2006 13 次提交
  15. 23 6月, 2006 1 次提交
    • J
      [PATCH] adjust handle_IRR_event() return type · 908dcecd
      Jan Beulich 提交于
      Correct the return type of handle_IRQ_event() (inconsistency noticed during
      Xen development), and remove redundant declarations.  The return type
      adjustment required breaking out the definition of irqreturn_t into a
      separate header, in order to satisfy current include order dependencies.
      Signed-off-by: NJan Beulich <jbeulich@novell.com>
      
      Cc: Richard Henderson <rth@twiddle.net>
      Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
      Cc: Russell King <rmk@arm.linux.org.uk>
      Cc: Ian Molton <spyro@f2s.com>
      Cc: Mikael Starvik <starvik@axis.com>
      Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
      Cc: Hirokazu Takata <takata.hirokazu@renesas.com>
      Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
      Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
      Cc: William Lee Irwin III <wli@holomorphy.com>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Miles Bader <uclinux-v850@lsi.nec.co.jp>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Cc: Roman Zippel <zippel@linux-m68k.org>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      908dcecd
  16. 28 9月, 2005 1 次提交
  17. 08 9月, 2005 1 次提交
  18. 29 6月, 2005 1 次提交
    • A
      [PATCH] irqpoll · 200803df
      Alan Cox 提交于
      Anyone reporting a stuck IRQ should try these options.  Its effectiveness
      varies we've found in the Fedora case.  Quite a few systems with misdescribed
      IRQ routing just work when you use irqpoll.  It also fixes up the VIA systems
      although thats now fixed with the VIA quirk (which we could just make default
      as its what Redmond OS does but Linus didn't like it historically).
      
      A small number of systems have jammed IRQ sources or misdescribes that cause
      an IRQ that we have no handler registered anywhere for.  In those cases it
      doesn't help.
      Signed-off-by: NAlan Cox <number6@the-village.bc.nu>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      200803df
  19. 29 5月, 2005 1 次提交
    • J
      [PATCH] drop note_interrupt() for per-CPU for proper scaling · b60c1f6f
      John Hawkes 提交于
      The "unhandled interrupts" catcher, note_interrupt(), increments a global
      desc->irq_count and grossly damages scaling of very large systems, e.g.,
      >192p ia64 Altix, because of this highly contented cacheline, especially
      for timer interrupts.  384p is severely crippled, and 512p is unuseable.
      
      All calls to note_interrupt() can be disabled by booting with "noirqdebug",
      but this disables the useful interrupt checking for all interrupts.
      
      I propose eliminating note_interrupt() for all per-CPU interrupts.  This
      was the behavior of linux-2.6.10 and earlier, but in 2.6.11 a code
      restructuring added a call to note_interrupt() for per-CPU interrupts.
      Besides, note_interrupt() is a bit racy for concurrent CPU calls anyway, as
      the desc->irq_count++ increment isn't atomic (which, if done, would make
      scaling even worse).
      Signed-off-by: NJohn Hawkes <hawkes@sgi.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      b60c1f6f
  20. 17 5月, 2005 1 次提交
    • Z
      [PATCH] spurious interrupt fix · 4f167fb4
      Zhang, Yanmin 提交于
      On my IA64 machine, after kernel 2.6.12-rc3 boots, an edge-triggered
      interrupt (IRQ 46) keeps triggered over and over again.  There is no IRQ 46
      interrupt action handler.  It has lots of impact on performance.
      
      Kernel 2.6.10 and its prior versions have no the problem.  Basically,
      kernel 2.6.10 will mask the spurious edge interrupt if the interrupt is
      triggered for the second time and its status includes
      IRQ_DISABLE|IRQ_PENDING.
      
      Originally, IA64 kernel has its own specific _irq_desc definitions in file
      arch/ia64/kernel/irq.c.  The definition initiates _irq_desc[irq].status to
      IRQ_DISABLE.  Since kernel 2.6.11, it was moved to architecture independent
      codes, i.e.  kernel/irq/handle.c, but kernel/irq/handle.c initiates
      _irq_desc[irq].status to 0 instead of IRQ_DISABLE.
      Signed-off-by: NZhang Yanmin <yanmin.zhang@intel.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      4f167fb4
  21. 17 4月, 2005 1 次提交
    • L
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds 提交于
      Initial git repository build. I'm not bothering with the full history,
      even though we have it. We can create a separate "historical" git
      archive of that later if we want to, and in the meantime it's about
      3.2GB when imported into git - space that would just make the early
      git days unnecessarily complicated, when we don't have a lot of good
      infrastructure for it.
      
      Let it rip!
      1da177e4