1. 17 10月, 2007 1 次提交
    • M
      cciss: disable DMA refetch on Smart Array P600 · 8bf50f71
      Mike Miller (OS Dev) 提交于
      This patch disables DMA refetch in the PCI bridge. We have disabled DMA
      prefetch for quite some time. Testing with XEN revealed another ASIC bug. If
      dom0 resides on a P600 the board can can an MCA bi accessing invalid memory
      addresses. Apparently, we need to disable both prefetch and refetch.
      My understanding is a refetch operation should not occur but it is a valid
      thing to do if prefetched data is no longer available for whatever reason.
      Please consider this patch for inclusion.
      Signed-off-by: NMike Miller <mike.miller@hp.com>
      Signed-off-by: NAlex Chiang <achiang@hp.com>
      
      --------------------------------------------------------------------------------
      Signed-off-by: NJens Axboe <jens.axboe@oracle.com>
      8bf50f71
  2. 16 10月, 2007 2 次提交
    • L
      Panic in blk_rq_map_sg() from CCISS driver · a683d652
      Lee Schermerhorn 提交于
      New scatter/gather list chaining [sg_next()] treats 'page' member of
      struct scatterlist with low bit set [0x01] as a chain pointer to
      another struct scatterlist [array].  The CCISS driver request function
      passes an uninitialized, temporary, on-stack scatterlist array to
      blk_rq_map_sq().  sg_next() interprets random data on the stack as a
      chain pointer and eventually tries to de-reference an invalid pointer,
      resulting in:
      
      [<ffffffff8031dd70>] blk_rq_map_sg+0x70/0x170
      PGD 6090c3067 PUD 0
      Oops: 0000 [1] SMP
      last sysfs file: /block/cciss!c0d0/cciss!c0d0p1/dev
      CPU 6
      Modules linked in: ehci_hcd ohci_hcd uhci_hcd
      Pid: 1, comm: init Not tainted 2.6.23-rc6-mm1 #3
      RIP: 0010:[<ffffffff8031dd70>] [<ffffffff8031dd70>] blk_rq_map_sg+0x70/0x170
      RSP: 0018:ffff81060901f768 EFLAGS: 00010206
      RAX: 000000040b161000 RBX: ffff81060901f7d8 RCX: 000000040b162c00
      RDX: 0000000000000000 RSI: ffff81060b13a260 RDI: ffff81060b139600
      RBP: 0000000000001400 R08: 00000000fffffffe R09: 0000000000000400
      R10: 0000000000000000 R11: 000000040b163000 R12: ffff810102fe0000
      R13: 0000000000000001 R14: 0000000000000001 R15: 00001e0000000000
      FS: 00000000026108f0(0063) GS:ffff810409000b80(0000) knlGS:0000000000000000
      CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
      CR2: 000000010000001e CR3: 00000006090c6000 CR4: 00000000000006e0
      DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
      Process init (pid: 1, threadinfo ffff81060901e000, task ffff810409020800)
      last branch before last exception/interrupt
      from [<ffffffff8031de0a>] blk_rq_map_sg+0x10a/0x170
      to [<ffffffff8031dd70>] blk_rq_map_sg+0x70/0x170
      Stack: 000000018068ea00 ffff810102fe0000 0000000000000000 ffff810011400000
      0000000000000002 0000000000000000 ffff81040b172000 ffffffff803acd3d
      0000000000003ec1 ffff8106090d5000 ffff8106090d5000 ffff810102fe0000
      Call Trace:
      [<ffffffff803acd3d>] do_cciss_request+0x15d/0x4c0
      [<ffffffff80298968>] new_slab+0x1c8/0x270
      [<ffffffff80298ffd>] __slab_alloc+0x22d/0x470
      [<ffffffff8027327b>] mempool_alloc+0x4b/0x130
      [<ffffffff8032b21e>] cfq_set_request+0xee/0x380
      [<ffffffff8027327b>] mempool_alloc+0x4b/0x130
      [<ffffffff8031ff98>] get_request+0x168/0x360
      [<ffffffff80331b0d>] rb_insert_color+0x8d/0x110
      [<ffffffff8031cfd8>] elv_rb_add+0x58/0x60
      [<ffffffff8032a329>] cfq_add_rq_rb+0x69/0xa0
      [<ffffffff8031c1ab>] elv_merged_request+0x5b/0x60
      [<ffffffff803224fd>] __make_request+0x23d/0x650
      [<ffffffff80298ffd>] __slab_alloc+0x22d/0x470
      [<ffffffff80270000>] generic_write_checks+0x140/0x190
      [<ffffffff8031f012>] generic_make_request+0x1c2/0x3a0
      <etc>
      Kernel panic - not syncing: Attempted to kill init!
      
      This patch initializes the tmp_sg array to zeroes.  Perhaps not the ultimate
      fix, but an effective work-around.  I can now boot 23-rc6-mm1 on an HP
      Proliant x86_64 with CCISS boot disk.
      Signed-off-by: NLee Schermerhorn <lee.schermerhorn@hp.com>
      
       drivers/block/cciss.c |    1 +
       1 file changed, 1 insertion(+)
      Signed-off-by: NJens Axboe <jens.axboe@oracle.com>
      a683d652
    • J
      drivers/block/cpqarray,cciss: kill unused var · 87ad9001
      Jeff Garzik 提交于
      The recent bio work and subsequent fixups created unused variables.
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      Signed-off-by: NJens Axboe <jens.axboe@oracle.com>
      87ad9001
  3. 15 10月, 2007 1 次提交
  4. 10 10月, 2007 1 次提交
  5. 12 8月, 2007 1 次提交
  6. 01 8月, 2007 1 次提交
  7. 24 7月, 2007 1 次提交
  8. 17 7月, 2007 1 次提交
    • S
      Fix too few arguments to function `scsi_cmd_ioctl' · 9793c326
      S.Çağlar Onur 提交于
      This corrects the following compile error introduced by the merge of the
      new bsg layer in commit e245befc:
      
        caglar@zangetsu linux-2.6 $ make
          CHK     include/linux/version.h
          CHK     include/linux/utsrelease.h
          CALL    scripts/checksyscalls.sh
          CHK     include/linux/compile.h
          LD      drivers/block/built-in.o
          CC [M]  drivers/block/cciss.o
        drivers/block/cciss.c: In function `cciss_ioctl':
        drivers/block/cciss.c:1173: warning: passing arg 2 of `scsi_cmd_ioctl' from incompatible pointer type
        drivers/block/cciss.c:1173: warning: passing arg 3 of `scsi_cmd_ioctl' makes pointer from integer without a cast
        drivers/block/cciss.c:1173: warning: passing arg 4 of `scsi_cmd_ioctl' makes integer from pointer without a cast
        drivers/block/cciss.c:1173: error: too few arguments to function `scsi_cmd_ioctl'
        ...
        make[2]: *** [drivers/block/cciss.o] Hata 1
        make[1]: *** [drivers/block] Hata 2
        make: *** [drivers] Hata 2
      Signed-off-by: NS.Çağlar Onur <caglar@pardus.org.tr>
      Cc: Jens Axboe <jens.axboe@oracle.com>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      9793c326
  9. 10 7月, 2007 1 次提交
  10. 19 5月, 2007 1 次提交
  11. 09 5月, 2007 4 次提交
  12. 13 4月, 2007 1 次提交
    • B
      [PATCH] cciss: unregister from SCSI before tearing down device resources · b6550777
      Bjorn Helgaas 提交于
      We must unregister from SCSI before we unmap device resources and unhook
      the IRQ handler.  Otherwise, SCSI may send us more requests, and we won't
      be able to handle them.
      
      I see the following oops during every reboot of my HP DL360:
      
          ...
          Unmounting local filesystems...done.
          Rebooting... Completed flushing cache on controller 0
          BUG: unable to handle kernel paging request at virtual address f8808040
           printing eip:
          c02dc72b
          *pde = 02120067
          *pte = 00000000
          Oops: 0002 [#1]
          SMP
          Modules linked in:
          CPU:    1
          EIP:    0060:[<c02dc72b>]    Not tainted VLI
          EFLAGS: 00010046   (2.6.21-rc6 #1)
          EIP is at SA5_submit_command+0xb/0x20
          eax: f8808000   ebx: f7a00000   ecx: f79f0000   edx: 37a00000
          esi: f79f0000   edi: 00000000   ebp: 00000000   esp: dd717a44
          ds: 007b   es: 007b   fs: 00d8  gs: 0000  ss: 0068
          Process khelper (pid: 1427, ti=dd716000 task=c2260a70 task.ti=dd716000)
          Stack: c02df2c0 f7a00000 f7a00000 00d41008 c02df691 00000000 00000010 00000002
      	   00000001 f79f0000 f7fff844 c1398420 00000000 00000000 00001000 230a3020
      	   69666564 5420656e 50434f49 465f544b 4853554c 44414552 0a312009 66656423
          Call Trace:
           [<c02df2c0>] start_io+0x80/0x120
           [<c02df691>] do_cciss_request+0x331/0x350
           [<c014242a>] mempool_alloc+0x2a/0xe0
           [<c020ad71>] blk_alloc_request+0x61/0x80
           [<c020b02e>] get_request+0x15e/0x1e0
           [<c01595e0>] cache_alloc_refill+0xb0/0x1e0
           [<c021049d>] as_update_rq+0x2d/0x80
           [<c0210d28>] as_add_request+0x68/0x90
           [<c0207f99>] elv_insert+0x119/0x160
           [<c020bd0b>] __make_request+0xcb/0x320
           [<c0122ee0>] lock_timer_base+0x20/0x50
           [<c0123096>] del_timer+0x56/0x60
           [<c020a7b8>] blk_remove_plug+0x38/0x70
           [<c020a815>] __generic_unplug_device+0x25/0x30
           [<c020a835>] generic_unplug_device+0x15/0x30
          ...
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Acked-by: NMike Miller <mike.miller@hp.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      b6550777
  13. 05 4月, 2007 1 次提交
  14. 15 3月, 2007 1 次提交
  15. 07 3月, 2007 2 次提交
  16. 31 12月, 2006 1 次提交
  17. 18 12月, 2006 2 次提交
  18. 14 12月, 2006 3 次提交
    • R
      [PATCH] getting rid of all casts of k[cmz]alloc() calls · 5cbded58
      Robert P. J. Day 提交于
      Run this:
      
      	#!/bin/sh
      	for f in $(grep -Erl "\([^\)]*\) *k[cmz]alloc" *) ; do
      	  echo "De-casting $f..."
      	  perl -pi -e "s/ ?= ?\([^\)]*\) *(k[cmz]alloc) *\(/ = \1\(/" $f
      	done
      
      And then go through and reinstate those cases where code is casting pointers
      to non-pointers.
      
      And then drop a few hunks which conflicted with outstanding work.
      
      Cc: Russell King <rmk@arm.linux.org.uk>, Ian Molton <spyro@f2s.com>
      Cc: Mikael Starvik <starvik@axis.com>
      Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
      Cc: Roman Zippel <zippel@linux-m68k.org>
      Cc: Geert Uytterhoeven <geert@linux-m68k.org>
      Cc: Ralf Baechle <ralf@linux-mips.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Kyle McMartin <kyle@mcmartin.ca>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jeff Dike <jdike@addtoit.com>
      Cc: Greg KH <greg@kroah.com>
      Cc: Jens Axboe <jens.axboe@oracle.com>
      Cc: Paul Fulghum <paulkf@microgate.com>
      Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
      Cc: Karsten Keil <kkeil@suse.de>
      Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
      Cc: Jeff Garzik <jeff@garzik.org>
      Cc: James Bottomley <James.Bottomley@steeleye.com>
      Cc: Ian Kent <raven@themaw.net>
      Cc: Steven French <sfrench@us.ibm.com>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Neil Brown <neilb@cse.unsw.edu.au>
      Cc: Jaroslav Kysela <perex@suse.cz>
      Cc: Takashi Iwai <tiwai@suse.de>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      5cbded58
    • M
      [PATCH] cciss: remove calls to pci_disable_device · 872225ca
      Mike Miller 提交于
      Remove calls to pci_disable_device except in fail_all_cmds.  The
      pci_disable_device function does something nasty to Smart Array controllers
      that pci_enable_device does not undo.  So if the driver is unloaded it
      cannot be reloaded.
      
      Also, customers can disable any pci device via the ROM Based Setup Utility
      (RBSU).  If the customer has disabled the controller we should not try to
      blindly enable the card from the driver.  Please consider this for
      inclusion.
      Signed-off-by: NMike Miller <mike.miller@hp.com>
      Acked-by: NAlan Cox <alan@redhat.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      872225ca
    • M
      [PATCH] cciss: map out more memory for config table · a5b92873
      Mike Miller 提交于
      Map out more memory for our config table.  It's required to reach offset
      0x214 to disable DMA on the P600.  I'm not sure how I lost this hunk.
      Please consider this for inclusion.
      Signed-off-by: NMike Miller <mike.miller@hp.com>
      Cc: Jens Axboe <jens.axboe@oracle.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      a5b92873
  19. 13 12月, 2006 3 次提交
  20. 09 12月, 2006 1 次提交
  21. 08 12月, 2006 10 次提交