- 24 7月, 2014 5 次提交
-
-
由 Matthias Beyer 提交于
The variable type of the local variable 'j' should be 'int' instead of 'unsigned int'. Suggested-by: NDan Carpenter <dan.carpenter@oracle.com> Signed-off-by: NMatthias Beyer <mail@beyermatthias.de> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Sudip Mukherjee 提交于
Signed-off-by: NSudip Mukherjee <sudipm.mukherjee@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Tom Jorquera 提交于
vme_user.c contained unnecessary breaks after gotos, which increased code size and caused code style warning. This is now fixed. Signed-off-by: NTom Jorquera <tom.jorquera@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Andrey Utkin 提交于
The issue was reported by static analysis. The value holding flags was &-ed with 0x02, being compared to 0x01 (TRUE) after that. Such comparsion is always false. Resolution: drop the comparsion to TRUE in the condition. &-ing with 0x02 is right, according to result variable name (reporting_mode) and description in drivers/staging/bcm/target_params.h ("bit 1 = 1: CINR reporting in Idlemode Msg"). Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80801Reported-by: NDavid Binderman <dcb314@hotmail.com> Signed-off-by: NAndrey Utkin <andrey.krieger.utkin@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Robin Schroer 提交于
Fix a pointer check to use NULL instead of 0 Warning: drivers/staging/goldfish/goldfish_audio.c:300:34: warning: Using plain integer as NULL pointer Signed-off-by: NRobin Schroer <sulamiification@gmail.com> Acked-by: NAlan Cox <alan@linux.intel.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 23 7月, 2014 35 次提交
-
-
由 Malcolm Priestley 提交于
Base type is always little endian. Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Malcolm Priestley 提交于
Endian is always little add correction in vnt_tx_packet. Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Malcolm Priestley 提交于
Removing camel case Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Malcolm Priestley 提交于
Removing camel case Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Malcolm Priestley 提交于
removing camel case. Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Malcolm Priestley 提交于
Replacing camel case Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Malcolm Priestley 提交于
Removing prefix and camel case. Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Erik Arfvidson 提交于
This patch fixes formatting and cleans up unneeded comments Signed-off-by: NErik Arfvidson <erik.arfvidson@unisys.com> Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Benjamin Romer 提交于
Move the proc entry controlling the boottotool flag to procfs. The field appears in /sys/devices/platform/visorchipset/install/boottotool. The boottotool flag controls s-Par behavior on the next boot of this guest. Setting the flag will cause the guest to boot from the utility and installation image, which will use the value in the toolaction field to determine what operation is being requested. Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Benjamin Romer 提交于
Move the proc entry for controlling the toolaction field to sysfs. The field appears in /sys/devices/platform/visorchipset/install/toolaction. This field is used to tell s-Par which type of recovery tool action to perform on the next guest boot-up. The meaning of the value is dependent on the type of installation software used to commission the guest. Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Masanari Iida 提交于
This patch fix spelling typo in comments within rtl8723au/core. Signed-off-by: NMasanari Iida <standby24x7@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Masanari Iida 提交于
This patch fix spelling typo in comments within rtw_ap.c Signed-off-by: NMasanari Iida <standby24x7@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Masanari Iida 提交于
This patch fix spelling typo in comments within rtw_xmit.c Signed-off-by: NMasanari Iida <standby24x7@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Masanari Iida 提交于
This patch fix spelling typo in comments within rtw_mlme.c Signed-off-by: NMasanari Iida <standby24x7@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Himangi Saraogi 提交于
Replace use of NLMSG_SPACE(0) with NLMSG_HDRLEN as they are equivalent and NLMSG_SPACE seems to be deprecated. Signed-off-by: NHimangi Saraogi <himangi774@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Seunghun Lee 提交于
This patch fixes the following checkpatch error: ERROR: do not use C99 // comments CC: Lidza Louina <lidza.louina@gmail.com> Signed-off-by: NSeunghun Lee <waydi1@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Ian Abbott 提交于
`ni6527_reset()` is called to reset various registers when the device is being initialized or deinitialized. The edge detection interrupt is disabled by this function, but the rising and falling edge detection registers are currently left alone. Call `ni6527_set_edge_detection()` to set them to a known, disabled state. Signed-off-by: NIan Abbott <abbotti@mev.co.uk> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Ian Abbott 提交于
The "edge detection interrupt" subdevice supports the `INSN_CONFIG_CHANGE_NOTIFY` comedi instruction which is only supported by one other driver. The `INSN_CONFIG_DIGITAL_TRIG` comedi instruction is more flexible as it supports both edge and level detection, but is not currently supported by this driver. Add partial support for `INSN_CONFIG_DIGITAL_TRIG`, but only for edge detection. Make use of the `ni6527_set_edge_detection()` used for `INSN_CONFIG_CHANGE_NOTIFY`, but add a parameter holding a mask of the rising and falling edges to be updated and preserve the unmasked edges when updating. Signed-off-by: NIan Abbott <abbotti@mev.co.uk> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Ian Abbott 提交于
This driver currently inverts the outputs for the DO (digital output) subdevice for some of the boards it supports, indicated by the `invert_outputs` member in the board-specific data being initialized to 1. It seems this driver shouldn't really be inverting outputs for these boards at all, but has done so since the driver was first written back in October 2006. I've had confirmation that for the PCI-6515 at least, the output voltage levels are opposite to the values set by the user program. The driver by Jon Grierson originally supported only PCI-6514 and PXI-6514 (and was originally called "ni_6514"). The driver was based on "ni_6527", which is where the inversion of outputs appears to have come from. Over a period of a few days, the driver was enhanced by Frank Mori Hess to support other boards. Some of these plainly didn't require inverted outputs and some guesswork was used to decide which boards should have inverted outputs. Some of the boards in question are described in the manual as having "Sink Outputs" and others are described as having "Source Outputs", but this does not correspond in any way with which boards are marked as having inverted outputs, so the criterion that Frank used is a bit of a mystery! Change the driver so it doesn't invert the outputs of these by boards by default, but add a module parameter, "legacy_invert_outputs", that can be set to 'true' to restore the old behaviour. Also rename the `invert_outputs` member of `struct ni_65xx_board` to `legacy_invert`. Signed-off-by: NIan Abbott <abbotti@mev.co.uk> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Masanari Iida 提交于
This patch fix spelling typo in comments within rtw_mlme_ext.c Signed-off-by: NMasanari Iida <standby24x7@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Kiran Padwal 提交于
Checkpatch fix - Add missing blank line after variable declaration Signed-off-by: NKiran Padwal <kiran.padwal21@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Sam Asadi 提交于
A 'line over 80 characters' fixed by removing comment to the previous line. Signed-off-by: NSam Asadi <asadi.samuel@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Sam Asadi 提交于
A 'line over 80 characters' fixed by removing comment to previous line. Signed-off-by: NSam Asadi <asadi.samuel@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 H Hartley Sweeten 提交于
This parameter is never used by any of the comedi drivers that provide a (*buf_change) callback. If the 'new_size' is needed in the callback it can be found from the 's->async->prealloc_bufsz' as done in the ni_pcidio driver. Remove the unused parameter. Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: NIan Abbott <abbotti@mev.co.uk> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 H Hartley Sweeten 提交于
The 'do_lock' and 'do_unlock' callbacks are not used be any of the comedi drivers or the comedi core. Just remove them. Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: NIan Abbott <abbotti@mev.co.uk> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 H Hartley Sweeten 提交于
According to Ian Abbott, this code was added in comedi-0.7.6 back in June 1999 and has always been disabled. The 'lock_f' and 'unlock' members don't even exist in the comedi_subdevice. Just remove the disabled code. Signed-off-by: NH Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: NIan Abbott <abbotti@mev.co.uk> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Igor Bezukh 提交于
Removed redundant comments from 80211hdr.h header file Signed-off-by: NIgor Bezukh <igbzkh@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Igor Bezukh 提交于
Removed redundant comments and newlines from 80211mgr.h header file. Signed-off-by: NIgor Bezukh <igbzkh@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Igor Bezukh 提交于
Removed redundant comments from aes_ccmp.h header file Signed-off-by: NIgor Bezukh <igbzkh@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Guillaume Clement 提交于
Sparse reports that MimeThread is not used. Actually, it can be used if THREAD is defined. By enclosing the MimeThread function into the same #ifdef as the caller of MimeThread, this fixes the sparse warnings. Signed-off-by: NGuillaume Clement <gclement@baobob.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Guillaume Clement 提交于
The IEEE11hbMgrRxAction is not exported and never used. Deleting it allows to delete other functions that were only used by IEEE11hbMgrRxAction. This allows to fix several warnings reported by sparse. Signed-off-by: NGuillaume Clement <gclement@baobob.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Guillaume Clement 提交于
Some variables are used only in the context of their .c file, which gives warnings with sparse. Signed-off-by: NGuillaume Clement <gclement@baobob.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Guillaume Clement 提交于
There is one function in aes_ccmp.c which is exported, but sparse sees it unexported because it doesn't include the header that exports it. Signed-off-by: NGuillaume Clement <gclement@baobob.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Guillaume Clement 提交于
PortOffset was an unsigned long, but used as an pointer to io memory. Sometimes it was not properly cast before use, which caused many warning by sparse. By updating its type to void __iomem *, and reflecting the changes where it is needed, this removes most of those warnings. Signed-off-by: NGuillaume Clement <gclement@baobob.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Matt Kurz 提交于
Declare several functions and variables as static in order to address the following sparse warnings drivers/staging/lustre/lnet/lnet/acceptor.c:49:3: warning: symbol 'lnet_acceptor_state' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/acceptor.c:79:1: warning: symbol 'lnet_acceptor_get_tunables' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/acceptor.c:211:1: warning: symbol 'lnet_accept' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/acceptor.c:333:1: warning: symbol 'lnet_acceptor' was not declared. Should it be static? Tested by compilation only. Signed-off-by: NMatt Kurz <matt@ninezulu.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-