1. 17 11月, 2010 3 次提交
    • S
      staging: ft1000: Copy from user into correct data · 7f55f13c
      Steven Rostedt 提交于
      While doing a ktest.pl I used a MIN_CONFIG that had STAGING enabled, and
      a randconfig with CONFIG_DEBUG_STRICT_USER_COPY_CHECKS enabled caught
      the following bug:
      
      In file included from /home/rostedt/work/autotest/nobackup/linux-test.git/arch/x86/include/asm/uaccess.h:571:0,
                       from /home/rostedt/work/autotest/nobackup/linux-test.git/include/linux/poll.h:14,
                       from /home/rostedt/work/autotest/nobackup/linux-test.git/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c:32:
      In function 'copy_from_user',
          inlined from 'ft1000_ChIoctl' at /home/rostedt/work/autotest/nobackup/linux-test.git/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c:702:36:
      /home/rostedt/work/autotest/nobackup/linux-test.git/arch/x86/include/asm/uaccess_32.h:212:26: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct
      
      Looking at the code it was obvious what the problem was. The pointer
      dpram_data was being allocated but the address was being written to.
      Looking at the comment above the code shows that it use to write into an
      element of that pointer where the '&' is appropriate. But now that it
      writes to the pointer itself, we need to remove the '&' otherwise we
      write over the pointer and not into the data it points to.
      Signed-off-by: NSteven Rostedt <rostedt@goodmis.org>
      Cc: Marek Belisko <marek.belisko@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      7f55f13c
    • M
      staging: ft1000: Fix error goto statements. · e72115bc
      Marek Belisko 提交于
      With commit 2dab1ac8 there
      was intruduced error which lead to stopping uninitialized
      kthread which leads to kernel panics.
      
      This patch fix problems with common entry point in correct
      way.
      Signed-off-by: NMarek Belisko <marek.belisko@gmail.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      e72115bc
    • G
      Staging: Merge 2.6.37-rc2 into staging-next · 491acf00
      Greg Kroah-Hartman 提交于
      This was necessary in order  to resolve some conflicts that happened
      between -rc1 and -rc2 with the following files:
      	drivers/staging/bcm/Bcmchar.c
      	drivers/staging/intel_sst/intel_sst_app_interface.c
      
      All should be resolved now.
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      491acf00
  2. 16 11月, 2010 27 次提交
  3. 15 11月, 2010 9 次提交
  4. 14 11月, 2010 1 次提交