1. 12 9月, 2012 1 次提交
  2. 07 9月, 2012 1 次提交
  3. 20 8月, 2012 1 次提交
  4. 15 8月, 2012 1 次提交
  5. 03 7月, 2012 1 次提交
  6. 24 4月, 2012 1 次提交
  7. 24 2月, 2012 1 次提交
  8. 19 12月, 2011 1 次提交
  9. 06 12月, 2011 1 次提交
  10. 01 11月, 2011 1 次提交
  11. 24 8月, 2011 1 次提交
  12. 16 6月, 2011 1 次提交
  13. 14 6月, 2011 2 次提交
  14. 10 6月, 2011 2 次提交
    • T
      ALSA: use KBUILD_MODNAME for request_irq argument in sound/pci/* · 934c2b6d
      Takashi Iwai 提交于
      The name argument of request_irq() appears in /proc/interrupts, and
      it's quite ugly when the name entry contains a space or special letters.
      In general, it's simpler and more readable when the module name appears
      there, so let's replace all entries with KBUILD_MODNAME.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      934c2b6d
    • T
      ALSA: Use KBUILD_MODNAME for pci_driver.name entries · 3733e424
      Takashi Iwai 提交于
      The convention for pci_driver.name entry in kernel drivers seem to be
      the module name or equivalent ones.  But, so far, almost all PCI sound
      drivers use more verbose name like "ABC Xyz (12)", and these are fairly
      confusing when appearing as a file name.
      
      This patch converts the all pci_driver.name entries in sound/pci/* to
      use KBUILD_MODNAME for more unified appearance.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      3733e424
  15. 31 3月, 2011 1 次提交
  16. 16 3月, 2011 1 次提交
  17. 14 3月, 2011 4 次提交
  18. 11 11月, 2010 1 次提交
    • J
      ALSA: sound/pci/ctxfi/ctpcm.c: Remove potential for use after free · fa2b30af
      Julia Lawall 提交于
      In each function, the value apcm is stored in the private_data field of
      runtime.  At the same time the function ct_atc_pcm_free_substream is stored
      in the private_free field of the same structure.  ct_atc_pcm_free_substream
      dereferences and ultimately frees the value in the private_data field.  But
      each function can exit in an error case with apcm having been freed, in
      which case a subsequent call to the private_free function would perform a
      dereference after free.  On the other hand, if the private_free field is
      not initialized, it is NULL, and not invoked (see snd_pcm_detach_substream
      in sound/core/pcm.c).  To avoid the introduction of a dangling pointer, the
      initializations of the private_data and private_free fields are moved to
      the end of the function, past any possible free of apcm.  This is safe
      because the previous calls to snd_pcm_hw_constraint_integer and
      snd_pcm_hw_constraint_minmax, which take runtime as an argument, do not
      refer to either of these fields.
      
      In each function, there is one error case where apcm needs to be freed, and
      a call to kfree is added.
      
      The sematic match that finds this problem is as follows:
      (http://coccinelle.lip6.fr/)
      
      // <smpl>
      @@
      expression e,e1,e2,e3;
      identifier f,free1,free2;
      expression a;
      @@
      
      *e->f = a
      ... when != e->f = e1
          when any
      if (...) {
        ... when != free1(...,e,...)
            when != e->f = e2
      * kfree(a)
        ... when != free2(...,e,...)
            when != e->f = e3
      }
      // </smpl>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      fa2b30af
  19. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  20. 09 2月, 2010 1 次提交
  21. 05 2月, 2010 1 次提交
    • J
      ALSA: ctxfi - fix PTP address initialization · 21956b61
      Jaroslav Kysela 提交于
      After hours of debugging, I finally found the reason why some source
      and runtime combination does not work. The PTP (page table pages)
      address must be aligned. I am not sure how much, but alignment to
      PAGE_SIZE is sufficient. Also, use ALSA's page allocation routines
      to ensure proper virtual -> physical address translation.
      
      Cc: <stable@kernel.org>
      Signed-off-by: NJaroslav Kysela <perex@perex.cz>
      21956b61
  22. 14 1月, 2010 1 次提交
  23. 30 10月, 2009 1 次提交
  24. 02 10月, 2009 1 次提交
  25. 22 7月, 2009 2 次提交
    • T
      ALSA: ctxfi - Simple code clean up · 35ebf6e7
      Takashi Iwai 提交于
      - replace NULL == xxx with !xxx
      - replace NULL != xxx with xxx
      - similar trivial cleanups
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      35ebf6e7
    • T
      ALSA: ctxfi - Fix uninitialized error checks · 68110661
      Takashi Iwai 提交于
      Fix a few uninitialized error checks that were introduced recently
      mistakenlly during the clean-up:
        sound/pci/ctxfi/ctamixer.c: In function ‘get_amixer_rsc’:
        sound/pci/ctxfi/ctamixer.c:261: warning: ‘err’ may be used uninitialized in this function
        sound/pci/ctxfi/ctamixer.c: In function ‘get_sum_rsc’:
        sound/pci/ctxfi/ctamixer.c:415: warning: ‘err’ may be used uninitialized in this function
        sound/pci/ctxfi/ctsrc.c: In function ‘get_srcimp_rsc’:
        sound/pci/ctxfi/ctsrc.c:742: warning: ‘err’ may be used uninitialized in this function
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      68110661
  26. 20 7月, 2009 2 次提交
  27. 22 6月, 2009 2 次提交
  28. 15 6月, 2009 1 次提交
    • T
      ALSA: ctxfi - Fix deadlock with xfi-timer · 8dca4197
      Takashi Iwai 提交于
      The PCM x-fi native update routine can cause deadlocks when the
      trigger(START) is called while the stream is running.
      
      This patch fixes the deadlock by just postponing the pcm period update
      to the next possible wake-up.  Also it adds the flip of ti->running
      flag (just to be sure as now).
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      8dca4197
  29. 13 6月, 2009 1 次提交
    • T
      ALSA: ctxfi - Replace atc lock to mutex · 635c265f
      Takashi Iwai 提交于
      The spinlock in atc can cause a sleep in lock:
      
      Kernel failure message 1:
      BUG: sleeping function called from invalid context at mm/slub.c:1599
      in_atomic(): 0, irqs_disabled(): 1, pid: 2537, name: gstreamer-prope
      Pid: 2537, comm: gstreamer-prope Tainted: P
      2.6.29.4-167.fc11.x86_64 #1
      Call Trace:
        [<ffffffff8103ff0f>] __might_sleep+0x10b/0x110
        [<ffffffff810cd734>] __kmalloc+0x73/0x130
        [<ffffffffa0b4b142>] ? daio_rsc_init+0xaa/0x125 [snd_ctxfi]
        [<ffffffffa0b4b212>] dao_rsc_init+0x55/0x1c0 [snd_ctxfi]
        [<ffffffffa0b4b3d2>] dao_rsc_reinit+0x55/0x5d [snd_ctxfi]
        [<ffffffff813abd6c>] ? _spin_lock_irqsave+0x32/0x3b
        [<ffffffffa0b454fe>] atc_spdif_out_passthru+0x92/0x136 [snd_ctxfi]
        ...
      
      Since the lock path is no critical path, it can be gracefully
      replaced with a mutex.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      635c265f
  30. 09 6月, 2009 3 次提交