1. 07 4月, 2009 1 次提交
  2. 30 3月, 2009 9 次提交
  3. 29 1月, 2009 1 次提交
  4. 11 11月, 2008 1 次提交
    • S
      V4L/DVB (9356): [PATCH] saa7134: fix resource map sanity check conflict · d522af58
      Suresh Siddha 提交于
      Impact: driver could possibly stomp on resources outside of its scope
      
      {mchehab@redhat.com: I got two versions of the same patch (identical,
      except for whitespacing). One authored by Andy Burns and another
      authored by Suresh Siddha. Due to that, I'm applying the one that has
      less CodingStyle errors. I'm also adding both comments and the SOB's for
      both patches, since they are both interesting}
      
      Suresh Siddha commented:
      
        Alexey Fisher reported:
      
        > resource map sanity check conflict: 0xcfeff800 0xcff007ff 0xcfe00000
        > 0xcfefffff PCI Bus 0000:01
      
        BAR base is located in the middle of the 4K page and the hardcoded
        size argument makes the request span two pages causing the conflict.
      
        Fix the hard coded size argument in ioremap().
      
      Andy Burns commented:
      
        I have already sent this patch on the linux-dvb list, but it didn't get
        much attention, so re-sending direct, I hope you all don't mind.
      
        While attempting to run mythtv in a xen domU, I encountered problems
        loading the driver for my saa7134 card, with an error from ioremap().
      
        This error was due to the driver allocating an incorrectly sized mmio
        area, which was trapped by xen's permission checks, but this would go
        un-noticed on a kernel without xen.
      
        My card has a 1K sized mmio area, I've had information that other cards
        have 2K areas, perhaps others have different sizes, yet the driver
        always attempts to map 4K.  I realise that the granularity of mapping is
        the page size, which typically would be 4K, but unless the card's base
        address happens to fall on a 4K boundary (mine does not) then the
        base+4K will end up spanning two pages, and this is when the error
        occurs under xen.
      
        My patch uses the pci_resource_len macro to determine the size required
        for the user's particular card, instead of the hardcoded 4K value. I've
        tested with a couple of printk() inside ioremap() that the start address
        and size do get rounded to the closest page boundary.
      
        With this patch I am able to successfully load the saa7134 driver and
        run mythtv under xen with my card, subject to correct pollirq settings
        in case of shared IRQ, I am still seeing occasional DMA panics, which I
        think are related to swiotlb handling by dom0/domU, usually the panic
        occurs when changing mux, once tuned to a mux, 12 hour continuous
        recordings are possible without errors.
      Reported-by: NAlexey Fisher <bug-track@fisher-privat.net>
      Tested-by: NAlexey Fisher <bug-track@fisher-privat.net>
      Signed-off-by: NSuresh Siddha <suresh.b.siddha@intel.com>
      Signed-off-by: NAndy Burns <andy@burns.net>
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      d522af58
  5. 22 10月, 2008 1 次提交
    • H
      V4L/DVB (9327): v4l: use video_device.num instead of minor in video%d · c6330fb8
      Hans Verkuil 提交于
      The kernel number of a v4l2 node (e.g. videoX, radioX or vbiX) is now
      independent of the minor number. So instead of using the minor field
      of the video_device struct one has to use the num field: this always
      contains the kernel number of the device node.
      
      I forgot about this when I did the v4l2 core change, so this patch
      converts all drivers that use it in one go. Luckily the change is
      trivial.
      
      Cc: michael@mihu.de
      Cc: mchehab@infradead.org
      Cc: corbet@lwn.net
      Cc: luca.risolia@studio.unibo.it
      Cc: isely@pobox.com
      Cc: pe1rxq@amsat.org
      Cc: royale@zerezo.com
      Cc: mkrufky@linuxtv.org
      Cc: stoth@linuxtv.org
      Signed-off-by: NHans Verkuil <hverkuil@xs4all.nl>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      c6330fb8
  6. 12 10月, 2008 4 次提交
  7. 27 7月, 2008 2 次提交
  8. 24 7月, 2008 1 次提交
  9. 20 7月, 2008 1 次提交
  10. 14 5月, 2008 2 次提交
  11. 25 4月, 2008 5 次提交
  12. 20 3月, 2008 1 次提交
  13. 26 1月, 2008 8 次提交
  14. 18 1月, 2008 1 次提交
  15. 12 12月, 2007 1 次提交
    • H
      V4L/DVB (6690): saa7134: fix ignored interrupts · 843b1378
      Heikki Lindholm 提交于
      The saa7134 video driver starts dropping frames when used together with the
      saa7134-alsa driver. Frames are dropped because when an audio event is waiting
      the driver simply ignores the interrupt and passes it on to the saa7134-alsa
      interrupt handler. The alsa interrupt handler in turn acknowledges all types
      of events thus clearing the pending video events as well. Fix by only masking
      out the audio event in the video interrupt handler and by only acknowledging
      the audio event in the alsa driver.
      Signed-off-by: NHeikki Lindholm  <holindho@cs.helsinki.fi>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@infradead.org>
      843b1378
  16. 22 10月, 2007 1 次提交