1. 08 6月, 2016 1 次提交
    • T
      leds: core: Fix brightness setting upon hardware blinking enabled · 7cfe749f
      Tony Makkiel 提交于
      Commit 76931edd ("leds: fix brightness changing when software blinking
      is active") changed the semantics of led_set_brightness() which according
      to the documentation should disable blinking upon any brightness setting.
      Moreover it made it different for soft blink case, where it was possible
      to change blink brightness, and for hardware blink case, where setting
      any brightness greater than 0 was ignored.
      
      While the change itself is against the documentation claims, it was driven
      also by the fact that timer trigger remained active after turning blinking
      off. Fixing that would have required major refactoring in the led-core,
      led-class, and led-triggers because of cyclic dependencies.
      
      Finally, it has been decided that allowing for brightness change during
      blinking is beneficial as it can be accomplished without disturbing
      blink rhythm.
      
      The change in brightness setting semantics will not affect existing
      LED class drivers that implement blink_set op thanks to the LED_BLINK_SW
      flag introduced by this patch. The flag state will be from now on checked
      in led_set_brightness() which will allow to distinguish between software
      and hardware blink mode. In the latter case the control will be passed
      directly to the drivers which apply their semantics on brightness set,
      which is disable the blinking in case of most such drivers. New drivers
      will apply new semantics and just change the brightness while hardware
      blinking is on, if possible.
      
      The issue was smuggled by subsequent LED core improvements, which modified
      the code that originally introduced the problem.
      
      Fixes: f1e80c07 ("leds: core: Add two new LED_BLINK_ flags")
      Signed-off-by: NTony Makkiel <tony.makkiel@daqri.com>
      Signed-off-by: NJacek Anaszewski <j.anaszewski@samsung.com>
      7cfe749f
  2. 04 1月, 2016 1 次提交
  3. 12 6月, 2015 1 次提交
  4. 05 11月, 2011 1 次提交
  5. 05 4月, 2011 1 次提交
  6. 12 11月, 2010 1 次提交
  7. 29 8月, 2009 1 次提交
  8. 27 7月, 2008 1 次提交
  9. 25 4月, 2008 1 次提交
  10. 07 2月, 2008 2 次提交
  11. 01 4月, 2006 1 次提交
    • R
      [PATCH] LED: class documentation · 75c1d31d
      Richard Purdie 提交于
      The LED class/subsystem takes John Lenz's work and extends and alters it to
      give what I think should be a fairly universal LED implementation.
      
      The series consists of several logical units:
      
      * LED Core + Class implementation
      * LED Trigger Core implementation
      * LED timer trigger (example of a complex trigger)
      * LED device drivers for corgi, spitz and tosa Zaurus models
      * LED device driver for locomo LEDs
      * LED device driver for ARM ixp4xx LEDs
      * Zaurus charging LED trigger
      * IDE disk activity LED trigger
      * NAND MTD activity LED trigger
      
      Why?
      ====
      
      LEDs are really simple devices usually amounting to a GPIO that can be turned
      on and off so why do we need all this code?  On handheld or embedded devices
      they're an important part of an often limited user interface.  Both users and
      developers want to be able to control and configure what the LED does and the
      number of different things they'd potentially want the LED to show is large.
      
      A subsystem is needed to try and provide all this different functionality in
      an architecture independent, simple but complete, generic and scalable manner.
      
      The alternative is for everyone to implement just what they need hidden away
      in different corners of the kernel source tree and to provide an inconsistent
      interface to userspace.
      
      Other Implementations
      =====================
      
      I'm aware of the existing arm led implementation.  Currently the new subsystem
      and the arm code can coexist quite happily.  Its up to the arm community to
      decide whether this new interface is acceptable to them.  As far as I can see,
      the new interface can do everything the existing arm implementation can with
      the advantage that the new code is architecture independent and much more
      generic, configurable and scalable.
      
      I'm prepared to make the conversion to the LED subsystem (or assist with it)
      if appropriate.
      
      Implementation Details
      ======================
      
      I've stripped a lot of code out of John's original LED class.  Colours were
      removed as LED colour is now part of the device name.  Multiple colours are to
      be handled as multiple led devices.  This means you get full control over each
      colour.  I also removed the LED hardware timer code as the generic timer isn't
      going to add much overhead and is just as useful.  I also decided to have the
      LED core track the current LED status (to ease suspend/resume handling)
      removing the need for brightness_get implementations in the LED drivers.
      
      An underlying design philosophy is simplicity.  The aim is to keep a small
      amount of code giving as much functionality as possible.
      
      The major new idea is the led "trigger".  A trigger is a source of led events.
       Triggers can either be simple or complex.  A simple trigger isn't
      configurable and is designed to slot into existing subsystems with minimal
      additional code.  Examples are the ide-disk, nand-disk and zaurus-charging
      triggers.  With leds disabled, the code optimises away.  Examples are
      nand-disk and ide-disk.
      
      Complex triggers whilst available to all LEDs have LED specific parameters and
      work on a per LED basis.  The timer trigger is an example.
      
      You can change triggers in a similar manner to the way an IO scheduler is
      chosen (via /sys/class/leds/somedevice/trigger).
      
      So far there are only a handful of examples but it should easy to add further
      LED triggers without too much interference into other subsystems.
      
      Known Issues
      ============
      
      The LED Trigger core cannot be a module as the simple trigger functions would
      cause nightmare dependency issues.  I see this as a minor issue compared to
      the benefits the simple trigger functionality brings.  The rest of the LED
      subsystem can be modular.
      
      Some leds can be programmed to flash in hardware.  As this isn't a generic LED
      device property, I think this should be exported as a device specific sysfs
      attribute rather than part of the class if this functionality is required (eg.
       to keep the led flashing whilst the device is suspended).
      
      Future Development
      ==================
      
      At the moment, a trigger can't be created specifically for a single LED.
      There are a number of cases where a trigger might only be mappable to a
      particular LED.  The addition of triggers provided by the LED driver should
      cover this option and be possible to add without breaking the current
      interface.
      
      A CPU activity trigger similar to that found in the arm led implementation
      should be trivial to add.
      
      This patch:
      
      Add some brief documentation of the design decisions behind the LED class and
      how it appears to users.
      Signed-off-by: NRichard Purdie <rpurdie@rpsys.net>
      Cc: Russell King <rmk@arm.linux.org.uk>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      75c1d31d