Add device tree support for twl4030 keypad driver.

Tested on Nokia N900.
Signed-off-by: NSebastian Reichel <sre@debian.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We should drop reference to twl6040_core_node device_node once we are done
using it.
Signed-off-by: NLibo Chen <libo.chen@huawei.com>
Acked-by: NPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We should drop reference to twl6040_core_node device_node once we are done
using it.
Signed-off-by: NLibo Chen <libo.chen@huawei.com>
Acked-by: NPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Remove messy dependencies from SERIO_I8042 by having it depend on one
Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures
which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig.
New architectures are unlikely to need SERIO_I8042, so this avoids
having an ever growing list of architectures to exclude.
Signed-off-by: NMark Salter <msalter@redhat.com>
Acked-by: N"H. Peter Anvin" <hpa@zytor.com>
Acked-by: NRalf Baechle <ralf@linux-mips.org>
Acked-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The driver can't deal with two entries its keymap having the same keycode.
When this happens it will get confused about whether the key is down or up
and will cause some screwy behavior.

We need to have two entries for KEY_BACKSLASH to handle US and UK
keyboards. Specifically:
* On the US keyboard the backslash key (above enter) is r3 c11 and is
  supposed to be reported as BACKSLASH.
* On the UK keyboard the # key (left of enter) is r4 c10 and is
  supposed to be reported as BACKSLASH.
* On the UK keyboard the \ key (left of Z) is r2 c7 and is supposed to
  be reported as KEY_102ND.

Note that both keyboards (US and UK) have only one physical backslash
key so the constraint that each physical key should have its own keycode
still stands.
Signed-off-by: NDoug Anderson <dianders@chromium.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This simplifies error handling and device removal paths.
Acked-by: NStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

free_irq() in the error handling case is missing when change
pass input device directly to interrupt.

Fixes: b27f8fee('Input: pmic8xxx-pwrkey - pass input device directly to interrupt')
Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This adds support for another flavor of ALPS protocol used in newer
"Dolphin" devices.
Signed-off-by: NYunkang Tang <yunkang.tang@cn.alps.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The error code was not set if unable to set config, so the error
condition wasn't reflected in the return value. Fix to return a
negative error code from the error handling case instead of 0.
Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: NHeiko Stuebner <heiko@sntech.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The current assumption in the elantech driver that hw version 3 touchpads
are never clickpads and hw version 4 touchpads are always clickpads is
wrong.

There are several bug reports for this, ie:
https://bugzilla.redhat.com/show_bug.cgi?id=1030802
http://superuser.com/questions/619582/right-elantech-touchpad-button-not-working-in-linux

I've spend a couple of hours wading through various bugzillas, launchpads
and forum posts to create a list of fw-versions and capabilities for
different laptop models to find a good method to differentiate between
clickpads and versions with separate hardware buttons.

Which shows that a device being a clickpad is reliable indicated by bit 12
being set in the fw_version. I've included the gathered list inside the
driver, so that we've this info at hand if we need to revisit this later.
Signed-off-by: NHans de Goede <hdegoede@redhat.com>
Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

When waking up the platform by pressing a specific key, sending a
release on that key makes it impossible to react on the event in
user-space. This is fixed by moving the input_reset_device() call to
resume instead.

[dmitry.torokhov@gmail.com: make sure we still restore LED/sound state
after resume, handle hibernation properly]
Signed-off-by: NAleksej Makarov <aleksej.makarov@sonymobile.com>
Signed-off-by: NOskar Andero <oskar.andero@sonymobile.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Simplify the code and create mandatory 'name' attribute by using
new hwmon API.

Also use is_visible to determine visible attributes instead of creating
several different attribute groups.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

New Intuos series models added a hardware switch to turn touch
data on/off. The state of the switch is reported periodically
from the tablet. To report the state the driver will emit SW_MUTE_DEVICE
events.

Reviewed_by: Chris Bagwell <chris@cnpbagwell.com>
Acked-by: NPeter Hutterer <peter.hutterer@who-t.net>
Tested-by: NJason Gerecke <killertofu@gmail.com>
Signed-off-by: NPing Cheng <pingc@wacom.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use the regmap APIs for this driver instead of custom pm8xxx
APIs. This breaks this driver's dependency on the pm8xxx APIs and
allows us to easily port it to other bus protocols in the future.
Signed-off-by: NStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of passing the pointer to the container structure just
pass the input device here. This saves a dereference in the fast
path.
Signed-off-by: NStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use the regmap APIs for this driver instead of custom pm8xxx
APIs. This breaks this driver's dependency on the pm8xxx APIs and
allows us to easily port it to other bus protocols in the future.
Signed-off-by: NStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Simplify the error paths and reduce the lines of code in this
driver by using the devm_* APIs.
Signed-off-by: NStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Include cyttsp4_core.h in cyttsp_i2c_common.c to ensure that implementation
of cyttsp_i2c_read_block_data() and cyttsp_i2c_write_block_data()
match what the rest of the driver expects.

Thus, it also eliminates the following warning in cyttsp_i2c_common.c:
drivers/input/touchscreen/cyttsp_i2c_common.c:34:5: warning: no previous prototype for ‘cyttsp_i2c_read_block_data’ [-Wmissing-prototypes]
drivers/input/touchscreen/cyttsp_i2c_common.c:64:5: warning: no previous prototype for ‘cyttsp_i2c_write_block_data’ [-Wmissing-prototypes]
Signed-off-by: NRashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: NJosh Triplett <josh@joshtriplett.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Coverity report pointet out by Dmitry
Reported-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: NMichael Hennerich <michael.hennerich@analog.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Restore previous layout of sysfs attributes that was broken by commit
3778a212 (input: serio: remove bus usage of
dev_attrs) which moved all serio device attributes into 'id' group, when
only 'type', 'proto', 'id', and 'extra' should be in 'id' group and the
rest of attributes should be attached directly to the device.
Reported-by: NThomas Hellstrom <thellstrom@vmware.com>
Tested-by: NThomas Hellstrom <thellstrom@vmware.com>
Acked-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We should be able to override firmware-provided parameters with in-kernel
data, if needed. To that effect favor platform data, if present, over
devicetree data.
Acked-by: NJoonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use the wrapper function for retrieving the platform data instead
of accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Acked-by: NFugang Duan <B38611@freescale.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Hardware supported by the driver is only found on SUPERH or
ARCH_SHMOBILE platforms. Restrict non-COMPILE_TEST compilation to them.
Signed-off-by: NLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: NSimon Horman <horms+renesas@verge.net.au>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The device uses special MPU controller that necessitates the new
initialization sequence for the device. We also define a new protocol for
the trackpad that allows reporting better resolution than older V2
protocol.
Signed-off-by: NYunkang Tang <yunkang.tang@cn.alps.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Added detection for newer Elantech touchpads, so that kernel doesn't
fall-back to default PS/2 driver. Supports touchpads released after
~August 2013.  Fixes bug:
https://lists.launchpad.net/kernel-packages/msg18481.html

Tested on an Acer Aspire S7-392-6302.

Signed-off by: Matt Walker <matt.g.d.walker@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This patch supports the separate handling of the USB transfer buffer length
and the length of the buffer used for multi packet support. For devices
supporting multiple report or diagnostic packets, the USB transfer size is now
limited to the USB endpoints wMaxPacketSize - otherwise it defaults to the
configured report packet size as before.

This fixes an issue where event reporting can be delayed for an arbitrary
time for multi packet devices. For instance the report size for eGalax devices
is defined to the 16 byte maximum diagnostic packet size as opposed to the 5
byte report packet size. In case the driver requests 16 byte from the USB
interrupt endpoint, the USB host controller driver needs to split up the
request into 2 accesses according to the endpoints wMaxPacketSize of 8 byte.
When the first transfer is answered by the eGalax device with not less than
the full 8 byte requested, the host controller has got no way of knowing
whether the touch controller has got additional data queued and will issue
the second transfer. If per example a liftoff event finishes at such a
wMaxPacketSize boundary, the data will not be available to the usbtouch driver
until a further event is triggered and transfered to the host. From user
perspective the BTN_TOUCH release event in this case is stuck until the next
touch down event.
Signed-off-by: NChristian Engelmayer <christian.engelmayer@frequentis.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We will never use packet_id before initializing it as we start with
"need_blobs == -1" and will set packet_id there.

Also use le32_to_cpu when fetching header->packet_id.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Using the IS_ENABLED() macro can make the code shorter and simpler
Signed-off-by: NFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This patch adds a new driver for the beeper controlled via GPIO pin.
The driver does not depend on the architecture and is positioned as
a replacement for the specific drivers that are used for this function.
Signed-off-by: NAlexander Shiyan <shc_work@mail.ru>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Two tablets in this series support both pen and touch. One (Intuos S)
only supports pen. This patch also updates the driver to process wireless
devices that do not support touch interface.
Tested-by: NJason Gerecke <killertofu@gmail.com>
Reviewed-by: NChris Bagwell <chris@cnpbagwell.com>
Signed-off-by: NPing Cheng <pingc@wacom.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Old single touch Tablet PCs do not have touch_max set at
wacom_features. Since touch device at lease supports one
finger, assign touch_max to 1 when touch usage is defined
in its HID Descriptor and touch_max is not pre-defined.
Tested-by: NJason Gerecke <killertofu@gmail.com>
Signed-off-by: NPing Cheng <pingc@wacom.com>
Reviewed-by: NChris Bagwell <chris@cnpbagwell.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The width and height values reported by the Intuos Pro are not in
surface units as required by the MT protocol. A simple multiplier
of 100x corrects it.
Signed-off-by: NJason Gerecke <killertofu@gmail.com>
Acked-by: NPing Cheng <pingc@wacom.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use managed irq resource to simplify the driver.
Signed-off-by: NSebastian Reichel <sre@debian.org>
Reviewed-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use dev_err() to output errors instead of dev_dbg().
Signed-off-by: NSebastian Reichel <sre@debian.org>
Reviewed-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add device tree support for twl4030 power button driver.

Adding device tree support involved converting the
driver to module_platform_driver().
Signed-off-by: NSebastian Reichel <sre@debian.org>
Acked-by: NKumar Gala <galak@codeaurora.org>
Tested-by: NFlorian Vaussard <florian.vaussard@epfl.ch>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This simplifies error handling path and allows us get rid of
tsc2007_remove().
Tested-by: NDenis Carikli <denis@eukrea.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The driver does not use poll_delay parameter, so let's remove it.
Tested-by: NDenis Carikli <denis@eukrea.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NDenis Carikli <denis@eukrea.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

For exmaple, keycode: KEY_OK(0x160) is changed by "and" operation with
KEY_MAX(0x2ff) to KEY_KPENTER(96).
Signed-off-by: NAndrew Liu <andrew.liu200917@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>