This change creates a second input device which will handle input from
a Surface Pen. The Surface Pen supplies a different packet header than
touch events, so it is simple to handle one or the other.

This patch handles both the newer Surface Pen with one button, and the
older variant with a second button to switch to Eraser mode.
Signed-off-by: NStephen Just <stephenjust@gmail.com>
Reviewed-and-tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Surface Pens can be supported by handling a second report type. Prepare
for this change.
Signed-off-by: NStephen Just <stephenjust@gmail.com>
Reviewed-and-tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The end ')' needs to be removed if the macro is ever used or there
would be a compiler error as it does not have a matching '('.
Signed-off-by: NClifton Barnes <clifton.a.barnes@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This is a basic driver for the Surface 3. I am not so sure it will work
with any firmwares as most values are encoded, but given that I only have
access to my current device with its firmware and I don't have the
datasheet, it should be OK for now.

The Surface Pen is not supported (if it is supposed to be). I'll work on
this when I get one.
Tested-by: NBastien Nocera <hadess@hadess.net>
Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Commit 4369c64c ("Input: Send events one packet at a time")
significantly reduced amount of entropy input core was feeding to the rest
of the system, because only the very first event in the event block would
be used as source of entropy.

With this change we will be calling add_input_randomness() for every event
that is not filtered by the input core as a duplicate. In addition, all
EV_SYN events are ignored.
Acked-by: NHenrik Rydberg <rydberg@bitmath.org>
Acked-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Acked-by: NJiri Kosina <jkosina@suse.cz>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NNick Dyer <nick.dyer@itdev.co.uk>
Reviewed-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The migor touchscreen driver is now available for COMPILE_TEST,
so we run into a harmless randconfig warning on ARM when CONFIG_PM
is disabled:

drivers/input/touchscreen/migor_ts.c:216:12: error: 'migor_ts_resume' defined but not used [-Werror=unused-function]
drivers/input/touchscreen/migor_ts.c:205:12: error: 'migor_ts_suspend' defined but not used [-Werror=unused-function]

This shuts up the warning by marking the two functions as __maybe_unused.
We could do the same thing by adding an #ifdef, but this version is
more reliable.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The newly added Atmal captouch driver fails to build when CONFIG_I2C
is disabled:

drivers/input/misc/atmel_captouch.c: In function 'atmel_read':
drivers/input/misc/atmel_captouch.c:115:8: error: implicit declaration of function 'i2c_transfer' [-Werror=implicit-function-declaration]

This adds an explicit Kconfig dependency to prevent the broken
configuration.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Fixes: b06d43f7 ("Input: add Atmel Captouch Button driver")
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add I2C driver for Atmel Capacitive Touch Button device.
Signed-off-by: NHung-yu Wu <hywu@google.com>
Signed-off-by: NGrant Grundler <grundler@chromium.org>
Acked-by: NRob Herring <robh@kernel.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The driver only has runtime but no build time dependency with SH_MIGOR, so
it can be built for testing purposes if the COMPILE_TEST option is enabled.

This is useful to have more build coverage and make sure that drivers are
not affected by changes that could cause build regressions.
Signed-off-by: NJavier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

There is a typo in the driver for the I2C device table that is passed to
the MODULE_DEVICE_TABLE() macro, this leads to the following build error:

  CC [M]  drivers/input/touchscreen//migor_ts.o
drivers/input/touchscreen//migor_ts.c:233:21: error: 'migor_ts' undeclared here (not in a function)
 MODULE_DEVICE_TABLE(i2c, migor_ts);
                     ^
drivers/input/touchscreen//migor_ts.c:233:31: error: '__mod_i2c__migor_ts_device_table' aliased to undefined symbol 'migor_ts'
 MODULE_DEVICE_TABLE(i2c, migor_ts);
                               ^
scripts/Makefile.build:295: recipe for target 'drivers/input/touchscreen//migor_ts.o' failed
make[1]: *** [drivers/input/touchscreen//migor_ts.o] Error 1
Makefile:1446: recipe for target '_module_drivers/input/touchscreen/' failed
make: *** [_module_drivers/input/touchscreen/] Error 2
Signed-off-by: NJavier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

fix checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of
'unsigned''
Signed-off-by: NClifton Barnes <clifton.a.barnes@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: NMing Lei <ming.lei@canonical.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The CM109 driver reported key press events of volume up / down and
record / playback mute buttons, but no release events. Report those events
properly by handling volume and mute keys seperately. For the record and
playback mute buttons, only presses are registered by the CM109, therefore
simulate press-n-release. This fixes the volume control buttons of various
USB headsets.
Signed-off-by: NFlorian Euchner <florian.euchner@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Since memory for a private data is allocated by kzalloc() there is no
need to fill it with zeroes immediately after the allocation.
Signed-off-by: NVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The bitwise shift operator has lower priority than plus operator. So the
values on macros should be enclosed in parentheses.

For example, "(1 << 4 + 1)" means "(1 << (4 + 1))", but it is not expected
by the macros.

And also fix other two coding style problems reported by
scripts/checkpatch.pl.
Signed-off-by: NRui Teng <rui.teng@linux.vnet.ibm.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The mutex does not seem to be needed. twl4030-vibra doesn't
use one either.
Signed-off-by: NH. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

In Cygnus SOC touch screen controller registers are shared with ADC and
flex timer. Using readl/writel could lead to race condition. So touch
screen driver is enhanced to support register access using syscon framework
API's to take care of mutually exclusive access.
Signed-off-by: NRaveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Reviewed-by: NRay Jui <ray.jui@broadcom.com>
Reviewed-by: NScott Branden <scott.branden@broadcom.com>
Acked-by: NRob Herring <robh@kernel.org>
Acked-by: NFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of doing the dance with macro that either resolves to a pointer or
NULL, let's switch to using SIMPLE_DEV_PM_OPS().

Also let's mark suspend and resume methods as __maybe_unused instead of
guarding them with an #ifdef and rely on linker to drop unused code. Doing
so should allow better compile coverage.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Commit f799a3d8 ("Input: omap-keypad:
Remove dependencies to mach includes") removed users of the above
functions, but left them in the code.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

There is no reason to have empty suspend and resume stubs.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

As of 35f8679f ("Input: omap-keypad -
remove dead check") we no longer declare keypresses as spurious, therefore
we can use constant delay between scans.
Suggested-by: NJanusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The device can now easily be derived from the interface.
Stop leaving a private copy.
Signed-off-by: NOliver Neukum <ONeukum@suse.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The device can now easily be derived from the interface.
Stop leaving a private copy.
Signed-off-by: NOliver Neukum <oneukum@suse.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The device can now easily be derived from the interface.
Stop leaving a private copy.
Signed-off-by: NOliver Neukum <oneukum@suse.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The device can now easily be derived from the interface.
Stop leaving a private copy.
Signed-off-by: NOliver Neukum <ONeukum@suse.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

During the initialisation the driver uses a buffer on the stack for DMA.
That violates the cache coherency rules. The fix is to allocate the buffer
with kmalloc().
Signed-off-by: NOliver Neukum <ONeukum@suse.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The ati_remote2 driver expects at least two interfaces with one
endpoint each. If given malicious descriptor that specify one
interface or no endpoints, it will crash in the probe function.
Ensure there is at least two interfaces and one endpoint for each
interface before using it.

The full disclosure: http://seclists.org/bugtraq/2016/Mar/90Reported-by: NRalf Spenneberg <ralf@spenneberg.net>
Signed-off-by: NVladis Dronov <vdronov@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Looks like the fimware 8.2 still has the extra buttons spurious release
bug.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=114321
Cc: stable@vger.kernel.org
Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Originally the irq_mask member of rmi_function was a pointer. Then it was
switched to being a zero length array. However, the checks for a NULL
pointer where not removed.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The Windows driver's settings dialog contains a visualization of the
regions for the hardware edge scrolling capability, which uses a
temporarily-enabled limited-resolution absolute mode.

This patch enables this during normal operation, and combines the
absolute packets with the existing relative packets to provide
accurate absolute position and touch reporting.

It also adds documentation for all known gesture packets and
initialization commands.
Reviewed-by: NChris Diamand <chris@diamand.org>
Signed-off-by: NRichard Pospesel <pospeselr@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

A malicious device missing interface can make the driver oops.
Add sanity checking.
Signed-off-by: NOliver Neukum <ONeukum@suse.com>
CC: stable@vger.kernel.org
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add hw_version sysfs attribute for retrieving hardware information
from firmware.
Signed-off-by: NSangwon Jee <jeesw@melfas.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

There is a typo so we have && instead of &.

Fixes: ff8f8370 ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Acked-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The powermate driver expects at least one valid USB endpoint in its
probe function.  If given malicious descriptors that specify 0 for
the number of endpoints, it will crash.  Validate the number of
endpoints on the interface before using them.

The full report for this issue can be found here:
http://seclists.org/bugtraq/2016/Mar/85Reported-by: NRalf Spenneberg <ralf@spenneberg.net>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: NJosh Boyer <jwboyer@fedoraproject.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

On error syscon_regmap_lookup_by_phandle() returns ERR_PTR() value,
which makes a check for NULL invalid and may lead to oops on error
path.
Signed-off-by: NVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add devicetree binding for SPI devices.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Acked-by: NRob Herring <robh@kernel.org>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add the transport driver for devices using RMI4 over SPI.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

RMI4 F30 supports input from clickpad buttons and controls LEDs located
on the touchpad PCB. This patch adds support of the clickpad buttons and
defers supporting LEDs for the future.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Function 12 implements 2D touch position sensor for newer Synaptics touch
devices. It replaces F11 and no device will contain both functions.
Signed-off-by: NAndrew Duggan <aduggan@synaptics.com>
Signed-off-by: NChristopher Heiny <cheiny@synaptics.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NLinus Walleij <linus.walleij@linaro.org>
Tested-by: NBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>