1. 09 8月, 2010 1 次提交
    • W
      watchdog: s3c2410_wdt - Fix removing of platform device · 9a372563
      Wim Van Sebroeck 提交于
      When removing the watchdog platform device, we need to
      disable the access to userspace first. It makes no sense
      to remove the drivers clock, irq's, ... and then disable
      userspace access.
      the order of removal has also been changed so that it
      is the reverse of probing (this way the clock is also
      disabled sooner).
      
      Cc: Ben Dooks <ben-linux@fluff.org>
      Signed-off-by: NWim Van Sebroeck <wim@iguana.be>
      9a372563
  2. 25 5月, 2010 2 次提交
  3. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  4. 24 12月, 2009 1 次提交
  5. 04 12月, 2009 1 次提交
  6. 18 6月, 2009 1 次提交
  7. 30 10月, 2008 1 次提交
  8. 29 10月, 2008 1 次提交
  9. 27 8月, 2008 3 次提交
  10. 16 8月, 2008 1 次提交
    • A
      [ARM] Fix a pile of broken watchdog drivers · 8b5942c3
      Adrian Bunk 提交于
      These patches from Adrian fix:
      - ixp4xx_wdt: 20d35f3e
        CC      drivers/watchdog/ixp4xx_wdt.o
      ixp4xx_wdt.c:32: error: expected '=', ',', ';', 'asm' or '__attribute__'
      ixp4xx_wdt.c: In function 'wdt_enable':
      ixp4xx_wdt.c:41: error: 'wdt_lock' undeclared (first use in this
      ixp4xx_wdt.c:41: error: (Each undeclared identifier is reported only
      ixp4xx_wdt.c:41: error: for each function it appears in.)
      ixp4xx_wdt.c: In function 'wdt_disable':
      ixp4xx_wdt.c:52: error: 'wdt_lock' undeclared (first use in this
      ixp4xx_wdt.c: In function 'ixp4xx_wdt_init':
      ixp4xx_wdt.c:186: error: 'wdt_lock' undeclared (first use in this
      make[3]: *** [drivers/watchdog/ixp4xx_wdt.o] Error 1
      
      - at91rm9200_wdt: 2760600d
        CC      drivers/watchdog/at91rm9200_wdt.o
      at91rm9200_wdt.c:188: error: 'at91_wdt_ioctl' undeclared here (not in a
      make[3]: *** [drivers/watchdog/at91rm9200_wdt.o] Error 1
      
      - wdt285: d0e58eed
        CC [M]  drivers/watchdog/wdt285.o
      wdt285.c: In function 'footbridge_watchdog_init':
      wdt285.c:211: error: 'KERN_WARN' undeclared (first use in this function)
      wdt285.c:211: error: (Each undeclared identifier is reported only once
      wdt285.c:211: error: for each function it appears in.)
      wdt285.c:212: error: expected ')' before string constant
      make[3]: *** [drivers/watchdog/wdt285.o] Error 1
      
      And this patch from rmk:
      - s3c2410_wdt: 41dc8b72
        CC      drivers/watchdog/s3c2410_wdt.o
      s3c2410_wdt.c: In function `s3c2410wdt_start':
      s3c2410_wdt.c:161: warning: `return' with a value, in function returning void
      Reported-by: NAdrian Bunk <bunk@kernel.org>
      Signed-off-by: NAdrian Bunk <bunk@kernel.org>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      8b5942c3
  11. 08 8月, 2008 1 次提交
  12. 07 8月, 2008 1 次提交
  13. 06 8月, 2008 1 次提交
    • W
      [WATCHDOG] Coding style - Indentation - part 2 · 0c06090c
      Wim Van Sebroeck 提交于
      This brings the watchdog drivers into line with coding style.
      This patch takes cares of the indentation as described in chapter 1.
      Main changes:
      * Re-structure the ioctl switch call for all drivers as follows:
      	switch (cmd) {
      	case WDIOC_GETSUPPORT:
      	case WDIOC_GETSTATUS:
      	case WDIOC_GETBOOTSTATUS:
      	case WDIOC_GETTEMP:
      	case WDIOC_SETOPTIONS:
      	case WDIOC_KEEPALIVE:
      	case WDIOC_SETTIMEOUT:
      	case WDIOC_GETTIMEOUT:
      	case WDIOC_GETTIMELEFT:
      	default:
      	}
      
      This to make the migration from the drivers to the uniform watchdog
      device driver easier in the future.
      Signed-off-by: NWim Van Sebroeck <wim@iguana.be>
      0c06090c
  14. 05 8月, 2008 1 次提交
  15. 21 6月, 2008 1 次提交
  16. 11 4月, 2008 1 次提交
  17. 06 3月, 2008 1 次提交
  18. 18 10月, 2007 1 次提交
  19. 25 7月, 2007 1 次提交
  20. 18 6月, 2007 2 次提交
  21. 07 5月, 2007 1 次提交
  22. 28 1月, 2007 1 次提交
  23. 20 12月, 2006 1 次提交
  24. 19 12月, 2006 1 次提交
  25. 08 10月, 2006 1 次提交
  26. 05 10月, 2006 1 次提交
    • D
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells 提交于
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: NDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  27. 03 10月, 2006 2 次提交
  28. 04 7月, 2006 1 次提交
  29. 01 7月, 2006 1 次提交
  30. 16 5月, 2006 1 次提交
  31. 08 1月, 2006 1 次提交
  32. 04 1月, 2006 1 次提交
  33. 10 11月, 2005 1 次提交
  34. 02 11月, 2005 1 次提交
  35. 30 10月, 2005 1 次提交