- 19 4月, 2016 1 次提交
-
-
由 Nobuo Iwata 提交于
Dear all, 1. Overview In current USB/IP implementation, event kernel threads are created for each port. The functions of the threads are closing connection and error handling so they don't have not so many events to handle. There's no need to have thread for each port. BEFORE) vhci side - VHCI_NPORTS(8) threads are created. $ ps aux | grep usbip root 10059 0.0 0.0 0 0 ? S 17:06 0:00 [usbip_eh] root 10060 0.0 0.0 0 0 ? S 17:06 0:00 [usbip_eh] root 10061 0.0 0.0 0 0 ? S 17:06 0:00 [usbip_eh] root 10062 0.0 0.0 0 0 ? S 17:06 0:00 [usbip_eh] root 10063 0.0 0.0 0 0 ? S 17:06 0:00 [usbip_eh] root 10064 0.0 0.0 0 0 ? S 17:06 0:00 [usbip_eh] root 10065 0.0 0.0 0 0 ? S 17:06 0:00 [usbip_eh] root 10066 0.0 0.0 0 0 ? S 17:06 0:00 [usbip_eh] BEFORE) stub side - threads will be created every bind operation. $ ps aux | grep usbip root 8368 0.0 0.0 0 0 ? S 17:56 0:00 [usbip_eh] root 8399 0.0 0.0 0 0 ? S 17:56 0:00 [usbip_eh] This patch put event threads of stub and vhci driver as one workqueue. AFTER) only one event threads in each vhci and stub side. $ ps aux | grep usbip root 10457 0.0 0.0 0 0 ? S< 17:47 0:00 [usbip_event] 2. Modification to usbip_event.c BEFORE) kernel threads are created in usbip_start_eh(). AFTER) one workqueue is created in new usbip_init_eh(). Event handler which was main loop of kernel thread is modified to workqueue handler. Events themselves are stored in struct usbip_device - same as before. usbip_devices which have event are listed in event_list. The handler picks an element from the list and wakeup usbip_device. The wakeup method is same as before. usbip_in_eh() substitutes statement which checks whether functions are called from eh_ops or not. In this function, the worker context is used for the checking. The context will be set in a variable in the beginning of first event handling. usbip_in_eh() is used in event handler so it works well. 3. Modifications to programs using usbip_event.c Initialization and termination of workqueue are added to init and exit routine of usbip_core respectively. A. version info v2) # Merged 1/2 event handler itself and 2/2 user programs because of auto build fail at 1/2 casued unmodified user programs in 1/2. Signed-off-by: NNobuo Iwata <nobuo.iwata@fujixerox.co.jp> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 31 3月, 2016 1 次提交
-
-
由 Ignat Korchagin 提交于
Fix potential out-of-bounds write to urb->transfer_buffer usbip handles network communication directly in the kernel. When receiving a packet from its peer, usbip code parses headers according to protocol. As part of this parsing urb->actual_length is filled. Since the input for urb->actual_length comes from the network, it should be treated as untrusted. Any entity controlling the network may put any value in the input and the preallocated urb->transfer_buffer may not be large enough to hold the data. Thus, the malicious entity is able to write arbitrary data to kernel memory. Signed-off-by: NIgnat Korchagin <ignat.korchagin@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 26 8月, 2014 1 次提交
-
-
由 Valentina Manea 提交于
At this point, USB/IP kernel code is fully functional and can be moved out of staging. Signed-off-by: NValentina Manea <valentina.manea.m@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 02 4月, 2014 1 次提交
-
-
由 Al Viro 提交于
Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
-
- 20 3月, 2014 1 次提交
-
-
由 Cédric Cabessa 提交于
Signed-off-by: NCédric Cabessa <ced@ryick.net> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 07 3月, 2014 1 次提交
-
-
由 John de la Garza 提交于
Added code to check return value of sscanf. Signed-off-by: NJohn de la Garza <john@jjdev.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 08 2月, 2014 1 次提交
-
-
由 Shuah Khan 提交于
Change usbip_dump_usb_device() to use usb_speed_string() and remove the code that does switch on udev->speed and builds custom speed strings. Signed-off-by: NShuah Khan <shuah.kh@samsung.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 16 12月, 2013 1 次提交
-
-
由 Sankha Narayan Guria 提交于
This removes the double initialization of the msg_namelen variable. Signed-off-by: NSankha Narayan Guria <sankha93@gmail.com> Signed-off-by: NJiri Kosina <jkosina@suse.cz>
-
- 11 11月, 2013 1 次提交
-
-
由 Himangi Saraogi 提交于
This patch removes the checkpatch.pl warnings "quoted string split accross lines" in usbip_common.c. Signed-off-by: NHimangi Saraogi <himangi774@gmail.com> Reviewed-by: NJosh Triplett <josh@joshtriplett.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 27 8月, 2013 1 次提交
-
-
由 Greg Kroah-Hartman 提交于
It's easier to audit the sysfs files if they use the RO/RW macros, so convert the usbip code to them. Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 06 4月, 2013 1 次提交
-
-
由 Stefan Reif 提交于
Fix an indent. Signed-off-by: NStefan Reif <ke42caxa@cip.cs.fau.de> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 23 2月, 2013 1 次提交
-
-
由 Al Viro 提交于
Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
-
- 18 1月, 2013 1 次提交
-
-
由 Jake Champlin 提交于
Fixed coding style issue with single line braces. Signed-off-by: NJake Champlin <jake.champlin.27@gmail.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 23 10月, 2012 3 次提交
-
-
由 Bernard Blackham 提交于
usbip takes a reference on a struct file which is passed in via sysfs. Previously, this reference was never cleaned up, although the socket it referred to was. This patch drops the corresponding reference (found with the socket's ->file backpointer) instead of just closing the socket. Signed-off-by: NBernard Blackham <b-linuxgit@largestprime.net> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Bart Westgeest 提交于
Removed commented-out code, obsolete comments, and fixed comment typos. Signed-off-by: NBart Westgeest <bart@elbrys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
由 Bart Westgeest 提交于
Replaced pointer arithmetic by using array indexing, and changed function return type for usbip_alloc_iso_desc_pdu from 'void*' to 'struct usbip_iso_packet_descriptor'. Signed-off-by: NBart Westgeest <bart@elbrys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 11 9月, 2012 1 次提交
-
-
由 Lan Tianyu 提交于
The usb_device structure contains an array of usb_device "children". This array is only valid if the usb_device is a hub, so it makes no sense to store it there. Instead, store the usb_device child in its parent usb_port structure. Since usb_port is an internal USB core structure, add a new function to get the USB device child, usb_hub_find_child(). Add a new macro, usb_hub_get_each_child(), to iterate over all the children attached to a particular USB hub. Remove the printing the USB children array pointer from the usb-ip driver, since it's really not necessary. Acked-by: NAlan Stern <stern@rowland.harvard.edu> Signed-off-by: NLan Tianyu <tianyu.lan@intel.com> Signed-off-by: NSarah Sharp <sarah.a.sharp@linux.intel.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 18 8月, 2012 1 次提交
-
-
由 W. Trevor King 提交于
Now usbip_common.c's pr_fmt is the only thing setup by CONFIG_USBIP_DEBUG that you can't subsequently alter using this parameter. Signed-off-by: NW. Trevor King <wking@tremily.us> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 15 5月, 2012 1 次提交
-
-
由 Greg Kroah-Hartman 提交于
This reverts commit bebc56d5. The call here is fragile and not well thought out, so revert it, it's not fully baked yet and I don't want this to go into 3.5. Cc: Lan Tianyu <tianyu.lan@intel.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 12 5月, 2012 1 次提交
-
-
由 Lan Tianyu 提交于
Move child's pointer to the struct usb_hub_port since the child device is directly associated with the port. Provide usb_get_hub_child_device() to get child's pointer. Signed-off-by: NLan Tianyu <tianyu.lan@intel.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 10 2月, 2012 1 次提交
-
-
由 Bart Westgeest 提交于
The function usbip_pad_iso never returns anything but 0 (success). Signed-off-by: NBart Westgeest <bart@elbrys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 23 12月, 2011 1 次提交
-
-
由 Bart Westgeest 提交于
The usbip_xmit function supported sending and receiving data, however the sending part of the function was never used/executed. Renamed the function to usbip_recv, and removed the unused code. Signed-off-by: NBart Westgeest <bart@elbrys.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
- 01 11月, 2011 1 次提交
-
-
由 Paul Gortmaker 提交于
This 2nd batch of implicit module.h users only appeared when we removed the unnecessary module.h from include/linux/miscdevice.h [The 1st batch is already present in Greg's staging tree.] Signed-off-by: NPaul Gortmaker <paul.gortmaker@windriver.com>
-
- 08 6月, 2011 4 次提交
-
-
由 Akshay Joshi 提交于
In this file, in certain places, newline characters in pr_debug() calls had whitespace before them. This patch removes this extraneous whitespace. Signed-off-by: NAkshay Joshi <me@akshayjoshi.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
由 matt mooney 提交于
Change the prefix of the __init and __exit functions to usbip_core_ to correspond with the modules name. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
由 matt mooney 提交于
Change pakcet to packet in usbip_iso_packet_correct_endian(). Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
由 matt mooney 提交于
Also, fix a few alignment issues that were originally missed. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
- 20 5月, 2011 1 次提交
-
-
由 matt mooney 提交于
This switches all of the usbip_u{dbg,err,info} and printk statements to dev_<level>, if possible, or pr_<level> macros. And removes a few unnecessary debug statements. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
- 18 5月, 2011 1 次提交
-
-
由 David Chang 提交于
Fix number_of_packets wrong endian conversion in function correct_endian_ret_submit() Signed-off-by: NDavid Chang <dchang@novell.com> Acked-by: NArjan Mels <arjan.mels@gmx.net> Cc: stable <stable@kernel.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
- 13 5月, 2011 2 次提交
-
-
由 matt mooney 提交于
Change modules usbip_common_mod to usbip-core and usbip to usbip-host; edit configuration option help text; rename CONFIG options to use a USBIP prefix and change COMMON to CORE in both the Kconfig and Makefiles; edit the menu entries; and edit the driver descriptions. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
由 matt mooney 提交于
Modify header directives to include what is needed by each file and not already included in its own header. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
- 12 5月, 2011 2 次提交
-
-
由 matt mooney 提交于
Having separate versions in this situation makes little sense, so USBIP_VERSION will be used by all modules. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
由 matt mooney 提交于
Change CONFIG_USB_IP_DEBUG_ENABLE to CONFIG_USB_IP_DEBUG, and move ccflags- to the head of the makefile. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
- 07 5月, 2011 4 次提交
-
-
由 matt mooney 提交于
Modify description and email address for usbip_common_mod; export module version number; and modify __init messages slightly. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
由 matt mooney 提交于
Also, removes the one-line comments that were associated with some of the dividers because they provided no additional information. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
由 matt mooney 提交于
For consistency, a break statement is added to all default cases that do not jump to a label. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
由 matt mooney 提交于
Fix alignment for consistency, checkpatch.pl warning of line over 80 characters, and remove extraneous lines. Signed-off-by: Nmatt mooney <mfm@muteddisk.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
- 07 4月, 2011 2 次提交
-
-
由 Arjan Mels 提交于
For isochronous packets the actual_length is the sum of the actual length of each of the packets, however between the packets might be padding, so it is not sufficient to just send the first actual_length bytes of the buffer. To fix this and simultanesouly optimize the bandwidth the content of the isochronous packets are send without the padding, the padding is restored on the receiving end. Signed-off-by: NArjan Mels <arjan.mels@gmx.net> Cc: Takahiro Hirofuchi <hirofuchi@users.sourceforge.net> Cc: Max Vozeler <max@vozeler.com> Cc: stable <stable@kernel.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
由 Arjan Mels 提交于
The number_of_packets was not transmitted for RET_SUBMIT packets. The linux client used the stored number_of_packet from the submitted request. The windows userland client does not do this however and needs to know the number_of_packets to determine the size of the transmission. Signed-off-by: NArjan Mels <arjan.mels@gmx.net> Cc: Takahiro Hirofuchi <hirofuchi@users.sourceforge.net> Cc: Max Vozeler <max@vozeler.com> Cc: stable <stable@kernel.org> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-
- 03 3月, 2011 1 次提交
-
-
由 Arnd Bergmann 提交于
usbip has its own infrastructure for managing kernel threads, similar to kthread. By changing it to use the standard functions, we can simplify the code and get rid of one of the last BKL users at the same time. Includes changes suggested by Max Vozeler. Signed-off-by: NArnd Bergmann <arnd@arndb.de> Cc: Greg Kroah-Hartman <gregkh@suse.de> Cc: Takahiro Hirofuchi <hirofuchi@users.sourceforge.net> Cc: Max Vozeler <max@vozeler.com> Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
-