1. 24 3月, 2018 2 次提交
  2. 20 2月, 2018 1 次提交
  3. 14 2月, 2018 1 次提交
    • J
      mlxsw: spectrum_router: Fix error path in mlxsw_sp_vr_create · 0f2d2b27
      Jiri Pirko 提交于
      Since mlxsw_sp_fib_create() and mlxsw_sp_mr_table_create()
      use ERR_PTR macro to propagate int err through return of a pointer,
      the return value is not NULL in case of failure. So if one
      of the calls fails, one of vr->fib4, vr->fib6 or vr->mr4_table
      is not NULL and mlxsw_sp_vr_is_used wrongly assumes
      that vr is in use which leads to crash like following one:
      
      [ 1293.949291] BUG: unable to handle kernel NULL pointer dereference at 00000000000006c9
      [ 1293.952729] IP: mlxsw_sp_mr_table_flush+0x15/0x70 [mlxsw_spectrum]
      
      Fix this by using local variables to hold the pointers and set vr->*
      only in case everything went fine.
      
      Fixes: 76610ebb ("mlxsw: spectrum_router: Refactor virtual router handling")
      Fixes: a3d9bc50 ("mlxsw: spectrum_router: Extend virtual routers with IPv6 support")
      Fixes: d42b0965 ("mlxsw: spectrum_router: Add multicast routes notification handling functionality")
      Signed-off-by: NJiri Pirko <jiri@mellanox.com>
      Reviewed-by: NIdo Schimmel <idosch@mellanox.com>
      Signed-off-by: NJiri Pirko <jiri@mellanox.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      0f2d2b27
  4. 24 1月, 2018 1 次提交
  5. 22 1月, 2018 3 次提交
  6. 19 1月, 2018 1 次提交
  7. 15 1月, 2018 2 次提交
  8. 03 1月, 2018 1 次提交
  9. 20 12月, 2017 1 次提交
  10. 28 11月, 2017 4 次提交
  11. 14 11月, 2017 1 次提交
  12. 04 11月, 2017 14 次提交
  13. 03 11月, 2017 4 次提交
  14. 01 11月, 2017 1 次提交
    • D
      mlxsw: spectrum_router: Return extack message on abort due to fib rules · 1f279233
      David Ahern 提交于
      Adding a FIB rule on a spectrum platform silently aborts FIB offload:
          $ ip ru add pref 99 from all to 192.168.1.1 table 10
          $ dmesg -c
          [  623.144736] mlxsw_spectrum 0000:03:00.0: FIB abort triggered. Note that FIB entries are no longer being offloaded to this device.
      
      This patch reworks FIB rule handling to return a message to the user:
          $ ip ru add pref 99 from all to 8.8.8.8 table 11
          Error: spectrum: FIB rules not supported. Aborting offload.
      
      spectrum currently only checks whether the fib rule is a default rule or
      an l3mdev rule, both of which it knows how to handle. Any other it aborts
      FIB offload. Move the processing to check the rule type inline with the
      user request. If the rule is an unsupported one, then a work queue entry
      is used to abort the offload. Change the rule delete handling to just
      return since it does nothing at the moment.
      Signed-off-by: NDavid Ahern <dsahern@gmail.com>
      Reviewed-by: NIdo Schimmel <idosch@mellanox.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      1f279233
  15. 23 10月, 2017 3 次提交