1. 15 6月, 2010 22 次提交
  2. 08 6月, 2010 17 次提交
  3. 06 6月, 2010 1 次提交
    • D
      iwlwifi: fix wrapping when handling aggregated batches · f668da2f
      Daniel Halperin 提交于
      Fairly complex code in iwlagn_tx_status_reply_tx handle the status reports for
      aggregated packet batches sent by the NIC. This code aims to handle the case
      where the NIC retransmits failed packets from a previous batch; the status
      information for these packets can sometimes be inserted in the middle of a
      batch and are actually not in order by sequence number! (I verified this can
      happen with printk's in the function.)
      
      The code in question adaptively identifies the "first" frame of the batch,
      taking into account that it may not be the one corresponding to the first agg
      status report, and also handles the case when the set of sent packets wraps the
      256-character entry buffer. It generates the agg->bitmap field of sent packets
      which is later compared to the BlockAck response from the receiver to see which
      frames of those sent in this batch were ACKed. A small logic error (wrapping by
      0xff==255 instead of 0x100==256) was causing the agg->bitmap to be set
      incorrectly.
      
      Fix this wrapping code, and add extensive comments to clarify what is going on.
      Signed-off-by: NDaniel Halperin <dhalperi@cs.washington.edu>
      Signed-off-by: NReinette Chatre <reinette.chatre@intel.com>
      f668da2f