1. 04 11月, 2014 3 次提交
    • D
      [media] stv090x: remove indent levels in stv090x_get_coldlock() · 66ae9fc2
      Dan Carpenter 提交于
      This code is needlessly complicated and checkpatch.pl complains that we
      go over the 80 characters per line limit.
      
      If we flip the "if (!lock) {" test to "if (lock) return;" then we can
      remove an indent level from the rest of the function.
      
      We can add two returns in the "if (state->srate >= 10000000) {"
      condition and move the else statement back an additional indent level.
      
      There is another "if (!lock) {" check which can be removed since we have
      already checked "lock" and know it is zero at this point.  This second
      check on "lock" is also a problem because it sets off a static checker
      warning.  I have reviewed this code for some time to see if something
      else was intended, but have concluded that it was simply an oversight
      and should be removed.  Removing this duplicative check gains us an
      third indent level.
      Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      66ae9fc2
    • S
      [media] DocBook media: Clarify V4L2_FIELD_ANY for drivers · 9fd1f310
      Simon Farnsworth 提交于
      Documentation for enum v4l2_field did not make it clear that V4L2_FIELD_ANY
      is only acceptable as input to the kernel, not as a response from the
      driver.
      
      Make it clear, to stop userspace developers like me assuming it can be
      returned by the driver.
      Signed-off-by: NSimon Farnsworth <simon.farnsworth@onelan.co.uk>
      Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      9fd1f310
    • J
      [media] saa7146: turn bothersome error into a debug message · 847713ea
      Johann Klammer 提交于
      After updating the kernel to 3.14.15 I am seeing these messages:
      
      [273684.964081] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273690.020061] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273695.076082] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273700.132077] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273705.188070] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273710.244066] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273715.300187] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273720.356068] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273725.412188] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273730.468094] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273735.524070] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273740.580176] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      
      filling up the logs(one about every 5 seconds).
      
      Other posts suggests that it is not actually an error on cards without a
      CI interface. Here's a patch that turns it into a debug message, so it
      does not clobber the logs.
      Signed-off-by: NJohann Klammer <klammerj@a1.net>
      Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      847713ea
  2. 03 11月, 2014 37 次提交