1. 03 3月, 2014 1 次提交
  2. 27 2月, 2014 1 次提交
  3. 18 2月, 2014 1 次提交
    • E
      usbnet: remove generic hard_header_len check · eb85569f
      Emil Goode 提交于
      This patch removes a generic hard_header_len check from the usbnet
      module that is causing dropped packages under certain circumstances
      for devices that send rx packets that cross urb boundaries.
      
      One example is the AX88772B which occasionally send rx packets that
      cross urb boundaries where the remaining partial packet is sent with
      no hardware header. When the buffer with a partial packet is of less
      number of octets than the value of hard_header_len the buffer is
      discarded by the usbnet module.
      
      With AX88772B this can be reproduced by using ping with a packet
      size between 1965-1976.
      
      The bug has been reported here:
      
      https://bugzilla.kernel.org/show_bug.cgi?id=29082
      
      This patch introduces the following changes:
      - Removes the generic hard_header_len check in the rx_complete
        function in the usbnet module.
      - Introduces a ETH_HLEN check for skbs that are not cloned from
        within a rx_fixup callback.
      - For safety a hard_header_len check is added to each rx_fixup
        callback function that could be affected by this change.
        These extra checks could possibly be removed by someone
        who has the hardware to test.
      - Removes a call to dev_kfree_skb_any() and instead utilizes the
        dev->done list to queue skbs for cleanup.
      
      The changes place full responsibility on the rx_fixup callback
      functions that clone skbs to only pass valid skbs to the
      usbnet_skb_return function.
      Signed-off-by: NEmil Goode <emilgoode@gmail.com>
      Reported-by: NIgor Gnatenko <i.gnatenko.brain@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      eb85569f
  4. 07 12月, 2013 1 次提交
  5. 26 10月, 2013 1 次提交
  6. 23 10月, 2013 2 次提交
  7. 13 8月, 2013 1 次提交
  8. 04 8月, 2013 1 次提交
  9. 28 7月, 2013 1 次提交
    • M
      USBNET: centralize computing of max rx/tx qlen · a88c32ae
      Ming Lei 提交于
      This patch centralizes computing of max rx/tx qlen, because:
      
      - RX_QLEN()/TX_QLEN() is called in hot path
      - computing depends on device's usb speed, now we have ls/fs, hs, ss,
      so more checks need to be involved
      - in fact, max rx/tx qlen should not only depend on device USB
      speed, but also depend on ethernet link speed, so we need to
      consider that in future.
      - if SG support is done, max tx qlen may need change too
      
      Generally, hard_mtu and rx_urb_size are changed in bind(), reset()
      and link_reset() callback, and change mtu network operation, this
      patches introduces the API of usbnet_update_max_qlen(), and calls
      it in above path.
      Signed-off-by: NMing Lei <ming.lei@canonical.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a88c32ae
  10. 27 7月, 2013 1 次提交
    • E
      usbnet: do not pretend to support SG/TSO · 20f01703
      Eric Dumazet 提交于
      usbnet doesn't support yet SG, so drivers should not advertise SG or TSO
      capabilities, as they allow TCP stack to build large TSO packets that
      need to be linearized and might use order-5 pages.
      
      This adds an extra copy overhead and possible allocation failures.
      
      Current code ignore skb_linearize() return code so crashes are even
      possible.
      
      Best is to not pretend SG/TSO is supported, and add this again when/if
      usbnet really supports SG for devices who could get a performance gain.
      
      Based on a prior patch from Freddy Xin <freddy@asix.com.tw>
      Signed-off-by: NEric Dumazet <edumazet@google.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      20f01703
  11. 29 6月, 2013 2 次提交
  12. 12 4月, 2013 1 次提交
  13. 03 3月, 2013 1 次提交
    • F
      ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver · e2ca90c2
      Freddy Xin 提交于
      This is a resubmission.
      Added kfree() in ax88179_get_eeprom to prevent memory leakage.
      Modified "__le16 rxctl" to "u16 rxctl" in "struct ax88179_data" and removed pointless casts.
      Removed asix_init and asix_exit functions and added "module_usb_driver(ax88179_178a_driver)".
      Fixed endianness issue on big endian systems and verified this driver on iBook G4.
      Removed steps that change net->features in ax88179_set_features function.
      Added "const" to ethtool_ops structure and fixed the coding style of AX88179_BULKIN_SIZE array.
      Fixed the issue that the default MTU is not 1500.
      Added ax88179_change_mtu function and enabled the hardware jumbo frame function to support an
      MTU higher than 1500.
      Fixed indentation and empty line coding style errors.
      The _nopm version usb functions were added to access register in suspend and resume functions.
      Serveral variables allocted dynamically were removed and replaced by stack variables.
      ax88179_get_eeprom were modified from asix_get_eeprom in asix_common.
      
      This patch adds a driver for ASIX's AX88179 family of USB 3.0/2.0
      to gigabit ethernet adapters. It's based on the AX88xxx driver but
      the usb commands used to access registers for AX88179 are completely different.
      This driver had been verified on x86 system with AX88179/AX88178A and
      Sitcomm LN-032 USB dongles.
      Signed-off-by: NFreddy Xin <freddy@asix.com.tw>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      e2ca90c2