Align the lines of some defines in wilc_errorsupport.h
Signed-off-by: NChaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

change own data type(WILC_Char) to common data type(char)
Signed-off-by: NDean Lee <dean.lee@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Change comment style and remove extra spaces before macro names to
avoid exceeding 80 characters.
Signed-off-by: Nmatt mooney <mfm@muteddisk.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

If CONFIG_88EU_AP_MODE is undefined, OnAuth() is never referenced.

Fixes warning:
  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2725:21: warning: ‘OnAuth’ defined but not used [-Wunused-function]
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Fixes: 68345dd7 ("staging: rtl8188eu: rtw_mlme_ext.c: unexport message callbacks")
Cc: Greg Kroah-Hartman <gregkh@linux.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

If CONFIG_88EU_AP_MODE is undefined, issue_asocrsp() is never referenced.

Fixes warning:
  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:891:13: warning: ‘issue_asocrsp’ defined but not used [-Wunused-function]
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Fixes: 782eddd7 ("staging: rtl8188eu: unexport internal functions")
Cc: Greg Kroah-Hartman <gregkh@linux.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes the warning "space prohibited between
function name and open parenthesis"given by checkpatch.pl
Signed-off-by: NJoglekar Tejas <tjogleka@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes the error given by checkpatch.pl
" spaces required around that '>' "
Signed-off-by: NJoglekar Tejas <tjogleka@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Typo in a comment to register write corrected.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Added spaces after commas in initialization sequences and removed
unnecessary line continuations.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Placed comments to register writes before the function calls to
eliminate long strings and make code more readable.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Eliminated code duplication when searching for a display.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The patch removes spaces before tabs so that checkpatch.pl is content.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Removed unnecessary line continuations in several lines.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Split module description strings are merged for searchability.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Indentation with spaces fixed.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Put spaces around assignment operators for readability.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Split long function declarations, function calls, comments etc.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fix coding style issue "Missing a blank line after declarations"
detected by checkpatch.pl in visorchipset.c
Signed-off-by: NAlessandro Parini <alessandro.parini@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fix coding style issue "braces {} are not necessary for single statement blocks"
detected by checkpatch.pl in visorchipset.c
Signed-off-by: NAlessandro Parini <alessandro.parini@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

buf_unalloc is essentially a vme_free_consistent:
1) image[i].kern_buf is never NULL in buf_alloc call
2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Checking for image[minor].resource != NULL is not needed since all
resources are allocated before device is created.

image[minor].users accounting is deleted because it's not being used.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Reorder code so that forward declarations are not needed.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes checkpatch.pl warning.
WARNING: else is not generally useful after a break or return
Signed-off-by: NDogukan Ergun <dogukan.ergun@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove itypes.h that is not needed.
Signed-off-by: NChaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove BOOL_T typedef.
Signed-off-by: NChaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The iochannel.h file no longer needs to include
conttrolvmchannel.h, vbuschannel.h and vmcallinterfaces.h.
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Universe II datasheet defines following address space values
for LM_CTL[16:18]

000=A16
001=A24
010=A32
011,100,101=Reserved
110=User1
111=User2

Mask 5<<16 is not the right one for matching [16:18], instead we should
use 7<<16.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This makes vme_user_llseek ignore all minors that don't have llseek
implementation.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This moves DMA mapping of the first list element to vme_list_add, the
same place where other elements mappings occur. This prevents extra
mapping or over-unmapping in the cases when vme_list_exec is called more
or less than one time respectively.

Also adds dma_mapping_error check.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

DMA lists on tsi148 weren't processed further than the first item
because of the broken logic. This regression was introduced in:

ac1a4f2c "Staging: VME: Ensure TSI148 link list descriptors..."
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The function rtw_mfree_all_stainfo() is just holding the lock,
traversing the list, and then unlocking. It is not doing anything else.
So removed the function and modified the places from where it was called.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

These variables were being set but not used afterwards.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The CONFIGs, the enum and the function declaration was not being
used anywhere.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>